[jira] [Commented] (MESOS-3522) MesosScheduler declineOffer results in an acceptOffer

["Guangya Liu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952656#comment-14952656 ] 

Guangya Liu commented on MESOS-3522:
------------------------------------

I see that RR https://reviews.apache.org/r/38778/ was discarded, but we can indeed work on this based on https://reviews.apache.org/r/38778/

> MesosScheduler declineOffer results in an acceptOffer
> -----------------------------------------------------
>
>                 Key: MESOS-3522
>                 URL: https://issues.apache.org/jira/browse/MESOS-3522
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Jonathan Calmels
>            Assignee: Marco Massenzio
>            Priority: Minor
>              Labels: mesosphere
>
> Declining an offer through the MesosScheduler results in an empty task being accepted with no resources.
> Extract from the master log: "Processing ACCEPT call for offers ..."
> This is due to the implementation of declineOffer which effectively calls launchTasks with an empty TaskInfo list (sched.cpp:1926)
> launchTasks currently emits a Call::ACCEPT, leading to Master::accept (master.cpp:2634)
> Possible fixes include re-implementing declineOffer to emit a Call::DECLINE
> or change the launchTasks function to use the LaunchTasksMessage.
> I'm not really sure why there are two APIs (messages.proto and scheduler.proto) to do these tasks so I went with the later.
> [https://reviews.apache.org/r/38778/]
> Note the TODO would probably duplicate the code from acceptOffers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)