You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/20 07:10:51 UTC

[GitHub] [incubator-nuttx] standby24x7 opened a new pull request, #6886: rp2040: Add missing comma in rp2040_i2c_slave.c

standby24x7 opened a new pull request, #6886:
URL: https://github.com/apache/incubator-nuttx/pull/6886

   This patch fixes missing comma, found by cppcheck.
   
   rp2040_i2c_slave.c:259:0: error: failed to expand 'modbits_reg32',
    Wrong number of parameters for macro 'modbits_reg32'.
   
   Signed-off-by: Masanari Iida <st...@gmail.com>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6886: rp2040: Add missing comma in rp2040_i2c_slave.c

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6886:
URL: https://github.com/apache/incubator-nuttx/pull/6886#issuecomment-1221251337

   @standby24x7 is it possible to integrate cppcheck(or even https://github.com/Ericsson/codechecker) to CI system so we can catch the problem before merging?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6886: rp2040: Add missing comma in rp2040_i2c_slave.c

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6886:
URL: https://github.com/apache/incubator-nuttx/pull/6886


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org