[jira] [Updated] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of

["Andrew Purtell (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell updated HBASE-19249:
-----------------------------------
    Fix Version/s:     (was: 1.5.0)

> test for "hbase antipatterns" should check _count_ of occurance rather than text of
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-19249
>                 URL: https://issues.apache.org/jira/browse/HBASE-19249
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Critical
>             Fix For: 1.4.0, 1.3.2, 2.0.0-beta-1, 1.1.13, 2.0.0, 1.2.7
>
>         Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed to flag a use.
> looking at our check:
> {code}
>   warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
>   if [[ ${warnings} -gt 0 ]]; then
>     add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase: ${warnings}."
>     ((result=result+1))
>   fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely giving a negative on all these checks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)