You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/03/11 16:56:32 UTC
[GitHub] [incubator-druid] gianm commented on issue #7215: move jetty module
to Lifecycle.Stage.LAST
gianm commented on issue #7215: move jetty module to Lifecycle.Stage.LAST
URL: https://github.com/apache/incubator-druid/pull/7215#issuecomment-471626803
@clintropolis - I just realized that this may not actually solve the problem. It fixes one problem (Jetty stopping before the lookups module) but, I think, introduces another one. In the "after" log, Jetty stops before the historical unannounces itself fully:
```
2019-03-08T10:33:29,371 INFO [Thread-60] org.apache.druid.server.initialization.jetty.JettyServerModule - Waiting 10000 ms for unannouncement to propagate.
2019-03-08T10:33:39,371 INFO [Thread-60] org.apache.druid.server.initialization.jetty.JettyServerModule - Stopping Jetty Server...
2019-03-08T10:33:39,386 INFO [Thread-60] org.eclipse.jetty.server.AbstractConnector - Stopped ServerConnector@3a0aaaf0{HTTP/1.1,[http/1.1]}{0.0.0.0:8083}
2019-03-08T10:33:39,430 INFO [Thread-60] org.apache.druid.server.coordination.CuratorDataSegmentServerAnnouncer - Unannouncing self[DruidServerMetadata{name='localhost:8083', hostAndPort='localhost:8083', hostAndTlsPort='null', maxSize=10000000000, tier='_default_tier', type=historical, priority=0}] at [/druid/announcements/localhost:8083]
2019-03-08T10:33:39,430 INFO [Thread-60] org.apache.druid.curator.announcement.Announcer - unannouncing [/druid/announcements/localhost:8083]
2019-03-08T10:33:39,440 INFO [Thread-60] org.apache.druid.curator.announcement.Announcer - Stopping announcer
2019-03-08T10:33:39,440 INFO [Thread-60] org.apache.druid.curator.announcement.Announcer - unannouncing [/druid/segments/localhost:8083/localhost:8083_historical__default_tier_2019-03-08T10:33:15.556Z_8f9ee73fede947448b9f0f687490281b0]
```
Since the server is still announced in a way that the Broker ServerView can see, queries will keep coming in to it even after Jetty is stopped. To address this, I believe the SegmentLoadDropHandler, which manages the `/druid/announcements` announcement, needs to stop before the Jetty server does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org