You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "ppkarwasz (via GitHub)" <gi...@apache.org> on 2025/04/09 09:23:02 UTC

[PR] Add Develocity access key to Android build [logging-log4j-samples]

ppkarwasz opened a new pull request, #309:
URL: https://github.com/apache/logging-log4j-samples/pull/309

   The Android build needs our Develocity access token.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Develocity access key to Android build [logging-log4j-samples]

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #309:
URL: https://github.com/apache/logging-log4j-samples/pull/309#discussion_r2182879485


##########
.github/workflows/integration-test.yaml:
##########


Review Comment:
   Good point, although this is somehow orthogonal to the changes in this PR.
   I created issue #346 to track this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Develocity access key to Android build [logging-log4j-samples]

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz closed pull request #309: Add Develocity access key to Android build
URL: https://github.com/apache/logging-log4j-samples/pull/309


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Develocity access key to Android build [logging-log4j-samples]

Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on code in PR #309:
URL: https://github.com/apache/logging-log4j-samples/pull/309#discussion_r2181982311


##########
.github/workflows/gradle-reusable-test.yaml:
##########


Review Comment:
   Likewise, `gradle-test-reusable.yaml`?



##########
.github/workflows/integration-test.yaml:
##########


Review Comment:
   In line with our naming conventions in `logging-parent`, shouldn't this file be called `integration-test-reusable.yaml` instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add Develocity access key to Android build [logging-log4j-samples]

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #309:
URL: https://github.com/apache/logging-log4j-samples/pull/309#issuecomment-5078153684

   Closing this, since we currently don't use Develocity any more.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org