You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Scott Chen (Created) (JIRA)" <ji...@apache.org> on 2012/03/02 05:26:59 UTC
[jira] [Created] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() gets error for the case of
(framed, compact) = (true, false)
ThriftServerRunner.HbaseHandler.getRegionInfo() gets error for the case of (framed, compact) = (true, false)
------------------------------------------------------------------------------------------------------------
Key: HBASE-5507
URL: https://issues.apache.org/jira/browse/HBASE-5507
Project: HBase
Issue Type: Bug
Components: thrift
Reporter: Scott Chen
Assignee: Scott Chen
We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5507:
------------------------------
Comment: was deleted
(was: -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517181/HBASE-5507-0.94.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1109//console
This message is automatically generated.)
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.94.0
>
> Attachments: HBASE-5507-0.94.txt, HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch, HBASE-5507.D2073.3.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221788#comment-13221788 ]
Zhihong Yu commented on HBASE-5507:
-----------------------------------
TestThriftServer failed twice as reported by Hadoop QA.
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() gets error for the case of
(framed, compact) = (true, false)
Posted by "Scott Chen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220713#comment-13220713 ]
Scott Chen commented on HBASE-5507:
-----------------------------------
I also created a thrift JIRA
https://issues.apache.org/jira/browse/THRIFT-1531
> ThriftServerRunner.HbaseHandler.getRegionInfo() gets error for the case of (framed, compact) = (true, false)
> ------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222944#comment-13222944 ]
Hudson commented on HBASE-5507:
-------------------------------
Integrated in HBase-0.94 #14 (See [https://builds.apache.org/job/HBase-0.94/14/])
HBASE-5507 ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly (Scott chen) (Revision 1297322)
Result = SUCCESS
tedyu :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.94.0
>
> Attachments: HBASE-5507-0.94.txt, HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch, HBASE-5507.D2073.3.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5507:
-------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
This has been committed to 0.94 and trunk.
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.94.0
>
> Attachments: HBASE-5507-0.94.txt, HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch, HBASE-5507.D2073.3.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221775#comment-13221775 ]
Phabricator commented on HBASE-5507:
------------------------------------
sc has commented on the revision "HBASE-5507 [jira] ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly".
INLINE COMMENTS
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java:83 Yes, you're right. Sorry for leaving this here.
REVISION DETAIL
https://reviews.facebook.net/D2073
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: HBASE-5507.D2073.1.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5507:
-------------------------------
Attachment: HBASE-5507.D2073.1.patch
sc requested code review of "HBASE-5507 [jira] ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly".
Reviewers: tedyu, dhruba, JIRA
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
Task ID: #
Blame Rev:
We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
TEST PLAN
unit test
Revert Plan:
Tags:
REVISION DETAIL
https://reviews.facebook.net/D2073
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/4443/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: HBASE-5507.D2073.1.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221711#comment-13221711 ]
Phabricator commented on HBASE-5507:
------------------------------------
tedyu has commented on the revision "HBASE-5507 [jira] ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly".
INLINE COMMENTS
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java:83 This comment can be removed, right ?
REVISION DETAIL
https://reviews.facebook.net/D2073
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: HBASE-5507.D2073.1.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5507:
-------------------------------
Attachment: HBASE-5507.D2073.2.patch
sc updated the revision "HBASE-5507 [jira] ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly".
Reviewers: tedyu, dhruba, JIRA
Addressed Ted's review comments, thanks.
REVISION DETAIL
https://reviews.facebook.net/D2073
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221725#comment-13221725 ]
Hadoop QA commented on HBASE-5507:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12516961/HBASE-5507.D2073.1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -129 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 154 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.thrift.TestThriftServer
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1084//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1084//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1084//console
This message is automatically generated.
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: HBASE-5507.D2073.1.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5507:
------------------------------
Hadoop Flags: Reviewed
Status: Patch Available (was: Open)
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: HBASE-5507.D2073.1.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Scott Chen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen updated HBASE-5507:
------------------------------
Summary: ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly (was: ThriftServerRunner.HbaseHandler.getRegionInfo() gets error for the case of (framed, compact) = (true, false))
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222232#comment-13222232 ]
Hadoop QA commented on HBASE-5507:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517053/HBASE-5507.D2073.3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -129 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 154 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1098//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1098//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1098//console
This message is automatically generated.
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch, HBASE-5507.D2073.3.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223010#comment-13223010 ]
Hudson commented on HBASE-5507:
-------------------------------
Integrated in HBase-TRUNK-security #129 (See [https://builds.apache.org/job/HBase-TRUNK-security/129/])
HBASE-5507 ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly (Scott Chen) (Revision 1297300)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.94.0
>
> Attachments: HBASE-5507-0.94.txt, HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch, HBASE-5507.D2073.3.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222800#comment-13222800 ]
Zhihong Yu commented on HBASE-5507:
-----------------------------------
Integrated to TRUNK.
Thanks for the patch, Scott.
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.94.0
>
> Attachments: HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch, HBASE-5507.D2073.3.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5507:
------------------------------
Fix Version/s: 0.94.0
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.94.0
>
> Attachments: HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch, HBASE-5507.D2073.3.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Scott Chen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen updated HBASE-5507:
------------------------------
Attachment: HBASE-5507-0.94.txt
Attached the patch for 94.
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.94.0
>
> Attachments: HBASE-5507-0.94.txt, HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch, HBASE-5507.D2073.3.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222378#comment-13222378 ]
Phabricator commented on HBASE-5507:
------------------------------------
tedyu has accepted the revision "HBASE-5507 [jira] ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly".
REVISION DETAIL
https://reviews.facebook.net/D2073
BRANCH
5507
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch, HBASE-5507.D2073.3.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222924#comment-13222924 ]
Zhihong Yu commented on HBASE-5507:
-----------------------------------
Integrated to 0.94.
Thanks for the patch, Scott.
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.94.0
>
> Attachments: HBASE-5507-0.94.txt, HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch, HBASE-5507.D2073.3.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5507:
-------------------------------
Attachment: HBASE-5507.D2073.3.patch
sc updated the revision "HBASE-5507 [jira] ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly".
Reviewers: tedyu, dhruba, JIRA
Fix to pass TestThriftServer
REVISION DETAIL
https://reviews.facebook.net/D2073
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch, HBASE-5507.D2073.3.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221782#comment-13221782 ]
Hadoop QA commented on HBASE-5507:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12516969/HBASE-5507.D2073.2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -129 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 154 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.thrift.TestThriftServer
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1086//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1086//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1086//console
This message is automatically generated.
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222865#comment-13222865 ]
Hudson commented on HBASE-5507:
-------------------------------
Integrated in HBase-TRUNK #2672 (See [https://builds.apache.org/job/HBase-TRUNK/2672/])
HBASE-5507 ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly (Scott Chen) (Revision 1297300)
Result = SUCCESS
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.94.0
>
> Attachments: HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch, HBASE-5507.D2073.3.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222904#comment-13222904 ]
Hadoop QA commented on HBASE-5507:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517181/HBASE-5507-0.94.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1109//console
This message is automatically generated.
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.94.0
>
> Attachments: HBASE-5507-0.94.txt, HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch, HBASE-5507.D2073.3.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272657#comment-13272657 ]
Phabricator commented on HBASE-5507:
------------------------------------
sc has closed the revision "HBASE-5507 [jira] ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly".
REVISION DETAIL
https://reviews.facebook.net/D2073
To: tedyu, dhruba, JIRA, sc
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.94.0
>
> Attachments: HBASE-5507-0.94.txt, HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch, HBASE-5507.D2073.3.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222460#comment-13222460 ]
Zhihong Yu commented on HBASE-5507:
-----------------------------------
@Scott:
I assume the fix should also go to 0.94 branch.
{code}
2 out of 3 hunks FAILED -- saving rejects to file src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java.rej
patching file src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
Hunk #1 succeeded at 420 (offset -9 lines).
patching file src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
Reversed (or previously applied) patch detected! Assume -R? [n]
Apply anyway? [n]
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java.rej
{code}
Can you prepare a patch that applies to 0.94 cleanly ?
Thanks
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.94.0
>
> Attachments: HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch, HBASE-5507.D2073.3.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5507)
ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do
not use ByteBuffer correctly
Posted by "Scott Chen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222798#comment-13222798 ]
Scott Chen commented on HBASE-5507:
-----------------------------------
Ted: Yes. I will make a patch and upload here. Thanks!
> ThriftServerRunner.HbaseHandler.getRegionInfo() and getTableRegions() do not use ByteBuffer correctly
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-5507
> URL: https://issues.apache.org/jira/browse/HBASE-5507
> Project: HBase
> Issue Type: Bug
> Components: thrift
> Reporter: Scott Chen
> Assignee: Scott Chen
> Fix For: 0.94.0
>
> Attachments: HBASE-5507.D2073.1.patch, HBASE-5507.D2073.2.patch, HBASE-5507.D2073.3.patch
>
>
> We observed that when with "framed transport" option. The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning). This may be a thrift bug requires further investigation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira