You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/04/17 18:21:00 UTC
[jira] [Commented] (AIRFLOW-4343) Show warning in UI if scheduler
is not running.
[ https://issues.apache.org/jira/browse/AIRFLOW-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820389#comment-16820389 ]
ASF GitHub Bot commented on AIRFLOW-4343:
-----------------------------------------
ashb commented on pull request #5127: [AIRFLOW-4343] Show warning in UI if scheduler is not running
URL: https://github.com/apache/airflow/pull/5127
First commit is from #5125, look at the second commit only for now.
Make sure you have checked _all_ steps below.
### Jira
- [x]
- https://issues.apache.org/jira/browse/AIRFLOW-4343
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). - yes, Cat A
### Description
- [x] Now that the webserver is more stateless, if the scheduler is not
running the list of dags won't populate, making it harder for new
starters to work out what is going on.
**When scheduler has never run (I cleared Jobs table):**
**When scheduler not running (either crashed, or has stopped successfully)
(the time has a tooltip to display the full ISO8601 heartbeat)
Login screen/anything not subclassed from AirflowBaseView doesn't display the message.
On Login (not changed, doesn't show warning):
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: added tests for helper functions on BaseJob
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
/cc @Fokko as discussed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Show warning in UI if scheduler is not running.
> -----------------------------------------------
>
> Key: AIRFLOW-4343
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4343
> Project: Apache Airflow
> Issue Type: Sub-task
> Components: ui
> Reporter: Ash Berlin-Taylor
> Assignee: Ash Berlin-Taylor
> Priority: Major
> Fix For: 1.10.4
>
>
> Now that the webserver is more stateless, if the scheduler is not running the list of dags won't populate, making it harder for new starters to work out what is going on.
> We should display a warning if the scheduler isn't running (based on the job table heartbeat column)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)