You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "simicd (via GitHub)" <gi...@apache.org> on 2023/02/25 14:54:10 UTC
[GitHub] [arrow-datafusion-python] simicd opened a new pull request, #236: Feature/convert dataframe
simicd opened a new pull request, #236:
URL: https://github.com/apache/arrow-datafusion-python/pull/236
# Which issue does this PR close?
Closes #234
Closes #235
# Rationale for this change
Implement additional export functions and fix bug if datafusion dataframe is empty
# What changes are included in this PR?
- Implement `to_arrow_table()`, `to_pylist()` and `to_pydict()`
- Return empty dataframe/list/table instead of error if datafusion dataframe is empty
- Document these export functions
# Are there any user-facing changes?
See above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] simicd commented on a diff in pull request #236: feature: Additional export methods
Posted by "simicd (via GitHub)" <gi...@apache.org>.
simicd commented on code in PR #236:
URL: https://github.com/apache/arrow-datafusion-python/pull/236#discussion_r1117943147
##########
examples/export.py:
##########
@@ -0,0 +1,60 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import datafusion
+from datafusion import col
+import pyarrow
+import polars as pl
+
+
+# create a context
+ctx = datafusion.SessionContext()
+
+# create a RecordBatch and a new datafusion DataFrame from it
+batch = pyarrow.RecordBatch.from_arrays(
+ [pyarrow.array([1, 2, 3]), pyarrow.array([4, 5, 6])],
+ names=["a", "b"],
+)
+df = ctx.create_dataframe([[batch]])
+# Dataframe:
+# +---+---+
+# | a | b |
+# +---+---+
+# | 1 | 4 |
+# | 2 | 5 |
+# | 3 | 6 |
+# +---+---+
+
+# export to pandas dataframe
+pandas_df = df.to_pandas()
+assert pandas_df.shape == (3, 2)
+
+# export to PyArrow table
+arrow_table = df.to_arrow_table()
+assert arrow_table.shape == (3, 2)
+
+# export to Polars dataframe
+polars_df = pl.DataFrame(df.to_arrow_table())
+assert polars_df.shape == (3, 2)
Review Comment:
Thanks for the feedback - added `to_polars()` method & unit tests for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on a diff in pull request #236: feature: Additional export methods
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #236:
URL: https://github.com/apache/arrow-datafusion-python/pull/236#discussion_r1117937627
##########
examples/export.py:
##########
@@ -0,0 +1,60 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import datafusion
+from datafusion import col
+import pyarrow
+import polars as pl
+
+
+# create a context
+ctx = datafusion.SessionContext()
+
+# create a RecordBatch and a new datafusion DataFrame from it
+batch = pyarrow.RecordBatch.from_arrays(
+ [pyarrow.array([1, 2, 3]), pyarrow.array([4, 5, 6])],
+ names=["a", "b"],
+)
+df = ctx.create_dataframe([[batch]])
+# Dataframe:
+# +---+---+
+# | a | b |
+# +---+---+
+# | 1 | 4 |
+# | 2 | 5 |
+# | 3 | 6 |
+# +---+---+
+
+# export to pandas dataframe
+pandas_df = df.to_pandas()
+assert pandas_df.shape == (3, 2)
+
+# export to PyArrow table
+arrow_table = df.to_arrow_table()
+assert arrow_table.shape == (3, 2)
+
+# export to Polars dataframe
+polars_df = pl.DataFrame(df.to_arrow_table())
+assert polars_df.shape == (3, 2)
Review Comment:
Yes, I think that would be great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] simicd commented on a diff in pull request #236: Feature/convert dataframe
Posted by "simicd (via GitHub)" <gi...@apache.org>.
simicd commented on code in PR #236:
URL: https://github.com/apache/arrow-datafusion-python/pull/236#discussion_r1117935037
##########
examples/export.py:
##########
@@ -0,0 +1,60 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import datafusion
+from datafusion import col
+import pyarrow
+import polars as pl
+
+
+# create a context
+ctx = datafusion.SessionContext()
+
+# create a RecordBatch and a new datafusion DataFrame from it
+batch = pyarrow.RecordBatch.from_arrays(
+ [pyarrow.array([1, 2, 3]), pyarrow.array([4, 5, 6])],
+ names=["a", "b"],
+)
+df = ctx.create_dataframe([[batch]])
+# Dataframe:
+# +---+---+
+# | a | b |
+# +---+---+
+# | 1 | 4 |
+# | 2 | 5 |
+# | 3 | 6 |
+# +---+---+
+
+# export to pandas dataframe
+pandas_df = df.to_pandas()
+assert pandas_df.shape == (3, 2)
+
+# export to PyArrow table
+arrow_table = df.to_arrow_table()
+assert arrow_table.shape == (3, 2)
+
+# export to Polars dataframe
+polars_df = pl.DataFrame(df.to_arrow_table())
+assert polars_df.shape == (3, 2)
Review Comment:
Do you think it's worthwhile introducing a `to_polars()` helper function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove merged pull request #236: feature: Additional export methods
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #236:
URL: https://github.com/apache/arrow-datafusion-python/pull/236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org