You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/01 10:53:40 UTC
[GitHub] [airflow] potiuk edited a comment on issue #6987: [AIRFLOW-6416]
Remove DB provide_session and sort by conn_id
potiuk edited a comment on issue #6987: [AIRFLOW-6416] Remove DB provide_session and sort by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570042926
> And we could not remove @provide_session in function `merge_conn` due to some unittest use it to create temp connections, do we? @potiuk
The @provide_session decorator (and merge_conn uses it) follow exactly the pattern of session/transaction passing. It's there to handle the case that a session is created once, transaction starts, and you reuse the session do everything in the same DB transaction. So it is really needed :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services