You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/06/19 17:48:24 UTC
[jira] [Commented] (CLIMATE-475) Make metric imports in ocw.tests
not explicit
[ https://issues.apache.org/jira/browse/CLIMATE-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037448#comment-14037448 ]
ASF GitHub Bot commented on CLIMATE-475:
----------------------------------------
GitHub user MJJoyce opened a pull request:
https://github.com/apache/climate/pull/77
CLIMATE-475 - Fix metric imports in ocw.tests.test_metrics
- Remove explicit metric class imports from ocw.metrics so the import
list doesn't become insanely long and unwieldy. Metrics now need to
reference 'metrics' when they're called throughout the tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MJJoyce/climate CLIMATE-475
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
----
commit ae8584c295e7cf90b74a6a84c5afa082b8d6fa93
Author: Michael Joyce <jo...@apache.org>
Date: 2014-06-19T15:44:17Z
CLIMATE-475 - Fix metric imports in ocw.tests.test_metrics
- Remove explicit metric class imports from ocw.metrics so the import
list doesn't become insanely long and unwieldy. Metrics now need to
reference 'metrics' when they're called throughout the tests.
----
> Make metric imports in ocw.tests not explicit
> ---------------------------------------------
>
> Key: CLIMATE-475
> URL: https://issues.apache.org/jira/browse/CLIMATE-475
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Components: general, metrics
> Affects Versions: 0.3-incubating
> Reporter: Michael Joyce
> Assignee: Michael Joyce
> Priority: Minor
> Fix For: 0.4
>
>
> The imports in ocw.tests.test_metrics.py are explicit for each metric being tested. As we add more and more metrics this is becoming rather unwieldy. Let's switch over to a more relaxed import and specify the package when running the metrics in our tests.
--
This message was sent by Atlassian JIRA
(v6.2#6252)