You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Catherine Hope (JIRA)" <ji...@apache.org> on 2009/10/15 15:56:31 UTC
[jira] Created: (HARMONY-6356) [classlib][lang-managment]
Improvements to lang-management classes from findbugs
[classlib][lang-managment] Improvements to lang-management classes from findbugs
--------------------------------------------------------------------------------
Key: HARMONY-6356
URL: https://issues.apache.org/jira/browse/HARMONY-6356
Project: Harmony
Issue Type: Improvement
Components: Classlib
Environment: all
Reporter: Catherine Hope
Priority: Minor
Attachments: lang-managment.patch
Improvements to lang-management classes from running findbugs, and exclusions list.
Most changes are performance suggestions, e.g. Boolean.valueOf and removing new String(<existing String>), and some redundant logic, e.g. String fileNameValue = (fileName == null) ? null : new String(fileName)
The exclude is for returning a mutable object from java.lang.management.ThreadInfo.getStackTrace(), but I checked the RI and it does the same, so I didn't make any changes:
StackTraceElement[] stack1 = ti.getStackTrace();
String dummyData = "dummy";
StackTraceElement dummyElement = new StackTraceElement(dummyData, dummyData, dummyData, 0);
stack1[0] = dummyElement;
StackTraceElement[] stack2 = ti.getStackTrace();
assertNotSame(stack1[0], stack2[0]); // this fails on Sun and Harmony
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6356) [classlib][lang-managment]
Improvements to lang-management classes from findbugs
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766520#action_12766520 ]
Hudson commented on HARMONY-6356:
---------------------------------
Integrated in Harmony-1.5-head-linux-x86_64 #505 (See [http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/505/])
Commit patch for ([classlib][lang-managment] Improvements to lang-management classes from findbugs)
> [classlib][lang-managment] Improvements to lang-management classes from findbugs
> --------------------------------------------------------------------------------
>
> Key: HARMONY-6356
> URL: https://issues.apache.org/jira/browse/HARMONY-6356
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: all
> Reporter: Catherine Hope
> Assignee: Oliver Deakin
> Priority: Minor
> Fix For: 5.0M12
>
> Attachments: lang-managment.patch
>
>
> Improvements to lang-management classes from running findbugs, and exclusions list.
> Most changes are performance suggestions, e.g. Boolean.valueOf and removing new String(<existing String>), and some redundant logic, e.g. String fileNameValue = (fileName == null) ? null : new String(fileName)
> The exclude is for returning a mutable object from java.lang.management.ThreadInfo.getStackTrace(), but I checked the RI and it does the same, so I didn't make any changes:
> StackTraceElement[] stack1 = ti.getStackTrace();
> String dummyData = "dummy";
> StackTraceElement dummyElement = new StackTraceElement(dummyData, dummyData, dummyData, 0);
> stack1[0] = dummyElement;
> StackTraceElement[] stack2 = ti.getStackTrace();
> assertNotSame(stack1[0], stack2[0]); // this fails on Sun and Harmony
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-6356) [classlib][lang-managment]
Improvements to lang-management classes from findbugs
Posted by "Catherine Hope (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Catherine Hope closed HARMONY-6356.
-----------------------------------
Verified
> [classlib][lang-managment] Improvements to lang-management classes from findbugs
> --------------------------------------------------------------------------------
>
> Key: HARMONY-6356
> URL: https://issues.apache.org/jira/browse/HARMONY-6356
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: all
> Reporter: Catherine Hope
> Assignee: Oliver Deakin
> Priority: Minor
> Fix For: 5.0M12
>
> Attachments: lang-managment.patch
>
>
> Improvements to lang-management classes from running findbugs, and exclusions list.
> Most changes are performance suggestions, e.g. Boolean.valueOf and removing new String(<existing String>), and some redundant logic, e.g. String fileNameValue = (fileName == null) ? null : new String(fileName)
> The exclude is for returning a mutable object from java.lang.management.ThreadInfo.getStackTrace(), but I checked the RI and it does the same, so I didn't make any changes:
> StackTraceElement[] stack1 = ti.getStackTrace();
> String dummyData = "dummy";
> StackTraceElement dummyElement = new StackTraceElement(dummyData, dummyData, dummyData, 0);
> stack1[0] = dummyElement;
> StackTraceElement[] stack2 = ti.getStackTrace();
> assertNotSame(stack1[0], stack2[0]); // this fails on Sun and Harmony
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6356) [classlib][lang-managment]
Improvements to lang-management classes from findbugs
Posted by "Catherine Hope (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Catherine Hope updated HARMONY-6356:
------------------------------------
Attachment: lang-managment.patch
> [classlib][lang-managment] Improvements to lang-management classes from findbugs
> --------------------------------------------------------------------------------
>
> Key: HARMONY-6356
> URL: https://issues.apache.org/jira/browse/HARMONY-6356
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: all
> Reporter: Catherine Hope
> Priority: Minor
> Attachments: lang-managment.patch
>
>
> Improvements to lang-management classes from running findbugs, and exclusions list.
> Most changes are performance suggestions, e.g. Boolean.valueOf and removing new String(<existing String>), and some redundant logic, e.g. String fileNameValue = (fileName == null) ? null : new String(fileName)
> The exclude is for returning a mutable object from java.lang.management.ThreadInfo.getStackTrace(), but I checked the RI and it does the same, so I didn't make any changes:
> StackTraceElement[] stack1 = ti.getStackTrace();
> String dummyData = "dummy";
> StackTraceElement dummyElement = new StackTraceElement(dummyData, dummyData, dummyData, 0);
> stack1[0] = dummyElement;
> StackTraceElement[] stack2 = ti.getStackTrace();
> assertNotSame(stack1[0], stack2[0]); // this fails on Sun and Harmony
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-6356) [classlib][lang-managment]
Improvements to lang-management classes from findbugs
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Deakin resolved HARMONY-6356.
------------------------------------
Resolution: Fixed
Fix Version/s: 5.0M12
Thanks Catherine - patch applied at repo revision r825865. Please check the patch applied as expected.
> [classlib][lang-managment] Improvements to lang-management classes from findbugs
> --------------------------------------------------------------------------------
>
> Key: HARMONY-6356
> URL: https://issues.apache.org/jira/browse/HARMONY-6356
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: all
> Reporter: Catherine Hope
> Assignee: Oliver Deakin
> Priority: Minor
> Fix For: 5.0M12
>
> Attachments: lang-managment.patch
>
>
> Improvements to lang-management classes from running findbugs, and exclusions list.
> Most changes are performance suggestions, e.g. Boolean.valueOf and removing new String(<existing String>), and some redundant logic, e.g. String fileNameValue = (fileName == null) ? null : new String(fileName)
> The exclude is for returning a mutable object from java.lang.management.ThreadInfo.getStackTrace(), but I checked the RI and it does the same, so I didn't make any changes:
> StackTraceElement[] stack1 = ti.getStackTrace();
> String dummyData = "dummy";
> StackTraceElement dummyElement = new StackTraceElement(dummyData, dummyData, dummyData, 0);
> stack1[0] = dummyElement;
> StackTraceElement[] stack2 = ti.getStackTrace();
> assertNotSame(stack1[0], stack2[0]); // this fails on Sun and Harmony
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-6356) [classlib][lang-managment]
Improvements to lang-management classes from findbugs
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Deakin reassigned HARMONY-6356:
--------------------------------------
Assignee: Oliver Deakin
> [classlib][lang-managment] Improvements to lang-management classes from findbugs
> --------------------------------------------------------------------------------
>
> Key: HARMONY-6356
> URL: https://issues.apache.org/jira/browse/HARMONY-6356
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: all
> Reporter: Catherine Hope
> Assignee: Oliver Deakin
> Priority: Minor
> Attachments: lang-managment.patch
>
>
> Improvements to lang-management classes from running findbugs, and exclusions list.
> Most changes are performance suggestions, e.g. Boolean.valueOf and removing new String(<existing String>), and some redundant logic, e.g. String fileNameValue = (fileName == null) ? null : new String(fileName)
> The exclude is for returning a mutable object from java.lang.management.ThreadInfo.getStackTrace(), but I checked the RI and it does the same, so I didn't make any changes:
> StackTraceElement[] stack1 = ti.getStackTrace();
> String dummyData = "dummy";
> StackTraceElement dummyElement = new StackTraceElement(dummyData, dummyData, dummyData, 0);
> stack1[0] = dummyElement;
> StackTraceElement[] stack2 = ti.getStackTrace();
> assertNotSame(stack1[0], stack2[0]); // this fails on Sun and Harmony
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.