You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/05/27 10:03:07 UTC
Review Request 21923: CLOUDSTACK-5342: Fix for failure in adding network to
VM
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21923/
-----------------------------------------------------------
Review request for cloudstack and Santhosh Edukulla.
Bugs: CLOUDSTACK-5342
https://issues.apache.org/jira/browse/CLOUDSTACK-5342
Repository: cloudstack-git
Description
-------
Few test cases are failing while adding NIC to VM, because if add nic operation is done immediately after remove nic operation on the same VM, it fails. This is identified as qemu issue. But we can handle it through test case by avoiding this by spawning new VM wherever required. Adding delay doesn't help.
Please go through discussion (https://issues.apache.org/jira/browse/CLOUDSTACK-5342) for more info.
Diffs
-----
test/integration/component/test_add_remove_network.py c17293d
tools/marvin/marvin/lib/base.py c975c37
Diff: https://reviews.apache.org/r/21923/diff/
Testing
-------
Yes.
Log:
Add network to running VM ... SKIP: skip
Add network to stopped VM ... === TestName: test_02_add_nw_stopped_vm_1_isolated | Status : SUCCESS ===
ok
Add network to stopped VM ... === TestName: test_02_add_nw_stopped_vm_2_shared | Status : SUCCESS ===
ok
Add same network multiple times to running VM ... === TestName: test_03_add_nw_multiple_times_1_isolated | Status : SUCCESS ===
ok
Add same network multiple times to running VM ... === TestName: test_03_add_nw_multiple_times_2_shared | Status : SUCCESS ===
ok
Add VPC network to running VM belonging to isolated network ... === TestName: test_04_vpc_nw_running_vm_1_isolated | Status : SUCCESS ===
ok
Add network and ip address to running VM ... === TestName: test_06_add_nw_ipaddress_running_vm | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 7 tests in 902.523s
OK (SKIP=1)
Thanks,
Gaurav Aradhye
Re: Review Request 21923: CLOUDSTACK-5342: Fix for failure in adding network
to VM
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21923/#review43961
-----------------------------------------------------------
Commit 0cc826aa53286f66232d6287aa05341f0138cdd1 in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0cc826a ]
CLOUDSTACK-5342: Fix for failure in adding network to VM
- ASF Subversion and Git Services
On May 27, 2014, 8:03 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21923/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 8:03 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-5342
> https://issues.apache.org/jira/browse/CLOUDSTACK-5342
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Few test cases are failing while adding NIC to VM, because if add nic operation is done immediately after remove nic operation on the same VM, it fails. This is identified as qemu issue. But we can handle it through test case by avoiding this by spawning new VM wherever required. Adding delay doesn't help.
> Please go through discussion (https://issues.apache.org/jira/browse/CLOUDSTACK-5342) for more info.
>
>
> Diffs
> -----
>
> test/integration/component/test_add_remove_network.py c17293d
> tools/marvin/marvin/lib/base.py c975c37
>
> Diff: https://reviews.apache.org/r/21923/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Log:
> Add network to running VM ... SKIP: skip
> Add network to stopped VM ... === TestName: test_02_add_nw_stopped_vm_1_isolated | Status : SUCCESS ===
> ok
> Add network to stopped VM ... === TestName: test_02_add_nw_stopped_vm_2_shared | Status : SUCCESS ===
> ok
> Add same network multiple times to running VM ... === TestName: test_03_add_nw_multiple_times_1_isolated | Status : SUCCESS ===
> ok
> Add same network multiple times to running VM ... === TestName: test_03_add_nw_multiple_times_2_shared | Status : SUCCESS ===
> ok
> Add VPC network to running VM belonging to isolated network ... === TestName: test_04_vpc_nw_running_vm_1_isolated | Status : SUCCESS ===
> ok
> Add network and ip address to running VM ... === TestName: test_06_add_nw_ipaddress_running_vm | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 7 tests in 902.523s
>
> OK (SKIP=1)
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 21923: CLOUDSTACK-5342: Fix for failure in adding network
to VM
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21923/#review43964
-----------------------------------------------------------
Commit 24ef79aef82b69015c6e552258c4829d5a15a9d8 in cloudstack's branch refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=24ef79a ]
CLOUDSTACK-5342: Fix for failure in adding network to VM
- ASF Subversion and Git Services
On May 27, 2014, 8:03 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21923/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 8:03 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-5342
> https://issues.apache.org/jira/browse/CLOUDSTACK-5342
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Few test cases are failing while adding NIC to VM, because if add nic operation is done immediately after remove nic operation on the same VM, it fails. This is identified as qemu issue. But we can handle it through test case by avoiding this by spawning new VM wherever required. Adding delay doesn't help.
> Please go through discussion (https://issues.apache.org/jira/browse/CLOUDSTACK-5342) for more info.
>
>
> Diffs
> -----
>
> test/integration/component/test_add_remove_network.py c17293d
> tools/marvin/marvin/lib/base.py c975c37
>
> Diff: https://reviews.apache.org/r/21923/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Log:
> Add network to running VM ... SKIP: skip
> Add network to stopped VM ... === TestName: test_02_add_nw_stopped_vm_1_isolated | Status : SUCCESS ===
> ok
> Add network to stopped VM ... === TestName: test_02_add_nw_stopped_vm_2_shared | Status : SUCCESS ===
> ok
> Add same network multiple times to running VM ... === TestName: test_03_add_nw_multiple_times_1_isolated | Status : SUCCESS ===
> ok
> Add same network multiple times to running VM ... === TestName: test_03_add_nw_multiple_times_2_shared | Status : SUCCESS ===
> ok
> Add VPC network to running VM belonging to isolated network ... === TestName: test_04_vpc_nw_running_vm_1_isolated | Status : SUCCESS ===
> ok
> Add network and ip address to running VM ... === TestName: test_06_add_nw_ipaddress_running_vm | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 7 tests in 902.523s
>
> OK (SKIP=1)
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 21923: CLOUDSTACK-5342: Fix for failure in adding network
to VM
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21923/#review43958
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On May 27, 2014, 8:03 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21923/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 8:03 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-5342
> https://issues.apache.org/jira/browse/CLOUDSTACK-5342
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Few test cases are failing while adding NIC to VM, because if add nic operation is done immediately after remove nic operation on the same VM, it fails. This is identified as qemu issue. But we can handle it through test case by avoiding this by spawning new VM wherever required. Adding delay doesn't help.
> Please go through discussion (https://issues.apache.org/jira/browse/CLOUDSTACK-5342) for more info.
>
>
> Diffs
> -----
>
> test/integration/component/test_add_remove_network.py c17293d
> tools/marvin/marvin/lib/base.py c975c37
>
> Diff: https://reviews.apache.org/r/21923/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Log:
> Add network to running VM ... SKIP: skip
> Add network to stopped VM ... === TestName: test_02_add_nw_stopped_vm_1_isolated | Status : SUCCESS ===
> ok
> Add network to stopped VM ... === TestName: test_02_add_nw_stopped_vm_2_shared | Status : SUCCESS ===
> ok
> Add same network multiple times to running VM ... === TestName: test_03_add_nw_multiple_times_1_isolated | Status : SUCCESS ===
> ok
> Add same network multiple times to running VM ... === TestName: test_03_add_nw_multiple_times_2_shared | Status : SUCCESS ===
> ok
> Add VPC network to running VM belonging to isolated network ... === TestName: test_04_vpc_nw_running_vm_1_isolated | Status : SUCCESS ===
> ok
> Add network and ip address to running VM ... === TestName: test_06_add_nw_ipaddress_running_vm | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 7 tests in 902.523s
>
> OK (SKIP=1)
>
>
> Thanks,
>
> Gaurav Aradhye
>
>