You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhuvanthi Radhakrishnan <mr...@hortonworks.com> on 2017/03/29 17:16:28 UTC
Review Request 58031: Ensure only HMS can be deployed with an
external store on a cluster
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58031/
-----------------------------------------------------------
Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
Bugs: AMBARI-20615
https://issues.apache.org/jira/browse/AMBARI-20615
Repository: ambari
Description
-------
HMS does not require mapred configs so we need to add a condition so that HMS can be deployed without yarn
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py b7b04a2095
Diff: https://reviews.apache.org/r/58031/diff/1/
Testing
-------
Deployed a single node cluster using HMS-Zookeeper only blueprint.
Run python unit tests.
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 58031: Ensure only HMS can be deployed with an
external store on a cluster
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58031/#review170433
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
Lines 349 (patched)
<https://reviews.apache.org/r/58031/#comment243257>
This change is also needed in Hive common-services for version 3.0
- Alejandro Fernandez
On March 29, 2017, 5:16 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58031/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 5:16 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20615
> https://issues.apache.org/jira/browse/AMBARI-20615
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HMS does not require mapred configs so we need to add a condition so that HMS can be deployed without yarn
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py b7b04a2095
>
>
> Diff: https://reviews.apache.org/r/58031/diff/1/
>
>
> Testing
> -------
>
> Deployed a single node cluster using HMS-Zookeeper only blueprint.
> Run python unit tests.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58031: Ensure only HMS can be deployed with an
external store on a cluster
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58031/#review170494
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
Line 101 (original), 101 (patched)
<https://reviews.apache.org/r/58031/#comment243329>
Nit, space after comma - few occurrences in the code.
- Sumit Mohanty
On March 29, 2017, 5:45 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58031/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 5:45 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20615
> https://issues.apache.org/jira/browse/AMBARI-20615
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HMS does not require mapred configs so we need to add a condition so that HMS can be deployed without yarn
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py b7b04a2095
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 2ed3e3a26a
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py b7b04a2095
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py 2ed3e3a26a
>
>
> Diff: https://reviews.apache.org/r/58031/diff/2/
>
>
> Testing
> -------
>
> Deployed a single node cluster using HMS-Zookeeper only blueprint.
> Run python unit tests.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58031: Ensure only HMS can be deployed with an
external store on a cluster
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58031/#review170446
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On March 29, 2017, 5:45 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58031/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 5:45 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20615
> https://issues.apache.org/jira/browse/AMBARI-20615
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HMS does not require mapred configs so we need to add a condition so that HMS can be deployed without yarn
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py b7b04a2095
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 2ed3e3a26a
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py b7b04a2095
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py 2ed3e3a26a
>
>
> Diff: https://reviews.apache.org/r/58031/diff/2/
>
>
> Testing
> -------
>
> Deployed a single node cluster using HMS-Zookeeper only blueprint.
> Run python unit tests.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58031: Ensure only HMS can be deployed with an
external store on a cluster
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58031/#review170573
-----------------------------------------------------------
Fix it, then Ship it!
Overall, the patch looks fine, I have just a minor issue/question regarding commenting out the test assertions as strings.
If the intention is to comment out these assertions, then the assertions should be removed instead.
Thanks.
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py
Lines 164 (patched)
<https://reviews.apache.org/r/58031/#comment243427>
I'm not a Python expert, but it looks like some test assertions are effectively being commented out here, by denoting the assertions as part of a string.
If my understanding is correct, this doesn't seem right to me.
I think it might be better to remove these assertions, if they are no longer needed.
- Robert Nettleton
On March 29, 2017, 11:57 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58031/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 11:57 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20615
> https://issues.apache.org/jira/browse/AMBARI-20615
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HMS does not require mapred configs so we need to add a condition so that HMS can be deployed without yarn
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 5f566174b8
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py b7b04a2095
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 2ed3e3a26a
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py b7b04a2095
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py 2ed3e3a26a
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 9486e11e46
> ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py a159cd0370
>
>
> Diff: https://reviews.apache.org/r/58031/diff/3/
>
>
> Testing
> -------
>
> Deployed a single node cluster using HMS-Zookeeper only blueprint.
> Deployed a regular cluster and added hive service wih existing mysql. Verified that no regression occurs.
> Run python unit tests.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58031: Ensure only HMS can be deployed with an
external store on a cluster
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
> On March 30, 2017, 4:46 p.m., Jayush Luniya wrote:
> > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py
> > Lines 203 (patched)
> > <https://reviews.apache.org/r/58031/diff/3/?file=1680492#file1680492line203>
> >
> > Why is this commented out?
The fix,
if name != 'metastore':
XmlConfig("mapred-site.xml",
skips the mapred-site.xml resource for hive-metastore so this test was failing that resource not found. But that is expected so I thought we would not need this test anymore.
- Madhuvanthi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58031/#review170595
-----------------------------------------------------------
On March 29, 2017, 11:57 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58031/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 11:57 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20615
> https://issues.apache.org/jira/browse/AMBARI-20615
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HMS does not require mapred configs so we need to add a condition so that HMS can be deployed without yarn
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 5f566174b8
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py b7b04a2095
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 2ed3e3a26a
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py b7b04a2095
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py 2ed3e3a26a
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 9486e11e46
> ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py a159cd0370
>
>
> Diff: https://reviews.apache.org/r/58031/diff/3/
>
>
> Testing
> -------
>
> Deployed a single node cluster using HMS-Zookeeper only blueprint.
> Deployed a regular cluster and added hive service wih existing mysql. Verified that no regression occurs.
> Run python unit tests.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58031: Ensure only HMS can be deployed with an
external store on a cluster
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
> On March 30, 2017, 4:46 p.m., Jayush Luniya wrote:
> > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py
> > Lines 203 (patched)
> > <https://reviews.apache.org/r/58031/diff/3/?file=1680492#file1680492line203>
> >
> > Why is this commented out?
>
> Madhuvanthi Radhakrishnan wrote:
> The fix,
> if name != 'metastore':
> XmlConfig("mapred-site.xml",
> skips the mapred-site.xml resource for hive-metastore so this test was failing that resource not found. But that is expected so I thought we would not need this test anymore.
>
> Jayush Luniya wrote:
> But we should remove the deadcode and not comment it out right?
I will fix that. Thanks
- Madhuvanthi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58031/#review170595
-----------------------------------------------------------
On March 29, 2017, 11:57 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58031/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 11:57 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20615
> https://issues.apache.org/jira/browse/AMBARI-20615
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HMS does not require mapred configs so we need to add a condition so that HMS can be deployed without yarn
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 5f566174b8
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py b7b04a2095
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 2ed3e3a26a
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py b7b04a2095
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py 2ed3e3a26a
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 9486e11e46
> ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py a159cd0370
>
>
> Diff: https://reviews.apache.org/r/58031/diff/3/
>
>
> Testing
> -------
>
> Deployed a single node cluster using HMS-Zookeeper only blueprint.
> Deployed a regular cluster and added hive service wih existing mysql. Verified that no regression occurs.
> Run python unit tests.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58031: Ensure only HMS can be deployed with an
external store on a cluster
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On March 30, 2017, 4:46 p.m., Jayush Luniya wrote:
> > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py
> > Lines 203 (patched)
> > <https://reviews.apache.org/r/58031/diff/3/?file=1680492#file1680492line203>
> >
> > Why is this commented out?
>
> Madhuvanthi Radhakrishnan wrote:
> The fix,
> if name != 'metastore':
> XmlConfig("mapred-site.xml",
> skips the mapred-site.xml resource for hive-metastore so this test was failing that resource not found. But that is expected so I thought we would not need this test anymore.
>
> Jayush Luniya wrote:
> But we should remove the deadcode and not comment it out right?
>
> Madhuvanthi Radhakrishnan wrote:
> I will fix that. Thanks
+1 to remove deadcode
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58031/#review170595
-----------------------------------------------------------
On March 29, 2017, 11:57 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58031/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 11:57 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20615
> https://issues.apache.org/jira/browse/AMBARI-20615
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HMS does not require mapred configs so we need to add a condition so that HMS can be deployed without yarn
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 5f566174b8
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py b7b04a2095
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 2ed3e3a26a
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py b7b04a2095
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py 2ed3e3a26a
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 9486e11e46
> ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py a159cd0370
>
>
> Diff: https://reviews.apache.org/r/58031/diff/3/
>
>
> Testing
> -------
>
> Deployed a single node cluster using HMS-Zookeeper only blueprint.
> Deployed a regular cluster and added hive service wih existing mysql. Verified that no regression occurs.
> Run python unit tests.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58031: Ensure only HMS can be deployed with an
external store on a cluster
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On March 30, 2017, 4:46 p.m., Jayush Luniya wrote:
> > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py
> > Lines 203 (patched)
> > <https://reviews.apache.org/r/58031/diff/3/?file=1680492#file1680492line203>
> >
> > Why is this commented out?
>
> Madhuvanthi Radhakrishnan wrote:
> The fix,
> if name != 'metastore':
> XmlConfig("mapred-site.xml",
> skips the mapred-site.xml resource for hive-metastore so this test was failing that resource not found. But that is expected so I thought we would not need this test anymore.
But we should remove the deadcode and not comment it out right?
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58031/#review170595
-----------------------------------------------------------
On March 29, 2017, 11:57 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58031/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 11:57 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20615
> https://issues.apache.org/jira/browse/AMBARI-20615
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HMS does not require mapred configs so we need to add a condition so that HMS can be deployed without yarn
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 5f566174b8
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py b7b04a2095
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 2ed3e3a26a
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py b7b04a2095
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py 2ed3e3a26a
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 9486e11e46
> ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py a159cd0370
>
>
> Diff: https://reviews.apache.org/r/58031/diff/3/
>
>
> Testing
> -------
>
> Deployed a single node cluster using HMS-Zookeeper only blueprint.
> Deployed a regular cluster and added hive service wih existing mysql. Verified that no regression occurs.
> Run python unit tests.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58031: Ensure only HMS can be deployed with an
external store on a cluster
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58031/#review170595
-----------------------------------------------------------
ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py
Lines 203 (patched)
<https://reviews.apache.org/r/58031/#comment243457>
Why is this commented out?
- Jayush Luniya
On March 29, 2017, 11:57 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58031/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 11:57 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20615
> https://issues.apache.org/jira/browse/AMBARI-20615
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HMS does not require mapred configs so we need to add a condition so that HMS can be deployed without yarn
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 5f566174b8
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py b7b04a2095
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 2ed3e3a26a
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py b7b04a2095
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py 2ed3e3a26a
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 9486e11e46
> ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py a159cd0370
>
>
> Diff: https://reviews.apache.org/r/58031/diff/3/
>
>
> Testing
> -------
>
> Deployed a single node cluster using HMS-Zookeeper only blueprint.
> Deployed a regular cluster and added hive service wih existing mysql. Verified that no regression occurs.
> Run python unit tests.
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58031: Ensure only HMS can be deployed with an
external store on a cluster
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58031/
-----------------------------------------------------------
(Updated March 29, 2017, 11:57 p.m.)
Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
Changes
-------
Review comments.
Commented some tests cases for test_hive_metastore.py which checks if mapred-site config exists.
Made a change to hive-env.xml, java_home is not set anywhere in hive service.
Bugs: AMBARI-20615
https://issues.apache.org/jira/browse/AMBARI-20615
Repository: ambari
Description
-------
HMS does not require mapred configs so we need to add a condition so that HMS can be deployed without yarn
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 5f566174b8
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py b7b04a2095
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 2ed3e3a26a
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py b7b04a2095
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py 2ed3e3a26a
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 9486e11e46
ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py a159cd0370
Diff: https://reviews.apache.org/r/58031/diff/3/
Changes: https://reviews.apache.org/r/58031/diff/2-3/
Testing (updated)
-------
Deployed a single node cluster using HMS-Zookeeper only blueprint.
Deployed a regular cluster and added hive service wih existing mysql. Verified that no regression occurs.
Run python unit tests.
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 58031: Ensure only HMS can be deployed with an
external store on a cluster
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58031/
-----------------------------------------------------------
(Updated March 29, 2017, 5:45 p.m.)
Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
Changes
-------
Changed logic to identify hive-metastore component.
Bugs: AMBARI-20615
https://issues.apache.org/jira/browse/AMBARI-20615
Repository: ambari
Description
-------
HMS does not require mapred configs so we need to add a condition so that HMS can be deployed without yarn
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py b7b04a2095
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 2ed3e3a26a
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py b7b04a2095
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py 2ed3e3a26a
Diff: https://reviews.apache.org/r/58031/diff/2/
Changes: https://reviews.apache.org/r/58031/diff/1-2/
Testing
-------
Deployed a single node cluster using HMS-Zookeeper only blueprint.
Run python unit tests.
Thanks,
Madhuvanthi Radhakrishnan