You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/03 21:04:05 UTC

[GitHub] [spark] huaxingao commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

huaxingao commented on pull request #28710:
URL: https://github.com/apache/spark/pull/28710#issuecomment-638460384


   I put probabilityCol back in the subclass and this should fix the test failure I had yesterday :)
   For the multiclass classification or binary classification metrics we need, seems to me that either one of probability or raw prediction is good enough. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org