You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/03/15 04:50:35 UTC
[GitHub] [camel-k] ajbisht opened a new pull request #3119: Create aks.cdoc
ajbisht opened a new pull request #3119:
URL: https://github.com/apache/camel-k/pull/3119
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3119: Create aks.cdoc
Posted by GitBox <gi...@apache.org>.
tadayosi commented on pull request #3119:
URL: https://github.com/apache/camel-k/pull/3119#issuecomment-1072028827
I don't mind it if the author is inactive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3119: Create aks.cdoc
Posted by GitBox <gi...@apache.org>.
tadayosi commented on pull request #3119:
URL: https://github.com/apache/camel-k/pull/3119#issuecomment-1072028827
I don't mind it if the author is inactive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi edited a comment on pull request #3119: Create aks.cdoc
Posted by GitBox <gi...@apache.org>.
tadayosi edited a comment on pull request #3119:
URL: https://github.com/apache/camel-k/pull/3119#issuecomment-1072028827
I'm fine with merging it if the author is inactive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] claudio4j commented on a change in pull request #3119: Create aks.cdoc
Posted by GitBox <gi...@apache.org>.
claudio4j commented on a change in pull request #3119:
URL: https://github.com/apache/camel-k/pull/3119#discussion_r837699823
##########
File path: docs/modules/ROOT/pages/installation/platform/aks.cdoc
##########
@@ -0,0 +1,34 @@
+Apache Camel K is a lightweight integration platform, born on Kubernetes,
+with serverless superpowers.
+
+# Camel K deployment in AKS
+
+## Prerequisites
+
+- AKS cluster with cluster role binding to deploy operator
+- Container Image Registry installed and configured for pull (using nexus)
+- Base image to build camel integration push to Image Registry (jdk-jre image present in nexus)
+
+
+Installation using Kamel CLI
+
+
+kamel install --registry <docker registry address> --registry-insecure true --organization <organization name> --registry-secret <docker registry secrets> --base-image <base image to build camel integration> -n <namespace>
Review comment:
I am not familiar with AKS, so, is there a previous step to retrieve the docker registry address and secret ?
AFAIK the base image is `adoptopenjdk/openjdk11:slim` and is defined in `pkg/util/defaults/defaults.go`, is it required to override it to run in AKS ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] ajbisht commented on pull request #3119: Create aks.cdoc
Posted by GitBox <gi...@apache.org>.
ajbisht commented on pull request #3119:
URL: https://github.com/apache/camel-k/pull/3119#issuecomment-1072397936
Waiting for PR#2845 to be merged
On Fri, Mar 18, 2022 at 10:20 AM Tadayoshi Sato ***@***.***>
wrote:
> I don't mind it if the author is inactive.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/camel-k/pull/3119#issuecomment-1072028827>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AFUOGFETPFYTBWYH2I3TI63VAQDTHANCNFSM5QXQSEJQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on pull request #3119: Create aks.cdoc
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #3119:
URL: https://github.com/apache/camel-k/pull/3119#issuecomment-1070836461
I think we should merge this and rework. Otherwise it will be lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] ajbisht commented on a change in pull request #3119: Create aks.cdoc
Posted by GitBox <gi...@apache.org>.
ajbisht commented on a change in pull request #3119:
URL: https://github.com/apache/camel-k/pull/3119#discussion_r837651877
##########
File path: docs/modules/ROOT/pages/installation/platform/aks.cdoc
##########
@@ -0,0 +1,34 @@
+Apache Camel K is a lightweight integration platform, born on Kubernetes,
+with serverless superpowers.
+
+# Camel K deployment in AKS
+
+## Prerequisites
+
+- AKS cluster with cluster role binding to deploy operator
+- Container Image Registry installed and configured for pull (using nexus)
+- Base image to build camel integration push to Image Registry (jdk-jre image present in nexus)
+
+
+Installation using Kamel CLI
+
+
+kamel install --registry <docker registry address> --registry-insecure true --organization chubbio --registry-auth-username <organization name> --registry-secret <docker registry secrets> --base-image <base image to buuld camel integration> -n <namespace>
Review comment:
Removed chubbio
typo fixed
all options are required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on pull request #3119: Create aks.cdoc
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #3119:
URL: https://github.com/apache/camel-k/pull/3119#issuecomment-1073770138
> > The PR #2845 is not aligned and it's not updated from a while, not sure it will be merged soon. @astefanutti can we switch to go 1.17?
>
> Generally, the Go version is driven by the version that is used by the Kubernetes dependencies we have. It could be possible to upgrade to 1.17, but if there is no special requirement, it's generally safer to follow Kubernetes.
>
> That being said, I fail to see the relationship between this PR and #2845.
The original issue was related to some CVE in reported in Azure while deploying camel-k, updating to go 1.17 seems to be the fix for them. So, I asked the reporter to write a guide on how to deploy on AKS, he opened this PR, and then commented here about waiting for the Go upgrading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #3119: Create aks.cdoc
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #3119:
URL: https://github.com/apache/camel-k/pull/3119#issuecomment-1073767423
> The PR #2845 is not aligned and it's not updated from a while, not sure it will be merged soon. @astefanutti can we switch to go 1.17?
Generally, the Go version is driven by the version that is used by the Kubernetes dependencies we have. It could be possible to upgrade to 1.17, but if there is no special requirement, it's generally safer to follow Kubernetes.
That being said, I fail to see the relationship between this PR and #2845.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on pull request #3119: Create aks.cdoc
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #3119:
URL: https://github.com/apache/camel-k/pull/3119#issuecomment-1072402217
The PR #2845 is not aligned and it's not updated from a while, not sure it will be merged soon. @astefanutti can we switch to go 1.17?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] ajbisht commented on pull request #3119: Create aks.cdoc
Posted by GitBox <gi...@apache.org>.
ajbisht commented on pull request #3119:
URL: https://github.com/apache/camel-k/pull/3119#issuecomment-1072397936
Waiting for PR#2845 to be merged
On Fri, Mar 18, 2022 at 10:20 AM Tadayoshi Sato ***@***.***>
wrote:
> I don't mind it if the author is inactive.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/camel-k/pull/3119#issuecomment-1072028827>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AFUOGFETPFYTBWYH2I3TI63VAQDTHANCNFSM5QXQSEJQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a change in pull request #3119: Create aks.cdoc
Posted by GitBox <gi...@apache.org>.
tadayosi commented on a change in pull request #3119:
URL: https://github.com/apache/camel-k/pull/3119#discussion_r827715643
##########
File path: docs/modules/ROOT/pages/installation/platform/aks.cdoc
##########
@@ -0,0 +1,34 @@
+Apache Camel K is a lightweight integration platform, born on Kubernetes,
Review comment:
No other install guides start from plain sentence. We should start from title.
##########
File path: docs/modules/ROOT/pages/installation/platform/aks.cdoc
##########
@@ -0,0 +1,34 @@
+Apache Camel K is a lightweight integration platform, born on Kubernetes,
+with serverless superpowers.
+
+# Camel K deployment in AKS
+
+## Prerequisites
+
+- AKS cluster with cluster role binding to deploy operator
+- Container Image Registry installed and configured for pull (using nexus)
+- Base image to build camel integration push to Image Registry (jdk-jre image present in nexus)
+
+
+Installation using Kamel CLI
Review comment:
Maybe you omitted the beginning `##`?
##########
File path: docs/modules/ROOT/pages/installation/platform/aks.cdoc
##########
@@ -0,0 +1,34 @@
+Apache Camel K is a lightweight integration platform, born on Kubernetes,
Review comment:
Looks good, but to begin with the file name should be `aks.adoc` not `.cdoc`.
##########
File path: docs/modules/ROOT/pages/installation/platform/aks.cdoc
##########
@@ -0,0 +1,34 @@
+Apache Camel K is a lightweight integration platform, born on Kubernetes,
+with serverless superpowers.
+
+# Camel K deployment in AKS
Review comment:
It should be more reader-friendly to tell what AKS stands for like other guides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #3119: Create aks.cdoc
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #3119:
URL: https://github.com/apache/camel-k/pull/3119#issuecomment-1073779030
> > > The PR #2845 is not aligned and it's not updated from a while, not sure it will be merged soon. @astefanutti can we switch to go 1.17?
> >
> >
> > Generally, the Go version is driven by the version that is used by the Kubernetes dependencies we have. It could be possible to upgrade to 1.17, but if there is no special requirement, it's generally safer to follow Kubernetes.
> > That being said, I fail to see the relationship between this PR and #2845.
>
> The original issue was related to some CVE in reported in Azure while deploying camel-k, updating to go 1.17 seems to be the fix for them. So, I asked the reporter to write a guide on how to deploy on AKS, he opened this PR, and then commented here about waiting for the Go upgrading.
I see, this relates to #3113. If there are no incompatibility, we can upgrade Go even if the Kubernetes version that's currently use still uses 1.16. I can see it could possibly solve CVE-2022-24407, but for CVE-2022-24407 it's difficult to correlate the fix to a Go upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on pull request #3119: Create aks.cdoc
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #3119:
URL: https://github.com/apache/camel-k/pull/3119#issuecomment-1070836461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi edited a comment on pull request #3119: Create aks.cdoc
Posted by GitBox <gi...@apache.org>.
tadayosi edited a comment on pull request #3119:
URL: https://github.com/apache/camel-k/pull/3119#issuecomment-1072028827
I'm fine with merging it if the author is inactive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] claudio4j commented on a change in pull request #3119: Create aks.cdoc
Posted by GitBox <gi...@apache.org>.
claudio4j commented on a change in pull request #3119:
URL: https://github.com/apache/camel-k/pull/3119#discussion_r837640309
##########
File path: docs/modules/ROOT/pages/installation/platform/aks.cdoc
##########
@@ -0,0 +1,34 @@
+Apache Camel K is a lightweight integration platform, born on Kubernetes,
+with serverless superpowers.
+
+# Camel K deployment in AKS
+
+## Prerequisites
+
+- AKS cluster with cluster role binding to deploy operator
+- Container Image Registry installed and configured for pull (using nexus)
+- Base image to build camel integration push to Image Registry (jdk-jre image present in nexus)
+
+
+Installation using Kamel CLI
+
+
+kamel install --registry <docker registry address> --registry-insecure true --organization chubbio --registry-auth-username <organization name> --registry-secret <docker registry secrets> --base-image <base image to buuld camel integration> -n <namespace>
Review comment:
Hardcoded `chubbio` ?
buuld typo.
Are all the `kamel` options required ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org