You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/22 22:54:55 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #17182: dataflowjobstatus sensor dag example fixed for issue #17180

mik-laj commented on a change in pull request #17182:
URL: https://github.com/apache/airflow/pull/17182#discussion_r675212656



##########
File path: airflow/providers/google/cloud/example_dags/example_dataflow.py
##########
@@ -166,7 +166,7 @@
     # [START howto_sensor_wait_for_job_status]
     wait_for_python_job_async_done = DataflowJobStatusSensor(
         task_id="wait-for-python-job-async-done",
-        job_id="{{task_instance.xcom_pull('start-python-job-async')['job_id']}}",
+        job_id="{{task_instance.xcom_pull('start-python-job-async')['id']}}",

Review comment:
       Are you sure? Please look at https://github.com/apache/airflow/blob/82de4a87b2a36e88e0b5803ed85e17d30719819a/airflow/providers/google/cloud/operators/dataflow.py#L1150
   Did I miss something?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org