You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/03/04 14:10:21 UTC
[kudu-CR] [python] Remove use of dict.iteritems()
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15359
Change subject: [python] Remove use of dict.iteritems()
......................................................................
[python] Remove use of dict.iteritems()
This patch removes the use of dict.iteritems() given it is removed
in Python 3.
Change-Id: I22d0d66cee0b9c940376e6c518504912fd431702
---
M build-support/dist_test.py
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/15359/1
--
To view, visit http://gerrit.cloudera.org:8080/15359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I22d0d66cee0b9c940376e6c518504912fd431702
Gerrit-Change-Number: 15359
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [python] Remove use of dict.iteritems()
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15359 )
Change subject: [python] Remove use of dict.iteritems()
......................................................................
Patch Set 1:
I will rebase to re-run the tests and investigate.
--
To view, visit http://gerrit.cloudera.org:8080/15359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22d0d66cee0b9c940376e6c518504912fd431702
Gerrit-Change-Number: 15359
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 22:48:43 +0000
Gerrit-HasComments: No
[kudu-CR] [python] Remove use of dict.iteritems()
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15359 )
Change subject: [python] Remove use of dict.iteritems()
......................................................................
Patch Set 2: Code-Review+2
Carrying forward the +2 given the rebase passed.
--
To view, visit http://gerrit.cloudera.org:8080/15359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22d0d66cee0b9c940376e6c518504912fd431702
Gerrit-Change-Number: 15359
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 05 Mar 2020 02:55:05 +0000
Gerrit-HasComments: No
[kudu-CR] [python] Remove use of dict.iteritems()
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15359 )
Change subject: [python] Remove use of dict.iteritems()
......................................................................
[python] Remove use of dict.iteritems()
This patch removes the use of dict.iteritems() given it is removed
in Python 3.
Change-Id: I22d0d66cee0b9c940376e6c518504912fd431702
Reviewed-on: http://gerrit.cloudera.org:8080/15359
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M build-support/dist_test.py
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I22d0d66cee0b9c940376e6c518504912fd431702
Gerrit-Change-Number: 15359
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [python] Remove use of dict.iteritems()
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15359 )
Change subject: [python] Remove use of dict.iteritems()
......................................................................
Patch Set 1: Code-Review+2
Also not sure what happened with Jenkins.
--
To view, visit http://gerrit.cloudera.org:8080/15359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22d0d66cee0b9c940376e6c518504912fd431702
Gerrit-Change-Number: 15359
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 22:42:04 +0000
Gerrit-HasComments: No
[kudu-CR] [python] Remove use of dict.iteritems()
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15359 )
Change subject: [python] Remove use of dict.iteritems()
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review+2
>
> Also not sure what happened with Jenkins.
Seems unrelated to the patch at least. Looks like it's failing at:
$DIST_TEST_HOME/bin/client watch $C_DIST_TEST_ID
--
To view, visit http://gerrit.cloudera.org:8080/15359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22d0d66cee0b9c940376e6c518504912fd431702
Gerrit-Change-Number: 15359
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 22:44:10 +0000
Gerrit-HasComments: No
[kudu-CR] [python] Remove use of dict.iteritems()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15359 )
Change subject: [python] Remove use of dict.iteritems()
......................................................................
Patch Set 1: Code-Review+2
Not sure quite what happened with Jenkins.
--
To view, visit http://gerrit.cloudera.org:8080/15359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22d0d66cee0b9c940376e6c518504912fd431702
Gerrit-Change-Number: 15359
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 17:04:47 +0000
Gerrit-HasComments: No