You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:03:14 UTC

[GitHub] [shardingsphere] RaigorJiang commented on pull request #10864: fixed #10863 Update tableNameOrAlias to equalsIgnoreCase

RaigorJiang commented on pull request #10864:
URL: https://github.com/apache/shardingsphere/pull/10864#issuecomment-863944378


   Hi @zoujianchao
   Thanks for you PR, but please notice:
   1. Ref to #10863, please do not forget `TablesContext` has the same problem.
   2. Please make your PR clean, do not hava too many files changed.
   3. Please add unit test to check your modification.
   
   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org