You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/11/13 11:06:06 UTC
[GitHub] [incubator-brpc] leaf-potato opened a new pull request, #1990: add gflag to disable sampler thread
leaf-potato opened a new pull request, #1990:
URL: https://github.com/apache/incubator-brpc/pull/1990
### What problem does this PR solve?
Issue Number: #1891
Problem Summary: there is currently no gflag to control the switch of the sampler thread
### What is changed and the side effects?
Changed: add `--bvar_enable_sampling` flag to control the switch of the sampler thread. if flag is false, does not create a global singleton SamplerCollector object.
Side effects:
- Performance effects(性能影响): setting the flag to false will reduce the creation of one thread and the usage of CPU and memory
- Breaking backward compatibility(向后兼容性): yes
---
### Check List:
- Please make sure your changes are compilable(请确保你的更改可以通过编译).
- When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
- Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on pull request #1990: add gflag to disable sampler thread
Posted by GitBox <gi...@apache.org>.
wwbmmm commented on PR #1990:
URL: https://github.com/apache/incubator-brpc/pull/1990#issuecomment-1312951615
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] serverglen merged pull request #1990: add gflag to disable sampler thread
Posted by GitBox <gi...@apache.org>.
serverglen merged PR #1990:
URL: https://github.com/apache/incubator-brpc/pull/1990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] serverglen commented on pull request #1990: add gflag to disable sampler thread
Posted by GitBox <gi...@apache.org>.
serverglen commented on PR #1990:
URL: https://github.com/apache/incubator-brpc/pull/1990#issuecomment-1313348900
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org