You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/23 18:23:59 UTC
[GitHub] [beam] nlu90 opened a new pull request, #22026: pulsar connector produces message asynchronously
nlu90 opened a new pull request, #22026:
URL: https://github.com/apache/beam/pull/22026
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on a diff in pull request #22026: pulsar connector produces message asynchronously
Posted by GitBox <gi...@apache.org>.
mosche commented on code in PR #22026:
URL: https://github.com/apache/beam/pull/22026#discussion_r907453720
##########
sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/WriteToPulsarDoFn.java:
##########
@@ -45,12 +54,48 @@ public void setup() throws PulsarClientException {
@ProcessElement
public void processElement(@Element byte[] messageToSend) throws Exception {
- producer.send(messageToSend);
+ producer.sendAsync(messageToSend)
Review Comment:
I agree with the concerns here, I've seen very troublesome async writers in Beam that were prone to loosing data. I suppose in this case it depends on the behavior of `producer.flush()` in `finishBundle()`. Does it block until all pending messages are send? If so, I'd suggest to add some comments to clarify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22026: pulsar connector produces message asynchronously
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22026:
URL: https://github.com/apache/beam/pull/22026#issuecomment-1164732661
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on a diff in pull request #22026: pulsar connector produces message asynchronously
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on code in PR #22026:
URL: https://github.com/apache/beam/pull/22026#discussion_r906365733
##########
sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/WriteToPulsarDoFn.java:
##########
@@ -45,12 +54,48 @@ public void setup() throws PulsarClientException {
@ProcessElement
public void processElement(@Element byte[] messageToSend) throws Exception {
- producer.send(messageToSend);
+ producer.sendAsync(messageToSend)
Review Comment:
Is there any concern of data loss here? Typically Beam is supposed to handle any threading or async itself. I'm thinking of the case where async is delayed, and Beam thinks a given element is completed, but it hasn't actually been sent to pulsar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22026: pulsar connector produces message asynchronously
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22026:
URL: https://github.com/apache/beam/pull/22026#issuecomment-1164732657
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22026: pulsar connector produces message asynchronously
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22026:
URL: https://github.com/apache/beam/pull/22026#issuecomment-1229186955
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22026: pulsar connector produces message asynchronously
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22026:
URL: https://github.com/apache/beam/pull/22026#issuecomment-1164732655
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pulsar connector produces message asynchronously [beam]
Posted by "hpvd (via GitHub)" <gi...@apache.org>.
hpvd commented on PR #22026:
URL: https://github.com/apache/beam/pull/22026#issuecomment-2074760823
added this to [Parent issue] Support for Apache Pulsar #31078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] closed pull request #22026: pulsar connector produces message asynchronously
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #22026: pulsar connector produces message asynchronously
URL: https://github.com/apache/beam/pull/22026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22026: pulsar connector produces message asynchronously
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22026:
URL: https://github.com/apache/beam/pull/22026#issuecomment-1164732664
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22026: pulsar connector produces message asynchronously
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22026:
URL: https://github.com/apache/beam/pull/22026#issuecomment-1164732658
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on pull request #22026: pulsar connector produces message asynchronously
Posted by GitBox <gi...@apache.org>.
mosche commented on PR #22026:
URL: https://github.com/apache/beam/pull/22026#issuecomment-1167428219
Wondering, is there a lack of test coverage if you could change the producer from sync to async without having to change tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22026: pulsar connector produces message asynchronously
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22026:
URL: https://github.com/apache/beam/pull/22026#issuecomment-1236975321
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org