You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2011/06/15 13:12:47 UTC
[jira] [Created] (LUCENE-3205) remove MultiTermQuery get/inc/clear
totalNumberOfTerms
remove MultiTermQuery get/inc/clear totalNumberOfTerms
------------------------------------------------------
Key: LUCENE-3205
URL: https://issues.apache.org/jira/browse/LUCENE-3205
Project: Lucene - Java
Issue Type: Bug
Reporter: Robert Muir
Attachments: LUCENE-3205.patch
This method is not correct if the index has more than one segment.
Its also not thread safe, and it means calling query.rewrite() modifies
the original query.
All of these things add up to confusion, I think we should remove this
from multitermquery, the only thing that "uses" it is the NRQ tests, which
conditionalizes all the asserts anyway.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3205) remove MultiTermQuery get/inc/clear
totalNumberOfTerms
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-3205:
--------------------------------
Attachment: LUCENE-3205.patch
> remove MultiTermQuery get/inc/clear totalNumberOfTerms
> ------------------------------------------------------
>
> Key: LUCENE-3205
> URL: https://issues.apache.org/jira/browse/LUCENE-3205
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-3205.patch
>
>
> This method is not correct if the index has more than one segment.
> Its also not thread safe, and it means calling query.rewrite() modifies
> the original query.
> All of these things add up to confusion, I think we should remove this
> from multitermquery, the only thing that "uses" it is the NRQ tests, which
> conditionalizes all the asserts anyway.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3205) remove MultiTermQuery get/inc/clear
totalNumberOfTerms
Posted by "Uwe Schindler (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler resolved LUCENE-3205.
-----------------------------------
Resolution: Fixed
Committed 3.x revision: 1201334
> remove MultiTermQuery get/inc/clear totalNumberOfTerms
> ------------------------------------------------------
>
> Key: LUCENE-3205
> URL: https://issues.apache.org/jira/browse/LUCENE-3205
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3205-3x.patch, LUCENE-3205.patch, LUCENE-3205.patch
>
>
> This method is not correct if the index has more than one segment.
> Its also not thread safe, and it means calling query.rewrite() modifies
> the original query.
> All of these things add up to confusion, I think we should remove this
> from multitermquery, the only thing that "uses" it is the NRQ tests, which
> conditionalizes all the asserts anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3205) remove MultiTermQuery
get/inc/clear totalNumberOfTerms
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149155#comment-13149155 ]
Uwe Schindler commented on LUCENE-3205:
---------------------------------------
Committed trunk revision: 1201329
> remove MultiTermQuery get/inc/clear totalNumberOfTerms
> ------------------------------------------------------
>
> Key: LUCENE-3205
> URL: https://issues.apache.org/jira/browse/LUCENE-3205
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3205.patch, LUCENE-3205.patch
>
>
> This method is not correct if the index has more than one segment.
> Its also not thread safe, and it means calling query.rewrite() modifies
> the original query.
> All of these things add up to confusion, I think we should remove this
> from multitermquery, the only thing that "uses" it is the NRQ tests, which
> conditionalizes all the asserts anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3205) remove MultiTermQuery
get/inc/clear totalNumberOfTerms
Posted by "Simon Willnauer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148872#comment-13148872 ]
Simon Willnauer commented on LUCENE-3205:
-----------------------------------------
uwe can you move this forward for a possible 3.5 release any time soon?
> remove MultiTermQuery get/inc/clear totalNumberOfTerms
> ------------------------------------------------------
>
> Key: LUCENE-3205
> URL: https://issues.apache.org/jira/browse/LUCENE-3205
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3205.patch
>
>
> This method is not correct if the index has more than one segment.
> Its also not thread safe, and it means calling query.rewrite() modifies
> the original query.
> All of these things add up to confusion, I think we should remove this
> from multitermquery, the only thing that "uses" it is the NRQ tests, which
> conditionalizes all the asserts anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3205) remove MultiTermQuery
get/inc/clear totalNumberOfTerms
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049733#comment-13049733 ]
Uwe Schindler commented on LUCENE-3205:
---------------------------------------
I am perfectly fine to remove it. For analysis and debugging NRQ, it would still be good to have something, but I suggest to change the tests (I will simply request TermsEnum and count terms, possibly on MultiTerms).
Should I take the issue and modify my tests?
> remove MultiTermQuery get/inc/clear totalNumberOfTerms
> ------------------------------------------------------
>
> Key: LUCENE-3205
> URL: https://issues.apache.org/jira/browse/LUCENE-3205
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3205.patch
>
>
> This method is not correct if the index has more than one segment.
> Its also not thread safe, and it means calling query.rewrite() modifies
> the original query.
> All of these things add up to confusion, I think we should remove this
> from multitermquery, the only thing that "uses" it is the NRQ tests, which
> conditionalizes all the asserts anyway.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (LUCENE-3205) remove MultiTermQuery get/inc/clear
totalNumberOfTerms
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler reassigned LUCENE-3205:
-------------------------------------
Assignee: Uwe Schindler
> remove MultiTermQuery get/inc/clear totalNumberOfTerms
> ------------------------------------------------------
>
> Key: LUCENE-3205
> URL: https://issues.apache.org/jira/browse/LUCENE-3205
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3205.patch
>
>
> This method is not correct if the index has more than one segment.
> Its also not thread safe, and it means calling query.rewrite() modifies
> the original query.
> All of these things add up to confusion, I think we should remove this
> from multitermquery, the only thing that "uses" it is the NRQ tests, which
> conditionalizes all the asserts anyway.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3205) remove MultiTermQuery get/inc/clear
totalNumberOfTerms
Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-3205:
----------------------------------
Attachment: LUCENE-3205-3x.patch
Patch for 3.x
> remove MultiTermQuery get/inc/clear totalNumberOfTerms
> ------------------------------------------------------
>
> Key: LUCENE-3205
> URL: https://issues.apache.org/jira/browse/LUCENE-3205
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3205-3x.patch, LUCENE-3205.patch, LUCENE-3205.patch
>
>
> This method is not correct if the index has more than one segment.
> Its also not thread safe, and it means calling query.rewrite() modifies
> the original query.
> All of these things add up to confusion, I think we should remove this
> from multitermquery, the only thing that "uses" it is the NRQ tests, which
> conditionalizes all the asserts anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3205) remove MultiTermQuery
get/inc/clear totalNumberOfTerms
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149123#comment-13149123 ]
Uwe Schindler commented on LUCENE-3205:
---------------------------------------
Working on a new test that counts the returned TermsEnum as replacement in TestNRQ.
> remove MultiTermQuery get/inc/clear totalNumberOfTerms
> ------------------------------------------------------
>
> Key: LUCENE-3205
> URL: https://issues.apache.org/jira/browse/LUCENE-3205
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3205.patch
>
>
> This method is not correct if the index has more than one segment.
> Its also not thread safe, and it means calling query.rewrite() modifies
> the original query.
> All of these things add up to confusion, I think we should remove this
> from multitermquery, the only thing that "uses" it is the NRQ tests, which
> conditionalizes all the asserts anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3205) remove MultiTermQuery get/inc/clear
totalNumberOfTerms
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-3205:
--------------------------------
Fix Version/s: 4.0
3.3
> remove MultiTermQuery get/inc/clear totalNumberOfTerms
> ------------------------------------------------------
>
> Key: LUCENE-3205
> URL: https://issues.apache.org/jira/browse/LUCENE-3205
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3205.patch
>
>
> This method is not correct if the index has more than one segment.
> Its also not thread safe, and it means calling query.rewrite() modifies
> the original query.
> All of these things add up to confusion, I think we should remove this
> from multitermquery, the only thing that "uses" it is the NRQ tests, which
> conditionalizes all the asserts anyway.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3205) remove MultiTermQuery
get/inc/clear totalNumberOfTerms
Posted by "Simon Willnauer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149132#comment-13149132 ]
Simon Willnauer commented on LUCENE-3205:
-----------------------------------------
bq. Working on a new test that counts the returned TermsEnum as replacement in TestNRQ.
thanks uwe!
> remove MultiTermQuery get/inc/clear totalNumberOfTerms
> ------------------------------------------------------
>
> Key: LUCENE-3205
> URL: https://issues.apache.org/jira/browse/LUCENE-3205
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3205.patch
>
>
> This method is not correct if the index has more than one segment.
> Its also not thread safe, and it means calling query.rewrite() modifies
> the original query.
> All of these things add up to confusion, I think we should remove this
> from multitermquery, the only thing that "uses" it is the NRQ tests, which
> conditionalizes all the asserts anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3205) remove MultiTermQuery get/inc/clear
totalNumberOfTerms
Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-3205:
----------------------------------
Attachment: LUCENE-3205.patch
Patch with improved tests and removed stats functions (for trunk).
I will commit this soon and merge backwards (but only deprecate in 3.x).
> remove MultiTermQuery get/inc/clear totalNumberOfTerms
> ------------------------------------------------------
>
> Key: LUCENE-3205
> URL: https://issues.apache.org/jira/browse/LUCENE-3205
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3205.patch, LUCENE-3205.patch
>
>
> This method is not correct if the index has more than one segment.
> Its also not thread safe, and it means calling query.rewrite() modifies
> the original query.
> All of these things add up to confusion, I think we should remove this
> from multitermquery, the only thing that "uses" it is the NRQ tests, which
> conditionalizes all the asserts anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3205) remove MultiTermQuery get/inc/clear
totalNumberOfTerms
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-3205:
---------------------------------------
Fix Version/s: (was: 3.4)
3.5
> remove MultiTermQuery get/inc/clear totalNumberOfTerms
> ------------------------------------------------------
>
> Key: LUCENE-3205
> URL: https://issues.apache.org/jira/browse/LUCENE-3205
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3205.patch
>
>
> This method is not correct if the index has more than one segment.
> Its also not thread safe, and it means calling query.rewrite() modifies
> the original query.
> All of these things add up to confusion, I think we should remove this
> from multitermquery, the only thing that "uses" it is the NRQ tests, which
> conditionalizes all the asserts anyway.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3205) remove MultiTermQuery
get/inc/clear totalNumberOfTerms
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049734#comment-13049734 ]
Robert Muir commented on LUCENE-3205:
-------------------------------------
yes, please do?
> remove MultiTermQuery get/inc/clear totalNumberOfTerms
> ------------------------------------------------------
>
> Key: LUCENE-3205
> URL: https://issues.apache.org/jira/browse/LUCENE-3205
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Robert Muir
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3205.patch
>
>
> This method is not correct if the index has more than one segment.
> Its also not thread safe, and it means calling query.rewrite() modifies
> the original query.
> All of these things add up to confusion, I think we should remove this
> from multitermquery, the only thing that "uses" it is the NRQ tests, which
> conditionalizes all the asserts anyway.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org