[jira] [Comment Edited] (CXF-7483) JAXRSServerFactoryBeanDefinitionParser doesn't log autowire failures

["Sergey Beryozkin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139780#comment-16139780 ] 

Sergey Beryozkin edited comment on CXF-7483 at 8/24/17 8:56 AM:
----------------------------------------------------------------

Hi, 
Well CXF 3.2.0 is about to be released in a couple of weeks and without appreciating the possible side-effects it seems risky to me to do it in a rush, given the only benefit we may get is the improved detectability of the faulty application contexts - I'm not sure it outweighs the risk.
The initial version of this code did not even have the auto-wire capability, it was added on the user request, so if we start re-throwing the auto-wire related exceptions and it is possible that some of these exceptions might be caused by something else but the faulty wiring then we'd lose the original code capability of simply creating a bean...
I'm not sure how founded in practical sense my concern is, but I'd rather avoid 3.2.0 users who have been waiting for it for nearly 2 years  seeing some exceptions coming from this code from the moment they downloaded 3.2.0 :-)

If you'd like - please create an improvement request for this code to actually throw the auto-wire exceptions, so that it can be tracked, and once a new master is opened, we can then have a look, thanks


was (Author: sergey_beryozkin):
Hi, 
Well CXF 3.2.0 is about to be released in a couple of weeks and without appreciating the possible side-effects it seems risky to me to do it in a rush, given the only benefit we may get is the improved detectability of the faulty application contexts - I'm not it outweighs the risk.
The initial version of this code did not even have the auto-wire capability, it was added on the user request, so if we start re-throwing the auto-wire related exceptions and it is possible that some of these exceptions might be caused by something else but the faulty wiring then we'd lose the original code capability of simply creating a bean...
I'm not sure how founded in practical sense my concern is, but I'd rather avoid 3.2.0 users who have been waiting for it for nearly 2 years  seeing some exceptions coming from this code from the moment they downloaded 3.2.0 :-)

If you'd like - please create an improvement request for this code to actually throw the auto-wire exceptions, so that it can be tracked, and once a new master is opened, we can then have a look, thanks

> JAXRSServerFactoryBeanDefinitionParser doesn't log autowire failures
> --------------------------------------------------------------------
>
>                 Key: CXF-7483
>                 URL: https://issues.apache.org/jira/browse/CXF-7483
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 3.1.7
>            Reporter: Matthew Buckett
>            Assignee: Sergey Beryozkin
>             Fix For: 3.0.15, 3.1.13, 3.2.0
>
>
> I was using the scanning through spring XML config:
> {code:xml}
> <beans
>           xmlns:jaxrs="http://cxf.apache.org/jaxrs">
> <!-- snipped -->
> <jaxrs:server address="/rest" basePackages="org.example.rest">
> </jaxrs:server>
> <!-- snipped -->
> </beans>
> {code}
> and my autowiring was failing and I was ending up with a un-autowired bean instead. Debugging this was tricky and it was because {{org.apache.cxf.jaxrs.spring.JAXRSServerFactoryBeanDefinitionParser#createBeansFromDiscoveredClasses}} doesn't log anything when autowiring fails, it would be helpful if it either threw the exception showing where the problem was or logged it and said it was creating an non-autowired bean.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)