You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/11 23:58:00 UTC
[GitHub] [superset] etr2460 commented on a change in pull request #12423: fix: incorrect cursor position Firefox
etr2460 commented on a change in pull request #12423:
URL: https://github.com/apache/superset/pull/12423#discussion_r555414975
##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -208,6 +208,10 @@ div.Workspace {
.ace_content {
height: 100%;
}
+
+ .ace_editor * {
+ font: inherit!important;
Review comment:
ugh, `!important` 🤮 I guess if this is the only way to fix it then it's ok
Although, do we need to apply this to all elements that are descendants of `.ace_editor` or can we be more specific here? Also, could you add a space between inherit and !important?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org