You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/15 04:31:55 UTC
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38642: [SPARK-41127][CONNECT][PYTHON] Implement DataFrame.CreateGlobalView in Python client
HyukjinKwon commented on code in PR #38642:
URL: https://github.com/apache/spark/pull/38642#discussion_r1022306530
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -633,6 +633,48 @@ def explain(self) -> str:
else:
return ""
+ def createGlobalTempView(self, name: str) -> None:
+ """Creates a global temporary view with this :class:`DataFrame`.
+
+ The lifetime of this temporary view is tied to this Spark application.
+
+ .. versionadded:: 3.4.0
+
+ Parameters
+ ----------
+ name : str
+ Name of the view.
+
+ Returns
+ -------
+ None
Review Comment:
```suggestion
Returns
-------
None
```
I guess we won't need this for `None`.
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -633,6 +633,48 @@ def explain(self) -> str:
else:
return ""
+ def createGlobalTempView(self, name: str) -> None:
+ """Creates a global temporary view with this :class:`DataFrame`.
+
+ The lifetime of this temporary view is tied to this Spark application.
+
+ .. versionadded:: 3.4.0
+
+ Parameters
+ ----------
+ name : str
+ Name of the view.
+
+ Returns
+ -------
+ None
Review Comment:
```suggestion
```
I guess we won't need this for `None`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org