You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "qianye1001 (via GitHub)" <gi...@apache.org> on 2026/05/11 02:22:23 UTC

[PR] [ISSUE #10302] Support SNI multi-domain certificate for Proxy TLS [rocketmq]

qianye1001 opened a new pull request, #10303:
URL: https://github.com/apache/rocketmq/pull/10303

   ### Which Issue(s) This PR Fixes
   
   - Fixes #10302
   
   ### Brief Description
   
   Introduce **SNI (Server Name Indication)** support to allow RocketMQ Proxy to serve multiple TLS domains with independent certificates on the same port.
   
   **Key changes:**
   
   | File | Change |
   |---|---|
   | `proxy/.../config/TlsDomainConfig.java` | **New** — per-domain TLS config POJO |
   | `proxy/.../config/ProxyConfig.java` | Add `tlsDomainConfigs` map field + getters/setters |
   | `proxy/.../service/cert/TlsSniManager.java` | **New** — multi-domain SslContext manager with wildcard matching |
   | `proxy/.../service/cert/TlsCertificateManager.java` | Extended for multi-domain file watching |
   | `proxy/.../grpc/ProxyAndTlsProtocolNegotiator.java` | Use `SniHandler` + `TlsSniManager` for gRPC SNI |
   | `proxy/.../grpc/GrpcServer.java` | Update reload handler to use renamed method |
   | `proxy/.../remoting/MultiProtocolRemotingServer.java` | Wire up `TlsContextProvider` with SNI lookup |
   | `proxy/.../ProxyStartup.java` | Initialize `TlsSniManager` before `TlsCertificateManager` |
   | `remoting/.../netty/TlsContextProvider.java` | **New** — SslContext holder bridge (remoting ↔ proxy) |
   | `remoting/.../netty/NettyRemotingServer.java` | `TlsModeHandler` uses `SniHandler` via `TlsContextProvider` |
   
   **Backward compatibility:** When `tlsDomainConfigs` is not configured, behavior is identical to the existing single-cert model.
   
   ### How Did You Test This Change?
   
   - Added unit tests in `TlsSniManagerTest` for wildcard matching, exact match, null/empty fallback, multi-level subdomain rejection, and domain context reload
   - Updated `TlsCertificateManagerTest` for the new multi-domain constructor
   
   CI will run `mvn -B package` to verify compilation and all existing tests pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #10302] Support SNI multi-domain certificate for Proxy TLS [rocketmq]

Posted by "qianye1001 (via GitHub)" <gi...@apache.org>.
qianye1001 closed pull request #10303: [ISSUE #10302] Support SNI multi-domain certificate for Proxy TLS
URL: https://github.com/apache/rocketmq/pull/10303


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #10302] Support SNI multi-domain certificate for Proxy TLS [rocketmq]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10303:
URL: https://github.com/apache/rocketmq/pull/10303#issuecomment-4418219690

   ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/10303?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `49.27114%` with `174 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.86%. Comparing base ([`c6fc39a`](https://app.codecov.io/gh/apache/rocketmq/commit/c6fc39ab5f1661cab5e2d6ff0c215c0add9c6d1d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b90b91f`](https://app.codecov.io/gh/apache/rocketmq/commit/b90b91f7cec232e7449f4af74c11ccf4d8de9f79?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/10303?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...etmq/proxy/service/cert/TlsCertificateManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fservice%2Fcert%2FTlsCertificateManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3NlcnZpY2UvY2VydC9UbHNDZXJ0aWZpY2F0ZU1hbmFnZXIuamF2YQ==) | 31.50% | [47 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...che/rocketmq/proxy/service/cert/TlsSniManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fservice%2Fcert%2FTlsSniManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3NlcnZpY2UvY2VydC9UbHNTbmlNYW5hZ2VyLmphdmE=) | 69.48% | [35 Missing and 12 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...etmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fgrpc%2FProxyAndTlsProtocolNegotiator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2dycGMvUHJveHlBbmRUbHNQcm90b2NvbE5lZ290aWF0b3IuamF2YQ==) | 30.55% | [23 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...mq/proxy/remoting/MultiProtocolRemotingServer.java](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fremoting%2FMultiProtocolRemotingServer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3JlbW90aW5nL011bHRpUHJvdG9jb2xSZW1vdGluZ1NlcnZlci5qYXZh) | 0.00% | [19 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...he/rocketmq/remoting/netty/TlsContextProvider.java](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&filepath=remoting%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fremoting%2Fnetty%2FTlsContextProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L1Rsc0NvbnRleHRQcm92aWRlci5qYXZh) | 40.00% | [11 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...e/rocketmq/remoting/netty/NettyRemotingServer.java](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&filepath=remoting%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fremoting%2Fnetty%2FNettyRemotingServer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdTZXJ2ZXIuamF2YQ==) | 35.29% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../apache/rocketmq/proxy/config/TlsDomainConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fconfig%2FTlsDomainConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2NvbmZpZy9UbHNEb21haW5Db25maWcuamF2YQ==) | 54.54% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...n/java/org/apache/rocketmq/proxy/ProxyStartup.java](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2FProxyStartup.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L1Byb3h5U3RhcnR1cC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ava/org/apache/rocketmq/proxy/grpc/GrpcServer.java](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fgrpc%2FGrpcServer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2dycGMvR3JwY1NlcnZlci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/10303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop   #10303      +/-   ##
   =============================================
   - Coverage      48.97%   48.86%   -0.12%     
   - Complexity     13467    13481      +14     
   =============================================
     Files           1375     1378       +3     
     Lines         100450   100731     +281     
     Branches       12973    13008      +35     
   =============================================
   + Hits           49198    49218      +20     
   - Misses         45257    45483     +226     
   - Partials        5995     6030      +35     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/10303?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org