[GitHub] [ozone] duongkame commented on pull request #3800: HDDS-7231. Integrate the GetKeyInfo API to key read flows

[GitBox <gi...@apache.org>]

duongkame commented on PR #3800:
URL: https://github.com/apache/ozone/pull/3800#issuecomment-1283097286

   > There is a call to looupKey here:
   > 
   > https://github.com/apache/ozone/blob/1ea4c2adc640a02508696bf346c7f1f7b6e0afd9/hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java#L1264
   > 
   > Should that be changed to getKeyInfo()?
   
   Yes, I cleaned that up as well.
   
   
   > There is a call to lookupFile() here:
   > 
   > https://github.com/apache/ozone/blob/1ea4c2adc640a02508696bf346c7f1f7b6e0afd9/hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java#L1683
   > 
   > 
   > But lookupFile() doesn't appear to use the cache. Should it?
   
   
   Thanks, `lookupFile` will be another path we will tackle for OFS. I think it's to contain the scope of this PR for key reads. 
   The file read path can probably be deprecated and merged to key read, but we'll see. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org