You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2011/05/02 08:17:59 UTC

Re: svn commit: r1088958 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

On Tue, Apr 5, 2011 at 06:25,  <rh...@apache.org> wrote:
> Author: rhuijben
> Date: Tue Apr  5 10:25:54 2011
> New Revision: 1088958
>
> URL: http://svn.apache.org/viewvc?rev=1088958&view=rev
> Log:
> Make svn_wc__db_op_copy() perform its work inside a sqlite lock; this should
> speed up the performance of 'svn cp' more then just a bit.

Why is the second lookup done within the lock? It seems that both
source and destination lookup should (or can) be done outside of the
lock.

I can see doing the second with_txn() from within the other. But it
seems that the lookup should be done "outside".

>...

Thoughts?

Cheers,
-g