[GitHub] Ben-Zvi commented on a change in pull request #1433: DRILL-6685: Fixed exception when reading Parquet data

[GitBox <gi...@apache.org>]

Ben-Zvi commented on a change in pull request #1433: DRILL-6685: Fixed exception when reading Parquet data
URL: https://github.com/apache/drill/pull/1433#discussion_r210422864
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenFixedEntryReader.java
 ##########
 @@ -43,7 +43,7 @@ final VarLenColumnBulkEntry getEntry(int valuesToRead) {
 
     final int expectedDataLen = columnPrecInfo.precision;
     final int entrySz = 4 + columnPrecInfo.precision;
-    final int readBatch = Math.min(entry.getMaxEntries(), valuesToRead);
+    final int readBatch = getFixedLengthMaxRecordsToRead(valuesToRead);
 
 Review comment:
   Would it be nicer to pass the *entrySz* as a parameter to *getFixedLengthMaxRecordsToRead()* , instead of recreating it ?
     E.g., in case it ever changes. Or maybe it'll look clearer.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services