You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/05 09:03:26 UTC

[GitHub] [airflow] potiuk edited a comment on pull request #11950: Add python 3.9 to supported versions

potiuk edited a comment on pull request #11950:
URL: https://github.com/apache/airflow/pull/11950#issuecomment-722240660


   > > Can you please rebased your PR on latest Master since we have applied Black and PyUpgrade on Master.
   > > It will help if your squash your commits into single commit first so that there are less conflicts.
   > 
   > Ok rebased. Last time I believe it failed on mermaid checks and I got lost going down the rabbit hole.
   > 
   > What is the easiest way to ensure that my pr passes all the static checks (black, flake8, mermaid, etc...) ?
   
   Just install pre-commit and run it with `--all-files`. See https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst
   
   * You can run individual pre-commits with 'pre-commit run <pre-commit> --all-files`
   * For all the individual changes pre-commit will automatically run at every commit only for subset of changes when you install it with `pre-commit install`
   * You can also use `breeze`. Breeze has the benefit of using auto-complete so that you do not have to look up the ids of pre-commits. You can run it as `./breeze static-checks <TAB>` and you see the ids of pre-commit. You can also add extra options for example `breeze static-checks mypy -- --all-files` will run checks for mypy for all files.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org