You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "erikthegamer1242 (via GitHub)" <gi...@apache.org> on 2025/05/18 11:25:50 UTC
[I] [Bug] Connected charts ignore `excludeComponents` when using `saveAsImage` when connected manually [echarts]
erikthegamer1242 opened a new issue, #20978:
URL: https://github.com/apache/echarts/issues/20978
### Version
5.6.0
### Link to Minimal Reproduction
https://jsfiddle.net/qkgnfcj8/
### Steps to Reproduce
1. Click on the button to save the graph image
2. Open the image and you will see the toolbox, but you shouldn't
### Current Behavior
Setting `excludeComponents: ['tooltip', 'toolbox']` gets ignored
### Expected Behavior
The excluded compoents should't be visible
### Environment
```markdown
- OS:Arch Linux
- Browser: Google Chrome Version 135.0.7049.84 (Official Build) (64-bit)
- Framework: React 19
```
### Any additional comments?
As far as I can see in the source code, the function `getDataURL()` in `src/core/echarts.ts` properly implemnts the excludeComponet functionallity, while `getConnectedDataURL()` in the same file is missing the `each` block that iterates over excludedComponents. I think that just adding it should fix the problem, but I couldn't get it to compile properly to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org