svn commit: r392446 - /lenya/trunk/src/java/org/apache/lenya/ac/file/FileAccreditableManager.java

[mi...@apache.org]

Author: michi
Date: Fri Apr  7 16:17:12 2006
New Revision: 392446

URL: http://svn.apache.org/viewcvs?rev=392446&view=rev
Log:
note seems to be obsolete, but another TODO added

Modified:
    lenya/trunk/src/java/org/apache/lenya/ac/file/FileAccreditableManager.java

Modified: lenya/trunk/src/java/org/apache/lenya/ac/file/FileAccreditableManager.java
URL: http://svn.apache.org/viewcvs/lenya/trunk/src/java/org/apache/lenya/ac/file/FileAccreditableManager.java?rev=392446&r1=392445&r2=392446&view=diff
==============================================================================
--- lenya/trunk/src/java/org/apache/lenya/ac/file/FileAccreditableManager.java (original)
+++ lenya/trunk/src/java/org/apache/lenya/ac/file/FileAccreditableManager.java Fri Apr  7 16:17:12 2006
@@ -156,13 +156,6 @@
      *      added to read new user-manager block within accreditable-manager
      */
     public void configure(Configuration configuration) throws ConfigurationException {
-        // note:
-        // we need to distinguish the case where configure is called from
-        // somewhere else (i.e. not due to the reading of ac.xconf),
-        // from the case where the child user-manager does not exist,
-        // for instance when reading an old ac.xconf which does not yet
-        // have this configuration. So for backward compatibility, we need
-        // to distinguish the 2 cases
         if (A_M_TAG.equals(configuration.getName())) {
             this.userTypes = new HashSet();
             Configuration umConf = configuration.getChild(U_M_CHILD_TAG, false);
@@ -180,8 +173,11 @@
                 // a default for backward compatibility
                 this.userTypes.add(getDefaultUserType());
             }
-            // maybe todo (or is it overkill?) : validate the parametrized user
+            // maybe TODO (or is it overkill?) : validate the parametrized user
             // types, for example, check if the classes are in the classpath ?
+        } else {
+            // TODO: In most cases it doesn't seem to find this element ...
+            //throw new ConfigurationException("No such element: " + A_M_TAG);
         }
     }
 
@@ -261,4 +257,4 @@
         return _manager;
     }
 
-}
\ No newline at end of file
+}



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@lenya.apache.org
For additional commands, e-mail: commits-help@lenya.apache.org