You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/11 11:10:03 UTC

[GitHub] [flink] dawidwys opened a new pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

dawidwys opened a new pull request #18726:
URL: https://github.com/apache/flink/pull/18726


   ## What is the purpose of the change
   
   The PR adds an API to enable and configure the watermark alignment for FLIP-27 sources.
   
   ## Brief change log
   * added a metric for tracking watermark drift from the aligned watermark
   * added API for enabling and configuring the watermark alignment
   This is based on #18709 and #18702 
   
   
   ## Verifying this change
   
   Added `org.apache.flink.connector.base.source.reader.AlignedWatermarksITCase`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented): needs to be documented separately, still to be decided if we want to make the documentation present in 1.15
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     }, {
       "hash" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31630",
       "triggerID" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9b9e4dc96990436cb5684646ed801b84f2357848 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619) 
   * 318d5650f14a51a9f1aee5fe5f97a14d5d54bef6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31630) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys commented on a change in pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #18726:
URL: https://github.com/apache/flink/pull/18726#discussion_r807008383



##########
File path: flink-architecture-tests/flink-architecture-tests-test/src/main/java/org/apache/flink/architecture/rules/ITCaseRules.java
##########
@@ -63,29 +66,41 @@
                             .should(
                                     fulfill(
                                             // JUnit 5 violation check
-                                            containAnyFieldsInClassHierarchyThat(
-                                                            arePublicStaticFinalOfType(
-                                                                    MiniClusterExtension.class))
-                                                    .and(
-                                                            containAnyFieldsInClassHierarchyThat(
-                                                                    arePublicStaticFinalOfTypeWithAnnotation(
-                                                                            AllCallbackWrapper
-                                                                                    .class,
-                                                                            RegisterExtension
-                                                                                    .class)))
+                                            miniClusterExtensionRule()
+                                                    .or(miniClusterWithClientExtensionRule())
                                                     // JUnit 4 violation check, which should be
                                                     // removed
                                                     // after the JUnit 4->5 migration is closed.
-                                                    .or(
-                                                            containAnyFieldsInClassHierarchyThat(
-                                                                    arePublicStaticFinalOfTypeWithAnnotation(
-                                                                            MiniClusterWithClientResource
-                                                                                    .class,
-                                                                            ClassRule.class)))
-                                                    .or(
-                                                            containAnyFieldsInClassHierarchyThat(
-                                                                    arePublicFinalOfTypeWithAnnotation(
-                                                                            MiniClusterWithClientResource
-                                                                                    .class,
-                                                                            Rule.class))))));
+                                                    .or(miniClusterWithClientResourceClassRule())
+                                                    .or(miniClusterWithClientResourceRule()))));
+
+    private static DescribedPredicate<JavaClass> miniClusterWithClientResourceClassRule() {
+        return containAnyFieldsInClassHierarchyThat(
+                arePublicStaticFinalOfTypeWithAnnotation(
+                        MiniClusterWithClientResource.class, ClassRule.class));
+    }
+
+    private static DescribedPredicate<JavaClass> miniClusterWithClientResourceRule() {
+        return containAnyFieldsInClassHierarchyThat(
+                arePublicFinalOfTypeWithAnnotation(
+                        MiniClusterWithClientResource.class, Rule.class));
+    }
+
+    private static DescribedPredicate<JavaClass> miniClusterExtensionRule() {
+        return containAnyFieldsInClassHierarchyThat(
+                        arePublicStaticFinalOfType(MiniClusterExtension.class))
+                .and(
+                        containAnyFieldsInClassHierarchyThat(
+                                arePublicStaticFinalOfTypeWithAnnotation(
+                                        AllCallbackWrapper.class, RegisterExtension.class)));
+    }
+
+    private static DescribedPredicate<JavaClass> miniClusterWithClientExtensionRule() {
+        return containAnyFieldsInClassHierarchyThat(
+                        arePublicStaticFinalOfType(MiniClusterWithClientExtension.class))
+                .and(
+                        containAnyFieldsInClassHierarchyThat(
+                                arePublicStaticFinalOfTypeWithAnnotation(
+                                        AllCallbackWrapper.class, RegisterExtension.class)));
+    }

Review comment:
       How important is that refactoring? It takes ages to regenerate the rule files.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9b9e4dc96990436cb5684646ed801b84f2357848 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     }, {
       "hash" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 206008ff75ce2c797f0355a1005f152f1ac7a5ce Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567) 
   * 9b9e4dc96990436cb5684646ed801b84f2357848 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619) 
   * 318d5650f14a51a9f1aee5fe5f97a14d5d54bef6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     }, {
       "hash" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31630",
       "triggerID" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 318d5650f14a51a9f1aee5fe5f97a14d5d54bef6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31630) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c155d2279ccc79a729d10e786158ce261ff08b3a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245) 
   * 567d592924c7a37d36e7fcbe20ce367d7e176a1b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253) 
   * 3e0350153d25b1ebac5254b968427a9b085787d6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     }, {
       "hash" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31630",
       "triggerID" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31640",
       "triggerID" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "255530e344dce93e506b9cfc1c3d2c15894c51b0",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31644",
       "triggerID" : "255530e344dce93e506b9cfc1c3d2c15894c51b0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "888162083fbb5f62f809e5270ad968db58cc9c5b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31660",
       "triggerID" : "888162083fbb5f62f809e5270ad968db58cc9c5b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 255530e344dce93e506b9cfc1c3d2c15894c51b0 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31644) 
   * 888162083fbb5f62f809e5270ad968db58cc9c5b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31660) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys merged pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #18726:
URL: https://github.com/apache/flink/pull/18726


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] pnowojski commented on a change in pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #18726:
URL: https://github.com/apache/flink/pull/18726#discussion_r804583848



##########
File path: docs/content/docs/ops/metrics.md
##########
@@ -1482,6 +1482,17 @@ Note that the metrics are only available via reporters.
       </td>
       <td>Gauge</td>
     </tr>
+    <tr>
+      <td>watermarkDrift</td>

Review comment:
       I guess you need to bump `rowspan="3"` above.

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/InternalSourceReaderMetricGroup.java
##########
@@ -131,6 +133,15 @@ public void watermarkEmitted(long watermark) {
         }
     }
 
+    public void updateMaxDesiredWatermark(long currentMaxDesiredWatermark) {
+        this.currentMaxDesiredWatermark = currentMaxDesiredWatermark;
+
+        if (firstDesiredWatermark) {
+            parentMetricGroup.gauge(MetricNames.WATERMARK_DRIFT, this::getAlignedWatermarkDrift);
+            firstDesiredWatermark = false;
+        }

Review comment:
       nit: I wonder if it's better for the tooling to have the metric defined always, instead of being registered lazily?

##########
File path: flink-core/src/main/java/org/apache/flink/api/common/eventtime/WatermarksWithWatermarkAlignment.java
##########
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.api.common.eventtime;
+
+import org.apache.flink.annotation.Internal;
+
+import java.time.Duration;
+
+/** A helper class to pass a watermark group and max allowed watermark drift to the runtime. */
+@Internal
+public final class WatermarksWithWatermarkAlignment<T> implements WatermarkStrategy<T> {
+
+    static final Duration DEFAULT_UPDATE_INTERVAL = Duration.ofMillis(1000);
+
+    private final WatermarkStrategy<T> strategy;
+
+    private final String watermarkGroup;
+
+    private final Duration maxAllowedWatermarkDrift;
+
+    private final Duration updateInterval;
+
+    public WatermarksWithWatermarkAlignment(
+            String watermarkGroup,
+            Duration maxAllowedWatermarkDrift,
+            Duration updateInterval,
+            WatermarkStrategy<T> strategy) {

Review comment:
       nit: for the sake of consistency move `strategy` as first parameter?

##########
File path: flink-core/src/main/java/org/apache/flink/api/common/eventtime/WatermarksWithWatermarkAlignment.java
##########
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.api.common.eventtime;
+
+import org.apache.flink.annotation.Internal;
+
+import java.time.Duration;
+
+/** A helper class to pass a watermark group and max allowed watermark drift to the runtime. */
+@Internal
+public final class WatermarksWithWatermarkAlignment<T> implements WatermarkStrategy<T> {
+
+    static final Duration DEFAULT_UPDATE_INTERVAL = Duration.ofMillis(1000);
+
+    private final WatermarkStrategy<T> strategy;
+
+    private final String watermarkGroup;
+
+    private final Duration maxAllowedWatermarkDrift;
+
+    private final Duration updateInterval;
+
+    public WatermarksWithWatermarkAlignment(
+            String watermarkGroup,
+            Duration maxAllowedWatermarkDrift,
+            Duration updateInterval,
+            WatermarkStrategy<T> strategy) {
+        this.strategy = strategy;
+        this.watermarkGroup = watermarkGroup;
+        this.maxAllowedWatermarkDrift = maxAllowedWatermarkDrift;
+        this.updateInterval = updateInterval;
+    }
+
+    public String getWatermarkGroup() {
+        return watermarkGroup;
+    }
+
+    public Duration getMaxAllowedWatermarkDrift() {
+        return maxAllowedWatermarkDrift;
+    }
+
+    public Duration getUpdateInterval() {
+        return updateInterval;
+    }
+
+    @Override
+    public WatermarkGenerator<T> createWatermarkGenerator(
+            WatermarkGeneratorSupplier.Context context) {
+        return strategy.createWatermarkGenerator(context);
+    }
+
+    @Override
+    public TimestampAssigner<T> createTimestampAssigner(TimestampAssignerSupplier.Context context) {
+        return strategy.createTimestampAssigner(context);
+    }
+
+    @Override
+    public WatermarkStrategy<T> withTimestampAssigner(
+            TimestampAssignerSupplier<T> timestampAssigner) {
+        return new WatermarksWithWatermarkAlignment<T>(
+                watermarkGroup,
+                maxAllowedWatermarkDrift,
+                updateInterval,
+                strategy.withTimestampAssigner(timestampAssigner));
+    }

Review comment:
       I'm not sure if such approach would scale well. I guess it would be working now, but:
   1. if someone adds new method to the `WatermarkStrategy` interface with a default implementation, this will brake
   2. if someone adds another strategy, that is implemented the same way as `WatermarksWithWatermarkAlignment` they will also not work together.
   
   Instead, can not we keep the same pattern as before, so this class would only implement `createTimestampAssigner`, `createWatermarkGenerator` and a new method `getAlignmentParams()`? While replacing `watermarkStrategy instanceof WatermarksWithWatermarkAlignment` check with a `watermarkStrategy.getAlignmentParams()` call:
   ```
   final class WatermarkStrategyWithAlignment<T> implements WatermarkStrategy<T> {
   
       private static final long serialVersionUID = 1L;
   
       private final WatermarkStrategy<T> baseStrategy;
       private final String watermarkGroup;
       private final Duration maxAllowedWatermarkDrift;
       private final Duration updateInterval;
   
       public WatermarkStrategyWithAlignment(
               String watermarkGroup,
               Duration maxAllowedWatermarkDrift,
               Duration updateInterval,
               WatermarkStrategy<T> strategy) {
           this.baseStrategy = strategy;
           this.watermarkGroup = watermarkGroup;
           this.maxAllowedWatermarkDrift = maxAllowedWatermarkDrift;
           this.updateInterval = updateInterval;
       }
   
       @Override
       public WatermarkAlignmentParams getAlignmentParams() {
           // default, return WatermarkAlignmentParams#DISABLED;
           return new WatermarkAlignmentParams(watermarkGroup, maxAllowedWatermarkDrift, updateInterval);
       }
   
       @Override
       public TimestampAssigner<T> createTimestampAssigner(TimestampAssignerSupplier.Context context) {
           return baseStrategy.createTimestampAssigner(context);
       }
   
       @Override
       public WatermarkGenerator<T> createWatermarkGenerator(
               WatermarkGeneratorSupplier.Context context) {
           ...
       }
   }
   ```
   ?

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/InternalSourceReaderMetricGroup.java
##########
@@ -157,4 +168,8 @@ long getEmitTimeLag() {
     long getWatermarkLag() {
         return getLastEmitTime() - lastWatermark;
     }
+
+    long getAlignedWatermarkDrift() {
+        return Math.max(0, lastWatermark - currentMaxDesiredWatermark);

Review comment:
       don't the negative values have also meaningful sense?

##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -453,6 +438,18 @@ private DataInputStatus emitNextNotReading(DataOutput<OUT> output) throws Except
         }
     }
 
+    private void initializeWatermarkAlignment(DataOutput<OUT> output) {
+        if (watermarkStrategy instanceof WatermarksWithWatermarkAlignment) {
+            watermarkTrackingOutput = new WatermarkTrackingOutput<>(output);
+            final long updateInterval =
+                    ((WatermarksWithWatermarkAlignment<OUT>) watermarkStrategy)
+                            .getUpdateInterval()
+                            .toMillis();
+            processingTimeService.scheduleWithFixedDelay(
+                    this::emitLatestWatermark, updateInterval, updateInterval);
+        }
+    }

Review comment:
       ? I believe this is not being used?

##########
File path: docs/content/docs/ops/metrics.md
##########
@@ -1482,6 +1482,17 @@ Note that the metrics are only available via reporters.
       </td>
       <td>Gauge</td>
     </tr>
+    <tr>
+      <td>watermarkDrift</td>
+      <td>
+        The current drift from the minimal watermark emitted by all sources/tasks/splits that belong
+        to the same watermark group.
+
+        Note: Available only when watermark alignment is enabled and the first common watermark is
+        announced. You can configure the update interval in the WatermarkStrategy.
+      </td>
+      <td>Gauge</td>
+    </tr>

Review comment:
       Please update also the Chinese version

##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -167,6 +164,9 @@
     private InternalSourceReaderMetricGroup sourceMetricGroup;
 
     @Nullable private WatermarkTrackingOutput<OUT> watermarkTrackingOutput;
+    private final boolean alignmentEnabled;
+    private final long alignmentUpdateInterval;

Review comment:
       nit: for the sake of consistence with `SourceCoordinator` and completeness, I would keep the `WatermarkAlignementParams` here. You could re-use strategy -> params conversion code in both places.

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricNames.java
##########
@@ -95,4 +95,7 @@ public static String currentInputWatermarkName(int index) {
     public static final String PENDING_RECORDS = "pendingRecords";
     public static final String PENDING_BYTES = "pendingBytes";
     public static final String SOURCE_IDLE_TIME = "sourceIdleTime";
+
+    // FLIP-182 (watermark alignment)
+    public static final String WATERMARK_DRIFT = "watermarkDrift";

Review comment:
       `watermarkAlignmentDrift`? 

##########
File path: flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/AlignedWatermarksITCase.java
##########
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.source.reader;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.JobSubmissionResult;
+import org.apache.flink.api.common.eventtime.Watermark;
+import org.apache.flink.api.common.eventtime.WatermarkGenerator;
+import org.apache.flink.api.common.eventtime.WatermarkOutput;
+import org.apache.flink.api.common.eventtime.WatermarkStrategy;
+import org.apache.flink.api.common.functions.RichMapFunction;
+import org.apache.flink.api.connector.source.lib.NumberSequenceSource;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.core.testutils.AllCallbackWrapper;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Metric;
+import org.apache.flink.runtime.jobgraph.JobGraph;
+import org.apache.flink.runtime.metrics.MetricNames;
+import org.apache.flink.runtime.minicluster.MiniCluster;
+import org.apache.flink.runtime.testutils.CommonTestUtils;
+import org.apache.flink.runtime.testutils.InMemoryReporter;
+import org.apache.flink.runtime.testutils.MiniClusterResourceConfiguration;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.api.functions.sink.DiscardingSink;
+import org.apache.flink.test.util.MiniClusterWithClientExtension;
+import org.apache.flink.testutils.logging.LoggerAuditingExtension;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+import org.slf4j.event.Level;
+
+import java.time.Duration;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+/**
+ * An IT test to verify watermark alignment works. The idea is that we check the {@link
+ * MetricNames#WATERMARK_DRIFT} metric does not grow beyond the maximal configured drift. It can
+ * initially increase beyond that value, because of the update interval, but once established it
+ * should never increase any further, but gradually decrease to the configured threshold, as the
+ * slower source catches up.
+ */
+public class AlignedWatermarksITCase {
+    public static final String SLOW_SOURCE_NAME = "SlowNumberSequenceSource";
+    public static final String FAST_SOURCE_NAME = "FastNumberSequenceSource";
+    public static final int MAX_DRIFT = 100;
+
+    @RegisterExtension
+    LoggerAuditingExtension loggerAuditingExtension =
+            new LoggerAuditingExtension(AlignedWatermarksITCase.class, Level.INFO);
+
+    private static final InMemoryReporter reporter = InMemoryReporter.createWithRetainedMetrics();
+
+    public static final MiniClusterWithClientExtension MINI_CLUSTER_RESOURCE =
+            new MiniClusterWithClientExtension(
+                    new MiniClusterResourceConfiguration.Builder()
+                            .setNumberTaskManagers(1)
+                            .setConfiguration(reporter.addToConfiguration(new Configuration()))
+                            .build());
+
+    @RegisterExtension
+    static AllCallbackWrapper<MiniClusterWithClientExtension> allWrapper =
+            new AllCallbackWrapper<>(MINI_CLUSTER_RESOURCE);
+
+    @Test
+    public void testAlignment() throws Exception {
+        final JobGraph jobGraph = getJobGraph();
+        final MiniCluster miniCluster = MINI_CLUSTER_RESOURCE.getMiniCluster();
+        final CompletableFuture<JobSubmissionResult> submission = miniCluster.submitJob(jobGraph);
+        final JobID jobID = submission.get().getJobID();
+        CommonTestUtils.waitForAllTaskRunning(miniCluster, jobID, false);
+
+        long oldDrift = Long.MAX_VALUE;
+        do {
+            final Optional<Metric> drift =
+                    reporter.findMetric(
+                            jobID, FAST_SOURCE_NAME + ".*" + MetricNames.WATERMARK_DRIFT);
+            Thread.sleep(200);
+
+            final Optional<Long> newDriftOptional = drift.map(m -> ((Gauge<Long>) m).getValue());
+            if (newDriftOptional.isPresent()) {
+                final Long newDrift = newDriftOptional.get();
+                assertThat(newDrift).isLessThanOrEqualTo(oldDrift);
+                oldDrift = newDrift;
+            }
+        } while (oldDrift >= MAX_DRIFT);
+    }
+
+    private JobGraph getJobGraph() {
+        StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
+        env.getConfig().setAutoWatermarkInterval(0L);
+        env.setParallelism(1);
+
+        DataStream<Long> slowSource =
+                env.fromSource(
+                                new NumberSequenceSource(0, Long.MAX_VALUE),
+                                WatermarkStrategy.forGenerator(ctx -> new PunctuatedGenerator())
+                                        .withWatermarkAlignment(
+                                                "group-1", Duration.ofMillis(MAX_DRIFT))

Review comment:
       as we discussed offline. I would suggest to change:
   
   1. `Thread.sleep(5)` -> `Thread.sleep(10)`
   2. `Thread.sleep(2)` -> `Thread.sleep(1)`
   3. update interval from 1s to 100ms
   
   On the paper test should be actually more thorough and faster to execute.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 97fed06af5d718dd3ce775ffe31b62c78bf54267 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527) 
   * 206008ff75ce2c797f0355a1005f152f1ac7a5ce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3e0350153d25b1ebac5254b968427a9b085787d6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267) 
   * 06102b172e575b0d2d927e32577fc04d6f9f00bf UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] JingGe commented on a change in pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #18726:
URL: https://github.com/apache/flink/pull/18726#discussion_r807004649



##########
File path: flink-architecture-tests/flink-architecture-tests-test/src/main/java/org/apache/flink/architecture/rules/ITCaseRules.java
##########
@@ -63,29 +66,41 @@
                             .should(
                                     fulfill(
                                             // JUnit 5 violation check
-                                            containAnyFieldsInClassHierarchyThat(
-                                                            arePublicStaticFinalOfType(
-                                                                    MiniClusterExtension.class))
-                                                    .and(
-                                                            containAnyFieldsInClassHierarchyThat(
-                                                                    arePublicStaticFinalOfTypeWithAnnotation(
-                                                                            AllCallbackWrapper
-                                                                                    .class,
-                                                                            RegisterExtension
-                                                                                    .class)))
+                                            miniClusterExtensionRule()
+                                                    .or(miniClusterWithClientExtensionRule())
                                                     // JUnit 4 violation check, which should be
                                                     // removed
                                                     // after the JUnit 4->5 migration is closed.
-                                                    .or(
-                                                            containAnyFieldsInClassHierarchyThat(
-                                                                    arePublicStaticFinalOfTypeWithAnnotation(
-                                                                            MiniClusterWithClientResource
-                                                                                    .class,
-                                                                            ClassRule.class)))
-                                                    .or(
-                                                            containAnyFieldsInClassHierarchyThat(
-                                                                    arePublicFinalOfTypeWithAnnotation(
-                                                                            MiniClusterWithClientResource
-                                                                                    .class,
-                                                                            Rule.class))))));
+                                                    .or(miniClusterWithClientResourceClassRule())
+                                                    .or(miniClusterWithClientResourceRule()))));
+
+    private static DescribedPredicate<JavaClass> miniClusterWithClientResourceClassRule() {
+        return containAnyFieldsInClassHierarchyThat(
+                arePublicStaticFinalOfTypeWithAnnotation(
+                        MiniClusterWithClientResource.class, ClassRule.class));
+    }
+
+    private static DescribedPredicate<JavaClass> miniClusterWithClientResourceRule() {
+        return containAnyFieldsInClassHierarchyThat(
+                arePublicFinalOfTypeWithAnnotation(
+                        MiniClusterWithClientResource.class, Rule.class));
+    }
+
+    private static DescribedPredicate<JavaClass> miniClusterExtensionRule() {
+        return containAnyFieldsInClassHierarchyThat(
+                        arePublicStaticFinalOfType(MiniClusterExtension.class))
+                .and(
+                        containAnyFieldsInClassHierarchyThat(
+                                arePublicStaticFinalOfTypeWithAnnotation(
+                                        AllCallbackWrapper.class, RegisterExtension.class)));
+    }
+
+    private static DescribedPredicate<JavaClass> miniClusterWithClientExtensionRule() {
+        return containAnyFieldsInClassHierarchyThat(
+                        arePublicStaticFinalOfType(MiniClusterWithClientExtension.class))
+                .and(
+                        containAnyFieldsInClassHierarchyThat(
+                                arePublicStaticFinalOfTypeWithAnnotation(
+                                        AllCallbackWrapper.class, RegisterExtension.class)));
+    }

Review comment:
       how about with one method by using:
   `containAnyFieldsInClassHierarchyThat(
                                                               arePublicStaticFinalOfType(
                                                                       MiniClusterExtension.class)).or(containAnyFieldsInClassHierarchyThat(
                                                               arePublicStaticFinalOfType(
                                                                       MiniClusterWithClientExtension.class))).and(
                           containAnyFieldsInClassHierarchyThat(
                                   arePublicStaticFinalOfTypeWithAnnotation(
                                           AllCallbackWrapper.class, RegisterExtension.class)))`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] JingGe commented on a change in pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #18726:
URL: https://github.com/apache/flink/pull/18726#discussion_r807004649



##########
File path: flink-architecture-tests/flink-architecture-tests-test/src/main/java/org/apache/flink/architecture/rules/ITCaseRules.java
##########
@@ -63,29 +66,41 @@
                             .should(
                                     fulfill(
                                             // JUnit 5 violation check
-                                            containAnyFieldsInClassHierarchyThat(
-                                                            arePublicStaticFinalOfType(
-                                                                    MiniClusterExtension.class))
-                                                    .and(
-                                                            containAnyFieldsInClassHierarchyThat(
-                                                                    arePublicStaticFinalOfTypeWithAnnotation(
-                                                                            AllCallbackWrapper
-                                                                                    .class,
-                                                                            RegisterExtension
-                                                                                    .class)))
+                                            miniClusterExtensionRule()
+                                                    .or(miniClusterWithClientExtensionRule())
                                                     // JUnit 4 violation check, which should be
                                                     // removed
                                                     // after the JUnit 4->5 migration is closed.
-                                                    .or(
-                                                            containAnyFieldsInClassHierarchyThat(
-                                                                    arePublicStaticFinalOfTypeWithAnnotation(
-                                                                            MiniClusterWithClientResource
-                                                                                    .class,
-                                                                            ClassRule.class)))
-                                                    .or(
-                                                            containAnyFieldsInClassHierarchyThat(
-                                                                    arePublicFinalOfTypeWithAnnotation(
-                                                                            MiniClusterWithClientResource
-                                                                                    .class,
-                                                                            Rule.class))))));
+                                                    .or(miniClusterWithClientResourceClassRule())
+                                                    .or(miniClusterWithClientResourceRule()))));
+
+    private static DescribedPredicate<JavaClass> miniClusterWithClientResourceClassRule() {
+        return containAnyFieldsInClassHierarchyThat(
+                arePublicStaticFinalOfTypeWithAnnotation(
+                        MiniClusterWithClientResource.class, ClassRule.class));
+    }
+
+    private static DescribedPredicate<JavaClass> miniClusterWithClientResourceRule() {
+        return containAnyFieldsInClassHierarchyThat(
+                arePublicFinalOfTypeWithAnnotation(
+                        MiniClusterWithClientResource.class, Rule.class));
+    }
+
+    private static DescribedPredicate<JavaClass> miniClusterExtensionRule() {
+        return containAnyFieldsInClassHierarchyThat(
+                        arePublicStaticFinalOfType(MiniClusterExtension.class))
+                .and(
+                        containAnyFieldsInClassHierarchyThat(
+                                arePublicStaticFinalOfTypeWithAnnotation(
+                                        AllCallbackWrapper.class, RegisterExtension.class)));
+    }
+
+    private static DescribedPredicate<JavaClass> miniClusterWithClientExtensionRule() {
+        return containAnyFieldsInClassHierarchyThat(
+                        arePublicStaticFinalOfType(MiniClusterWithClientExtension.class))
+                .and(
+                        containAnyFieldsInClassHierarchyThat(
+                                arePublicStaticFinalOfTypeWithAnnotation(
+                                        AllCallbackWrapper.class, RegisterExtension.class)));
+    }

Review comment:
       how about with one method by using:
   `containAnyFieldsInClassHierarchyThat(
                                                               arePublicStaticFinalOfType(
                                                                       MiniClusterExtension.class)).or(containAnyFieldsInClassHierarchyThat(
                                                               arePublicStaticFinalOfType(
                                                                       MiniClusterWithClientExtension.class))).and(
                           containAnyFieldsInClassHierarchyThat(
                                   arePublicStaticFinalOfTypeWithAnnotation(
                                           AllCallbackWrapper.class, RegisterExtension.class)))`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     }, {
       "hash" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9b9e4dc96990436cb5684646ed801b84f2357848 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619) 
   * 318d5650f14a51a9f1aee5fe5f97a14d5d54bef6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     }, {
       "hash" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31630",
       "triggerID" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 318d5650f14a51a9f1aee5fe5f97a14d5d54bef6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31630) 
   * 0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c155d2279ccc79a729d10e786158ce261ff08b3a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245) 
   * 567d592924c7a37d36e7fcbe20ce367d7e176a1b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 567d592924c7a37d36e7fcbe20ce367d7e176a1b Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253) 
   * 3e0350153d25b1ebac5254b968427a9b085787d6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c155d2279ccc79a729d10e786158ce261ff08b3a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys commented on a change in pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #18726:
URL: https://github.com/apache/flink/pull/18726#discussion_r804669091



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -453,6 +438,18 @@ private DataInputStatus emitNextNotReading(DataOutput<OUT> output) throws Except
         }
     }
 
+    private void initializeWatermarkAlignment(DataOutput<OUT> output) {
+        if (watermarkStrategy instanceof WatermarksWithWatermarkAlignment) {
+            watermarkTrackingOutput = new WatermarkTrackingOutput<>(output);
+            final long updateInterval =
+                    ((WatermarksWithWatermarkAlignment<OUT>) watermarkStrategy)
+                            .getUpdateInterval()
+                            .toMillis();
+            processingTimeService.scheduleWithFixedDelay(
+                    this::emitLatestWatermark, updateInterval, updateInterval);
+        }
+    }

Review comment:
       Yes, a mistake while rebasing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c155d2279ccc79a729d10e786158ce261ff08b3a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245) 
   * 567d592924c7a37d36e7fcbe20ce367d7e176a1b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1f263298a0be3d4e0b77a9329ff4e48258215919 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435) 
   * 8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 86e61b2bda393d0076a60352544b312a1cef5e49 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404) 
   * 1f7995bb04af2044711279164cee83a2fc8ce4a8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423) 
   * 1f263298a0be3d4e0b77a9329ff4e48258215919 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9b9e4dc96990436cb5684646ed801b84f2357848 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 206008ff75ce2c797f0355a1005f152f1ac7a5ce Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567) 
   * 9b9e4dc96990436cb5684646ed801b84f2357848 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     }, {
       "hash" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9b9e4dc96990436cb5684646ed801b84f2357848 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619) 
   * 318d5650f14a51a9f1aee5fe5f97a14d5d54bef6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys commented on a change in pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #18726:
URL: https://github.com/apache/flink/pull/18726#discussion_r804679753



##########
File path: flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/AlignedWatermarksITCase.java
##########
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.source.reader;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.JobSubmissionResult;
+import org.apache.flink.api.common.eventtime.Watermark;
+import org.apache.flink.api.common.eventtime.WatermarkGenerator;
+import org.apache.flink.api.common.eventtime.WatermarkOutput;
+import org.apache.flink.api.common.eventtime.WatermarkStrategy;
+import org.apache.flink.api.common.functions.RichMapFunction;
+import org.apache.flink.api.connector.source.lib.NumberSequenceSource;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.core.testutils.AllCallbackWrapper;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Metric;
+import org.apache.flink.runtime.jobgraph.JobGraph;
+import org.apache.flink.runtime.metrics.MetricNames;
+import org.apache.flink.runtime.minicluster.MiniCluster;
+import org.apache.flink.runtime.testutils.CommonTestUtils;
+import org.apache.flink.runtime.testutils.InMemoryReporter;
+import org.apache.flink.runtime.testutils.MiniClusterResourceConfiguration;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.api.functions.sink.DiscardingSink;
+import org.apache.flink.test.util.MiniClusterWithClientExtension;
+import org.apache.flink.testutils.logging.LoggerAuditingExtension;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+import org.slf4j.event.Level;
+
+import java.time.Duration;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+/**
+ * An IT test to verify watermark alignment works. The idea is that we check the {@link
+ * MetricNames#WATERMARK_DRIFT} metric does not grow beyond the maximal configured drift. It can
+ * initially increase beyond that value, because of the update interval, but once established it
+ * should never increase any further, but gradually decrease to the configured threshold, as the
+ * slower source catches up.
+ */
+public class AlignedWatermarksITCase {
+    public static final String SLOW_SOURCE_NAME = "SlowNumberSequenceSource";
+    public static final String FAST_SOURCE_NAME = "FastNumberSequenceSource";
+    public static final int MAX_DRIFT = 100;
+
+    @RegisterExtension
+    LoggerAuditingExtension loggerAuditingExtension =
+            new LoggerAuditingExtension(AlignedWatermarksITCase.class, Level.INFO);
+
+    private static final InMemoryReporter reporter = InMemoryReporter.createWithRetainedMetrics();
+
+    public static final MiniClusterWithClientExtension MINI_CLUSTER_RESOURCE =
+            new MiniClusterWithClientExtension(
+                    new MiniClusterResourceConfiguration.Builder()
+                            .setNumberTaskManagers(1)
+                            .setConfiguration(reporter.addToConfiguration(new Configuration()))
+                            .build());
+
+    @RegisterExtension
+    static AllCallbackWrapper<MiniClusterWithClientExtension> allWrapper =
+            new AllCallbackWrapper<>(MINI_CLUSTER_RESOURCE);
+
+    @Test
+    public void testAlignment() throws Exception {
+        final JobGraph jobGraph = getJobGraph();
+        final MiniCluster miniCluster = MINI_CLUSTER_RESOURCE.getMiniCluster();
+        final CompletableFuture<JobSubmissionResult> submission = miniCluster.submitJob(jobGraph);
+        final JobID jobID = submission.get().getJobID();
+        CommonTestUtils.waitForAllTaskRunning(miniCluster, jobID, false);
+
+        long oldDrift = Long.MAX_VALUE;
+        do {
+            final Optional<Metric> drift =
+                    reporter.findMetric(
+                            jobID, FAST_SOURCE_NAME + ".*" + MetricNames.WATERMARK_DRIFT);
+            Thread.sleep(200);
+
+            final Optional<Long> newDriftOptional = drift.map(m -> ((Gauge<Long>) m).getValue());
+            if (newDriftOptional.isPresent()) {
+                final Long newDrift = newDriftOptional.get();
+                assertThat(newDrift).isLessThanOrEqualTo(oldDrift);
+                oldDrift = newDrift;
+            }
+        } while (oldDrift >= MAX_DRIFT);
+    }
+
+    private JobGraph getJobGraph() {
+        StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
+        env.getConfig().setAutoWatermarkInterval(0L);
+        env.setParallelism(1);
+
+        DataStream<Long> slowSource =
+                env.fromSource(
+                                new NumberSequenceSource(0, Long.MAX_VALUE),
+                                WatermarkStrategy.forGenerator(ctx -> new PunctuatedGenerator())
+                                        .withWatermarkAlignment(
+                                                "group-1", Duration.ofMillis(MAX_DRIFT))

Review comment:
       I adjusted the parameters (just to note, had to adjust the MAX_DRIFT as well).
   
   On my machine it takes ~3s to run (without the setup), compared to ~7s before. Still it takes a couple of rounds of updates to catch up.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     }, {
       "hash" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31630",
       "triggerID" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31640",
       "triggerID" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31640) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     }, {
       "hash" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31630",
       "triggerID" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31640",
       "triggerID" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 318d5650f14a51a9f1aee5fe5f97a14d5d54bef6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31630) 
   * 0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31640) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c155d2279ccc79a729d10e786158ce261ff08b3a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c155d2279ccc79a729d10e786158ce261ff08b3a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245) 
   * 567d592924c7a37d36e7fcbe20ce367d7e176a1b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3e0350153d25b1ebac5254b968427a9b085787d6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267) 
   * 06102b172e575b0d2d927e32577fc04d6f9f00bf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1f7995bb04af2044711279164cee83a2fc8ce4a8 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423) 
   * 1f263298a0be3d4e0b77a9329ff4e48258215919 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1f263298a0be3d4e0b77a9329ff4e48258215919 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys commented on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1039457340






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 06102b172e575b0d2d927e32577fc04d6f9f00bf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380) 
   * 86e61b2bda393d0076a60352544b312a1cef5e49 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 06102b172e575b0d2d927e32577fc04d6f9f00bf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380) 
   * 86e61b2bda393d0076a60352544b312a1cef5e49 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404) 
   * 1f7995bb04af2044711279164cee83a2fc8ce4a8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500) 
   * 97fed06af5d718dd3ce775ffe31b62c78bf54267 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9b9e4dc96990436cb5684646ed801b84f2357848 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     }, {
       "hash" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31630",
       "triggerID" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9b9e4dc96990436cb5684646ed801b84f2357848 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619) 
   * 318d5650f14a51a9f1aee5fe5f97a14d5d54bef6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31630) 
   * 0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c155d2279ccc79a729d10e786158ce261ff08b3a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245) 
   * 567d592924c7a37d36e7fcbe20ce367d7e176a1b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c155d2279ccc79a729d10e786158ce261ff08b3a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500) 
   * 97fed06af5d718dd3ce775ffe31b62c78bf54267 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527) 
   * 206008ff75ce2c797f0355a1005f152f1ac7a5ce UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c155d2279ccc79a729d10e786158ce261ff08b3a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245) 
   * 567d592924c7a37d36e7fcbe20ce367d7e176a1b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] pnowojski commented on a change in pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #18726:
URL: https://github.com/apache/flink/pull/18726#discussion_r804609039



##########
File path: docs/content/docs/ops/metrics.md
##########
@@ -1482,6 +1482,17 @@ Note that the metrics are only available via reporters.
       </td>
       <td>Gauge</td>
     </tr>
+    <tr>
+      <td>watermarkDrift</td>
+      <td>
+        The current drift from the minimal watermark emitted by all sources/tasks/splits that belong
+        to the same watermark group.
+
+        Note: Available only when watermark alignment is enabled and the first common watermark is
+        announced. You can configure the update interval in the WatermarkStrategy.
+      </td>
+      <td>Gauge</td>
+    </tr>

Review comment:
       Please copy paste this to the Chinese version




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     }, {
       "hash" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9b9e4dc96990436cb5684646ed801b84f2357848 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619) 
   * 318d5650f14a51a9f1aee5fe5f97a14d5d54bef6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c155d2279ccc79a729d10e786158ce261ff08b3a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys commented on a change in pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #18726:
URL: https://github.com/apache/flink/pull/18726#discussion_r804679753



##########
File path: flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/AlignedWatermarksITCase.java
##########
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.base.source.reader;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.JobSubmissionResult;
+import org.apache.flink.api.common.eventtime.Watermark;
+import org.apache.flink.api.common.eventtime.WatermarkGenerator;
+import org.apache.flink.api.common.eventtime.WatermarkOutput;
+import org.apache.flink.api.common.eventtime.WatermarkStrategy;
+import org.apache.flink.api.common.functions.RichMapFunction;
+import org.apache.flink.api.connector.source.lib.NumberSequenceSource;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.core.testutils.AllCallbackWrapper;
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Metric;
+import org.apache.flink.runtime.jobgraph.JobGraph;
+import org.apache.flink.runtime.metrics.MetricNames;
+import org.apache.flink.runtime.minicluster.MiniCluster;
+import org.apache.flink.runtime.testutils.CommonTestUtils;
+import org.apache.flink.runtime.testutils.InMemoryReporter;
+import org.apache.flink.runtime.testutils.MiniClusterResourceConfiguration;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.api.functions.sink.DiscardingSink;
+import org.apache.flink.test.util.MiniClusterWithClientExtension;
+import org.apache.flink.testutils.logging.LoggerAuditingExtension;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+import org.slf4j.event.Level;
+
+import java.time.Duration;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+/**
+ * An IT test to verify watermark alignment works. The idea is that we check the {@link
+ * MetricNames#WATERMARK_DRIFT} metric does not grow beyond the maximal configured drift. It can
+ * initially increase beyond that value, because of the update interval, but once established it
+ * should never increase any further, but gradually decrease to the configured threshold, as the
+ * slower source catches up.
+ */
+public class AlignedWatermarksITCase {
+    public static final String SLOW_SOURCE_NAME = "SlowNumberSequenceSource";
+    public static final String FAST_SOURCE_NAME = "FastNumberSequenceSource";
+    public static final int MAX_DRIFT = 100;
+
+    @RegisterExtension
+    LoggerAuditingExtension loggerAuditingExtension =
+            new LoggerAuditingExtension(AlignedWatermarksITCase.class, Level.INFO);
+
+    private static final InMemoryReporter reporter = InMemoryReporter.createWithRetainedMetrics();
+
+    public static final MiniClusterWithClientExtension MINI_CLUSTER_RESOURCE =
+            new MiniClusterWithClientExtension(
+                    new MiniClusterResourceConfiguration.Builder()
+                            .setNumberTaskManagers(1)
+                            .setConfiguration(reporter.addToConfiguration(new Configuration()))
+                            .build());
+
+    @RegisterExtension
+    static AllCallbackWrapper<MiniClusterWithClientExtension> allWrapper =
+            new AllCallbackWrapper<>(MINI_CLUSTER_RESOURCE);
+
+    @Test
+    public void testAlignment() throws Exception {
+        final JobGraph jobGraph = getJobGraph();
+        final MiniCluster miniCluster = MINI_CLUSTER_RESOURCE.getMiniCluster();
+        final CompletableFuture<JobSubmissionResult> submission = miniCluster.submitJob(jobGraph);
+        final JobID jobID = submission.get().getJobID();
+        CommonTestUtils.waitForAllTaskRunning(miniCluster, jobID, false);
+
+        long oldDrift = Long.MAX_VALUE;
+        do {
+            final Optional<Metric> drift =
+                    reporter.findMetric(
+                            jobID, FAST_SOURCE_NAME + ".*" + MetricNames.WATERMARK_DRIFT);
+            Thread.sleep(200);
+
+            final Optional<Long> newDriftOptional = drift.map(m -> ((Gauge<Long>) m).getValue());
+            if (newDriftOptional.isPresent()) {
+                final Long newDrift = newDriftOptional.get();
+                assertThat(newDrift).isLessThanOrEqualTo(oldDrift);
+                oldDrift = newDrift;
+            }
+        } while (oldDrift >= MAX_DRIFT);
+    }
+
+    private JobGraph getJobGraph() {
+        StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
+        env.getConfig().setAutoWatermarkInterval(0L);
+        env.setParallelism(1);
+
+        DataStream<Long> slowSource =
+                env.fromSource(
+                                new NumberSequenceSource(0, Long.MAX_VALUE),
+                                WatermarkStrategy.forGenerator(ctx -> new PunctuatedGenerator())
+                                        .withWatermarkAlignment(
+                                                "group-1", Duration.ofMillis(MAX_DRIFT))

Review comment:
       I adjusted the parameters (just to note, had to adjust the MAX_DRIFT as well).
   
   On my machine it takes ~3s to run (without the setup), compared to ~7s before.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c155d2279ccc79a729d10e786158ce261ff08b3a Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245) 
   * 567d592924c7a37d36e7fcbe20ce367d7e176a1b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253) 
   * 3e0350153d25b1ebac5254b968427a9b085787d6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 06102b172e575b0d2d927e32577fc04d6f9f00bf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380) 
   * 86e61b2bda393d0076a60352544b312a1cef5e49 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] pnowojski commented on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036204939


   Good idea for the test! 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys commented on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1039457340


   @JingGe Can you help me with the ArchUnit? How can I fix the `ITCASE_USE_MINICLUSTER`? It is missing a rule for `MiniClusterWithClientExtension` and if I add it, tests fail with 
   ```
   Feb 14 17:48:43 [ERROR] Errors: 
   Feb 14 17:48:43 [ERROR]   Updating frozen violations is disabled (enable by configuration freeze.store.default.allowStoreUpdate=true)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     }, {
       "hash" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31630",
       "triggerID" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31640",
       "triggerID" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "255530e344dce93e506b9cfc1c3d2c15894c51b0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "255530e344dce93e506b9cfc1c3d2c15894c51b0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31640) 
   * 255530e344dce93e506b9cfc1c3d2c15894c51b0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     }, {
       "hash" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9b9e4dc96990436cb5684646ed801b84f2357848 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619) 
   * 318d5650f14a51a9f1aee5fe5f97a14d5d54bef6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     }, {
       "hash" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31630",
       "triggerID" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31640",
       "triggerID" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "255530e344dce93e506b9cfc1c3d2c15894c51b0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31644",
       "triggerID" : "255530e344dce93e506b9cfc1c3d2c15894c51b0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31640) 
   * 255530e344dce93e506b9cfc1c3d2c15894c51b0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31644) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     }, {
       "hash" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31630",
       "triggerID" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31640",
       "triggerID" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "255530e344dce93e506b9cfc1c3d2c15894c51b0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31644",
       "triggerID" : "255530e344dce93e506b9cfc1c3d2c15894c51b0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "888162083fbb5f62f809e5270ad968db58cc9c5b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "888162083fbb5f62f809e5270ad968db58cc9c5b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31640) 
   * 255530e344dce93e506b9cfc1c3d2c15894c51b0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31644) 
   * 888162083fbb5f62f809e5270ad968db58cc9c5b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c155d2279ccc79a729d10e786158ce261ff08b3a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245) 
   * 567d592924c7a37d36e7fcbe20ce367d7e176a1b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c155d2279ccc79a729d10e786158ce261ff08b3a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 06102b172e575b0d2d927e32577fc04d6f9f00bf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 06102b172e575b0d2d927e32577fc04d6f9f00bf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380) 
   * 86e61b2bda393d0076a60352544b312a1cef5e49 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404) 
   * 1f7995bb04af2044711279164cee83a2fc8ce4a8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423) 
   * 1f263298a0be3d4e0b77a9329ff4e48258215919 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 06102b172e575b0d2d927e32577fc04d6f9f00bf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380) 
   * 86e61b2bda393d0076a60352544b312a1cef5e49 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404) 
   * 1f7995bb04af2044711279164cee83a2fc8ce4a8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1f263298a0be3d4e0b77a9329ff4e48258215919 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435) 
   * 8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500) 
   * 97fed06af5d718dd3ce775ffe31b62c78bf54267 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1f263298a0be3d4e0b77a9329ff4e48258215919 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435) 
   * 8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys commented on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1040285690


   @JingGe @Airblader May you take a look at [282dae5](https://github.com/apache/flink/pull/18726/commits/282dae5d491e53b842098c763924b863ce20dd0b) if it makes sense for you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3e0350153d25b1ebac5254b968427a9b085787d6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036098149


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c155d2279ccc79a729d10e786158ce261ff08b3a (Fri Feb 11 11:14:51 UTC 2022)
   
   **Warnings:**
    * Documentation files were touched, but no `docs/content.zh/` files: Update Chinese documentation or file Jira ticket.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c155d2279ccc79a729d10e786158ce261ff08b3a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 06102b172e575b0d2d927e32577fc04d6f9f00bf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380) 
   * 86e61b2bda393d0076a60352544b312a1cef5e49 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404) 
   * 1f7995bb04af2044711279164cee83a2fc8ce4a8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423) 
   * 1f263298a0be3d4e0b77a9329ff4e48258215919 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c155d2279ccc79a729d10e786158ce261ff08b3a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245) 
   * 567d592924c7a37d36e7fcbe20ce367d7e176a1b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253) 
   * 3e0350153d25b1ebac5254b968427a9b085787d6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] dawidwys commented on a change in pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #18726:
URL: https://github.com/apache/flink/pull/18726#discussion_r807008383



##########
File path: flink-architecture-tests/flink-architecture-tests-test/src/main/java/org/apache/flink/architecture/rules/ITCaseRules.java
##########
@@ -63,29 +66,41 @@
                             .should(
                                     fulfill(
                                             // JUnit 5 violation check
-                                            containAnyFieldsInClassHierarchyThat(
-                                                            arePublicStaticFinalOfType(
-                                                                    MiniClusterExtension.class))
-                                                    .and(
-                                                            containAnyFieldsInClassHierarchyThat(
-                                                                    arePublicStaticFinalOfTypeWithAnnotation(
-                                                                            AllCallbackWrapper
-                                                                                    .class,
-                                                                            RegisterExtension
-                                                                                    .class)))
+                                            miniClusterExtensionRule()
+                                                    .or(miniClusterWithClientExtensionRule())
                                                     // JUnit 4 violation check, which should be
                                                     // removed
                                                     // after the JUnit 4->5 migration is closed.
-                                                    .or(
-                                                            containAnyFieldsInClassHierarchyThat(
-                                                                    arePublicStaticFinalOfTypeWithAnnotation(
-                                                                            MiniClusterWithClientResource
-                                                                                    .class,
-                                                                            ClassRule.class)))
-                                                    .or(
-                                                            containAnyFieldsInClassHierarchyThat(
-                                                                    arePublicFinalOfTypeWithAnnotation(
-                                                                            MiniClusterWithClientResource
-                                                                                    .class,
-                                                                            Rule.class))))));
+                                                    .or(miniClusterWithClientResourceClassRule())
+                                                    .or(miniClusterWithClientResourceRule()))));
+
+    private static DescribedPredicate<JavaClass> miniClusterWithClientResourceClassRule() {
+        return containAnyFieldsInClassHierarchyThat(
+                arePublicStaticFinalOfTypeWithAnnotation(
+                        MiniClusterWithClientResource.class, ClassRule.class));
+    }
+
+    private static DescribedPredicate<JavaClass> miniClusterWithClientResourceRule() {
+        return containAnyFieldsInClassHierarchyThat(
+                arePublicFinalOfTypeWithAnnotation(
+                        MiniClusterWithClientResource.class, Rule.class));
+    }
+
+    private static DescribedPredicate<JavaClass> miniClusterExtensionRule() {
+        return containAnyFieldsInClassHierarchyThat(
+                        arePublicStaticFinalOfType(MiniClusterExtension.class))
+                .and(
+                        containAnyFieldsInClassHierarchyThat(
+                                arePublicStaticFinalOfTypeWithAnnotation(
+                                        AllCallbackWrapper.class, RegisterExtension.class)));
+    }
+
+    private static DescribedPredicate<JavaClass> miniClusterWithClientExtensionRule() {
+        return containAnyFieldsInClassHierarchyThat(
+                        arePublicStaticFinalOfType(MiniClusterWithClientExtension.class))
+                .and(
+                        containAnyFieldsInClassHierarchyThat(
+                                arePublicStaticFinalOfTypeWithAnnotation(
+                                        AllCallbackWrapper.class, RegisterExtension.class)));
+    }

Review comment:
       How important is that refactoring? It takes ages to regenerate the rule files.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1f263298a0be3d4e0b77a9329ff4e48258215919 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435) 
   * 8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500) 
   * 97fed06af5d718dd3ce775ffe31b62c78bf54267 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 206008ff75ce2c797f0355a1005f152f1ac7a5ce Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9b9e4dc96990436cb5684646ed801b84f2357848 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18726: [FLINK-25983] Add API for configuring maximal watermark drift

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18726:
URL: https://github.com/apache/flink/pull/18726#issuecomment-1036101042


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31245",
       "triggerID" : "c155d2279ccc79a729d10e786158ce261ff08b3a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31253",
       "triggerID" : "567d592924c7a37d36e7fcbe20ce367d7e176a1b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31267",
       "triggerID" : "3e0350153d25b1ebac5254b968427a9b085787d6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31380",
       "triggerID" : "06102b172e575b0d2d927e32577fc04d6f9f00bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31404",
       "triggerID" : "86e61b2bda393d0076a60352544b312a1cef5e49",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31423",
       "triggerID" : "1f7995bb04af2044711279164cee83a2fc8ce4a8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31435",
       "triggerID" : "1f263298a0be3d4e0b77a9329ff4e48258215919",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31500",
       "triggerID" : "8bbfe5bcd1f2bd5041b145b66e28f16c53fa59b9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31527",
       "triggerID" : "97fed06af5d718dd3ce775ffe31b62c78bf54267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31567",
       "triggerID" : "206008ff75ce2c797f0355a1005f152f1ac7a5ce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31619",
       "triggerID" : "9b9e4dc96990436cb5684646ed801b84f2357848",
       "triggerType" : "PUSH"
     }, {
       "hash" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31630",
       "triggerID" : "318d5650f14a51a9f1aee5fe5f97a14d5d54bef6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31640",
       "triggerID" : "0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "255530e344dce93e506b9cfc1c3d2c15894c51b0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "255530e344dce93e506b9cfc1c3d2c15894c51b0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 318d5650f14a51a9f1aee5fe5f97a14d5d54bef6 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31630) 
   * 0ee9c6a291b7d2a9bf83707eee0f8d8f06f05afb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31640) 
   * 255530e344dce93e506b9cfc1c3d2c15894c51b0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org