[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6358: AWS: Print logs whether Glue optimistic locking is used or not

[GitBox <gi...@apache.org>]

amogh-jahagirdar commented on code in PR #6358:
URL: https://github.com/apache/iceberg/pull/6358#discussion_r1081579915


##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -151,7 +151,12 @@ private LockManager initializeLockManager(Map<String, String> properties) {
     if (properties.containsKey(CatalogProperties.LOCK_IMPL)) {
       return LockManagers.from(properties);
     } else if (SET_VERSION_ID.isNoop()) {
+      LOG.warn(
+          "Optimistic locking is not available in the environment. Using in-memory lock manager."
+              + " To ensure atomic transaction, you need to setup a DynamoDB lock manager.");

Review Comment:
   Nit: generally in log messages I think we try to avoid the second person. 
   
   "To ensure atomic transaction, please configure a distributed lock manager such as the DynamoDB lock manager"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org