You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "Paul King (Jira)" <ji...@apache.org> on 2020/09/01 13:54:00 UTC
[jira] [Commented] (GROOVY-9711) @Sortable annotation always sorts
by the parent properties
[ https://issues.apache.org/jira/browse/GROOVY-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17188474#comment-17188474 ]
Paul King commented on GROOVY-9711:
-----------------------------------
Strange, the following two lines print different results:
{code}
println unsortedList[0] <=> unsortedList[1] // => -1
println unsortedList[0].compareTo(unsortedList[1]) // => 1
{code}
Method resolution is picking the {{compareTo}} method from the parent when calling {{comparable.compareTo(right)}} in {{DefaultTypeTransformation#compareToWithEqualityCheck}}.
> @Sortable annotation always sorts by the parent properties
> ----------------------------------------------------------
>
> Key: GROOVY-9711
> URL: https://issues.apache.org/jira/browse/GROOVY-9711
> Project: Groovy
> Issue Type: Bug
> Components: groovy-runtime
> Affects Versions: 3.0.5
> Environment: Windows 10 version 1809
> AdoptOpenJDK version 8.0.242.08
> Groovy 3.0.5
> Reporter: Ted Lundqvist
> Priority: Major
>
> Adding includeSuperProperties = false doesn't help either.
> If the @Sortable annotation is removed from the super-class the test passes.
> Example:
> {code:groovy}
> import groovy.transform.Sortable
> import org.junit.Test
> class SortableTest {
> @Sortable(includes = ["num"])
> class SortableClass{
> Integer num
> }
> @Sortable(includeSuperProperties = false, includes = ["str"])
> class SortableChild extends SortableClass {
> String str
> }
> @Test
> void test(){
> List<SortableChild> unsortedList = [new SortableChild([str: "B", num: 1]), new SortableChild([str: "A", num: 2])]
> List<SortableChild> sortedList = unsortedList.toSorted()
> assert sortedList[0].str == "A" //Fails here
> }
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)