You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@attic.apache.org by sebb <se...@gmail.com> on 2025/05/05 10:12:44 UTC
Improve this page not working on html (generated) pages
The link is useful on pages with direct sources, but does not work for
generated pages.
It might be better to drop those links if they can't be fixed?
Sebb
Re: Improve this page not working on html (generated) pages
Posted by Niall Pemberton <ni...@gmail.com>.
On Mon, 5 May 2025 at 22:49, sebb <se...@gmail.com> wrote:
> On Mon, 5 May 2025 at 14:40, Niall Pemberton <ni...@gmail.com>
> wrote:
> >
> > OK, made some more changes:
> > - added a "Improve" the data" button to project pages
> > - added button on Sidebar (which is better - footer or sidebar?)
>
> The Sidebar is more obvious, but that is mainly because the text is
> larger and is highlighted.
>
> Can the Sidebar button be moved? It currently appears between the
> Events link and the current event, which seems wrong.
>
I can move it down - but I'm rubbish at webpages & layouts - i just copied
some of the JFD html to create a list in "nav_footer_custom.html" - but it
doesn't seem to quite look right.
https://github.com/apache/attic/blob/main/_includes/nav_footer_custom.html#L25
> I wonder if a diagonal flag at the top of the page (a la fork me on
> GH) might be better?
>
That sounds good but its beyond me - I did try to put it in
"_includes/header-custom.html" - but it looked rubbish and messed up the
search bar:
https://just-the-docs.com/docs/customization/#custom-header
So I'll leave that to someone else to try
Niall
>
> > Niall
> >
> > On Mon, 5 May 2025 at 13:44, Niall Pemberton <ni...@gmail.com>
> > wrote:
> >
> > > On Mon, 5 May 2025 at 11:13, sebb <se...@gmail.com> wrote:
> > >
> > >> The link is useful on pages with direct sources, but does not work for
> > >> generated pages.
> > >> It might be better to drop those links if they can't be fixed?
> > >>
> > >
> > > OK, I've removed the default one provided by JustForDocs and added a
> > > custom one in custom_footer.html that points to the YAML files for the
> > > generated projects pages.
> > >
> > > Niall
> > >
> > >
> > >>
> > >> Sebb
> > >>
> > >
>
Re: Improve this page not working on html (generated) pages
Posted by sebb <se...@gmail.com>.
On Mon, 5 May 2025 at 14:40, Niall Pemberton <ni...@gmail.com> wrote:
>
> OK, made some more changes:
> - added a "Improve" the data" button to project pages
> - added button on Sidebar (which is better - footer or sidebar?)
The Sidebar is more obvious, but that is mainly because the text is
larger and is highlighted.
Can the Sidebar button be moved? It currently appears between the
Events link and the current event, which seems wrong.
I wonder if a diagonal flag at the top of the page (a la fork me on
GH) might be better?
> Niall
>
> On Mon, 5 May 2025 at 13:44, Niall Pemberton <ni...@gmail.com>
> wrote:
>
> > On Mon, 5 May 2025 at 11:13, sebb <se...@gmail.com> wrote:
> >
> >> The link is useful on pages with direct sources, but does not work for
> >> generated pages.
> >> It might be better to drop those links if they can't be fixed?
> >>
> >
> > OK, I've removed the default one provided by JustForDocs and added a
> > custom one in custom_footer.html that points to the YAML files for the
> > generated projects pages.
> >
> > Niall
> >
> >
> >>
> >> Sebb
> >>
> >
Re: Improve this page not working on html (generated) pages
Posted by Niall Pemberton <ni...@gmail.com>.
OK, made some more changes:
- added a "Improve" the data" button to project pages
- added button on Sidebar (which is better - footer or sidebar?)
Niall
On Mon, 5 May 2025 at 13:44, Niall Pemberton <ni...@gmail.com>
wrote:
> On Mon, 5 May 2025 at 11:13, sebb <se...@gmail.com> wrote:
>
>> The link is useful on pages with direct sources, but does not work for
>> generated pages.
>> It might be better to drop those links if they can't be fixed?
>>
>
> OK, I've removed the default one provided by JustForDocs and added a
> custom one in custom_footer.html that points to the YAML files for the
> generated projects pages.
>
> Niall
>
>
>>
>> Sebb
>>
>
Re: Improve this page not working on html (generated) pages
Posted by Niall Pemberton <ni...@gmail.com>.
On Mon, 5 May 2025 at 11:13, sebb <se...@gmail.com> wrote:
> The link is useful on pages with direct sources, but does not work for
> generated pages.
> It might be better to drop those links if they can't be fixed?
>
OK, I've removed the default one provided by JustForDocs and added a custom
one in custom_footer.html that points to the YAML files for the generated
projects pages.
Niall
>
> Sebb
>