You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/06/28 00:41:06 UTC
Review Request 23142: Refactored the scheduler/executor driver to remove
calling 'stop'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23142/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-1550
https://issues.apache.org/jira/browse/MESOS-1550
Repository: mesos-git
Description
-------
See bug.
Diffs
-----
src/exec/exec.cpp 346e39f7fc7974c2f455e2f14508e0b39df737d7
src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 32e9a2828874d2dd6fd71aa43888e48505e1287e
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp d0b71524829fada3cd8a56f1857e7cec6e27bb44
src/python/native/mesos_executor_driver_impl.cpp aa564ed5c09673de8ce80d8d9fe7bdfe1ffe369a
src/python/native/mesos_scheduler_driver_impl.cpp 1c825327084d5d862006847762ad3c80831c5a21
Diff: https://reviews.apache.org/r/23142/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 23142: Refactored the scheduler/executor driver to remove
calling 'stop'.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23142/#review46915
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 27, 2014, 10:41 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23142/
> -----------------------------------------------------------
>
> (Updated June 27, 2014, 10:41 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1550
> https://issues.apache.org/jira/browse/MESOS-1550
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See bug.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp 346e39f7fc7974c2f455e2f14508e0b39df737d7
> src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 32e9a2828874d2dd6fd71aa43888e48505e1287e
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp d0b71524829fada3cd8a56f1857e7cec6e27bb44
> src/python/native/mesos_executor_driver_impl.cpp aa564ed5c09673de8ce80d8d9fe7bdfe1ffe369a
> src/python/native/mesos_scheduler_driver_impl.cpp 1c825327084d5d862006847762ad3c80831c5a21
>
> Diff: https://reviews.apache.org/r/23142/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 23142: Refactored the scheduler/executor driver to remove
calling 'stop'.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23142/#review46919
-----------------------------------------------------------
Any possibility of adding test coverage here?
- Bill Farner
On June 27, 2014, 10:41 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23142/
> -----------------------------------------------------------
>
> (Updated June 27, 2014, 10:41 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1550
> https://issues.apache.org/jira/browse/MESOS-1550
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See bug.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp 346e39f7fc7974c2f455e2f14508e0b39df737d7
> src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 32e9a2828874d2dd6fd71aa43888e48505e1287e
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp d0b71524829fada3cd8a56f1857e7cec6e27bb44
> src/python/native/mesos_executor_driver_impl.cpp aa564ed5c09673de8ce80d8d9fe7bdfe1ffe369a
> src/python/native/mesos_scheduler_driver_impl.cpp 1c825327084d5d862006847762ad3c80831c5a21
>
> Diff: https://reviews.apache.org/r/23142/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 23142: Refactored the scheduler/executor driver to remove
calling 'stop'.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23142/#review46938
-----------------------------------------------------------
Patch looks great!
Reviews applied: [23142]
All tests passed.
- Mesos ReviewBot
On June 27, 2014, 10:41 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23142/
> -----------------------------------------------------------
>
> (Updated June 27, 2014, 10:41 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1550
> https://issues.apache.org/jira/browse/MESOS-1550
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See bug.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp 346e39f7fc7974c2f455e2f14508e0b39df737d7
> src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 32e9a2828874d2dd6fd71aa43888e48505e1287e
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp d0b71524829fada3cd8a56f1857e7cec6e27bb44
> src/python/native/mesos_executor_driver_impl.cpp aa564ed5c09673de8ce80d8d9fe7bdfe1ffe369a
> src/python/native/mesos_scheduler_driver_impl.cpp 1c825327084d5d862006847762ad3c80831c5a21
>
> Diff: https://reviews.apache.org/r/23142/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>