You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2016/04/28 00:22:56 UTC
[1/2] mesos git commit: Fixed a memory leak in process::subprocess.
Repository: mesos
Updated Branches:
refs/heads/0.27.x 32b3b0782 -> 762763b41
Fixed a memory leak in process::subprocess.
Review: https://reviews.apache.org/r/45267
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/f1b88d0b
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/f1b88d0b
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/f1b88d0b
Branch: refs/heads/0.27.x
Commit: f1b88d0b1b5adccf4d00f4b11ae75b6ac05d892c
Parents: 32b3b07
Author: Benjamin Mahler <bm...@apache.org>
Authored: Wed Mar 23 20:30:32 2016 -0700
Committer: Benjamin Mahler <bm...@apache.org>
Committed: Wed Apr 27 14:50:50 2016 -0700
----------------------------------------------------------------------
3rdparty/libprocess/src/subprocess.cpp | 6 ++++++
1 file changed, 6 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/f1b88d0b/3rdparty/libprocess/src/subprocess.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/subprocess.cpp b/3rdparty/libprocess/src/subprocess.cpp
index ae73a58..657dcca 100644
--- a/3rdparty/libprocess/src/subprocess.cpp
+++ b/3rdparty/libprocess/src/subprocess.cpp
@@ -452,6 +452,12 @@ Try<Subprocess> subprocess(
// us and we needed to allocate the space.
if (environment.isSome()) {
CHECK_NE(os::raw::environment(), envp);
+
+ // We ignore the last 'envp' entry since it is NULL.
+ for (size_t index = 0; index < environment->size(); index++) {
+ delete[] envp[index];
+ }
+
delete[] envp;
}
[2/2] mesos git commit: Added backport of MESOS-5021 to 0.27.3.
Posted by bm...@apache.org.
Added backport of MESOS-5021 to 0.27.3.
This reflects the backport of MESOS-5021 to the 0.27.x branch.
Review: https://reviews.apache.org/r/46753
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/762763b4
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/762763b4
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/762763b4
Branch: refs/heads/0.27.x
Commit: 762763b413a4440be5ee7918eddbe4b3eb762ccc
Parents: f1b88d0
Author: Benjamin Mahler <bm...@apache.org>
Authored: Wed Apr 27 14:56:25 2016 -0700
Committer: Benjamin Mahler <bm...@apache.org>
Committed: Wed Apr 27 15:22:43 2016 -0700
----------------------------------------------------------------------
CHANGELOG | 2 ++
1 file changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/762763b4/CHANGELOG
----------------------------------------------------------------------
diff --git a/CHANGELOG b/CHANGELOG
index 5c545b2..ccc32f0 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -5,6 +5,8 @@ Release Notes - Mesos - Version 0.27.3
All Issues:
** Bug
* [MESOS-4705] - Linux 'perf' parsing logic may fail when OS distribution has perf backports.
+ * [MESOS-4869] - /usr/libexec/mesos/mesos-health-check using/leaking a lot of memory.
+ * [MESOS-5021] - Memory leak in subprocess when 'environment' argument is provided.
Release Notes - Mesos - Version 0.27.2