[GitHub] [airflow] potiuk commented on a change in pull request #9427: Remove redundant functions in airflow/security/utils.py

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #9427:
URL: https://github.com/apache/airflow/pull/9427#discussion_r443113767



##########
File path: airflow/security/utils.py
##########
@@ -56,26 +55,3 @@ def replace_hostname_pattern(components, host=None):
     if not fqdn or fqdn == '0.0.0.0':
         fqdn = get_hostname()
     return '%s/%s@%s' % (components[0], fqdn.lower(), components[2])
-
-
-def get_fqdn(hostname_or_ip=None):

Review comment:
       Shoudln't we deprecate them first? I tthink someone could have used those method - they seem generic enough to be usable.

##########
File path: airflow/security/utils.py
##########
@@ -56,26 +55,3 @@ def replace_hostname_pattern(components, host=None):
     if not fqdn or fqdn == '0.0.0.0':
         fqdn = get_hostname()
     return '%s/%s@%s' % (components[0], fqdn.lower(), components[2])
-
-
-def get_fqdn(hostname_or_ip=None):

Review comment:
       Shoudln't we deprecate them first? I tthink someone could have used those methods - they seem generic enough to be usable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org