You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "sajjad-moradi (via GitHub)" <gi...@apache.org> on 2023/07/13 17:46:42 UTC
[GitHub] [pinot] sajjad-moradi commented on a diff in pull request #11101: Allow setting the default MergeRollupTask segment group manager
sajjad-moradi commented on code in PR #11101:
URL: https://github.com/apache/pinot/pull/11101#discussion_r1262882994
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/segmentgroupmananger/MergeRollupTaskSegmentGroupManagerProvider.java:
##########
@@ -27,20 +27,27 @@
* Provider class for {@link MergeRollupTaskSegmentGroupManager}
*/
public abstract class MergeRollupTaskSegmentGroupManagerProvider {
+
+ private static String _defaultMergeRollupTaskSegmentGroupManagerClassName =
+ "DefaultMergeRollupTaskSegmentGroupManager";
Review Comment:
Doesn't the plugin require fully qualified class name?
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/segmentgroupmananger/MergeRollupTaskSegmentGroupManagerProvider.java:
##########
@@ -27,20 +27,27 @@
* Provider class for {@link MergeRollupTaskSegmentGroupManager}
*/
public abstract class MergeRollupTaskSegmentGroupManagerProvider {
+
+ private static String _defaultMergeRollupTaskSegmentGroupManagerClassName =
+ "DefaultMergeRollupTaskSegmentGroupManager";
+
+ public static void setDefaultMergeRollupTaskSegmentGroupManagerClassName(String className) {
+ _defaultMergeRollupTaskSegmentGroupManagerClassName = className;
+ }
+
/**
* Constructs the {@link MergeRollupTaskSegmentGroupManager} using MergeRollup task configs
*/
public static MergeRollupTaskSegmentGroupManager create(Map<String, String> taskConfigs) {
String segmentGroupManagerClassName =
taskConfigs.get(MinionConstants.MergeRollupTask.SEGMENT_GROUP_MANAGER_CLASS_NAME_KEY);
Review Comment:
Use `.getOrDefault` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org