You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/05 09:54:11 UTC
[jira] [Commented] (CB-5758) Give same behavior to InAppBrowser as
CordovaWebView for self-signed certs
[ https://issues.apache.org/jira/browse/CB-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362301#comment-15362301 ]
ASF GitHub Bot commented on CB-5758:
------------------------------------
GitHub user MLaudren opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/172
[CB-5758] (android/iOS) Possibility to disable ssl verification (allow selfsigned certificate)
I think it's linked to this issue:
https://issues.apache.org/jira/browse/CB-5758
### Platforms affected
Android
iOS
### What does this PR do?
Add option validatessl to disable, default is enable, the ssl certificate validation.
This allow https pages with selfsigned certificate to be opened.
### What testing has been done on this change?
Compilation and run on android / iOS.
### Checklist
- [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MLaudren/cordova-plugin-inappbrowser sslValid
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/172.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #172
----
commit 65e3a91b7622577c9904dfc091bfc5ceaad9d3f8
Author: Maxime LAUDREN <ma...@non.schneider-electric.com>
Date: 2016-07-05T08:35:44Z
Add ssl validation choice in option.
validatessl=no/yes, default = yes
commit bf85c7db8f3f22f32d847c1dbe82fdc84c79c4ab
Author: MLaudren <ma...@gmail.com>
Date: 2016-07-05T08:44:46Z
Update README.md
Add new option description in readme
----
> Give same behavior to InAppBrowser as CordovaWebView for self-signed certs
> --------------------------------------------------------------------------
>
> Key: CB-5758
> URL: https://issues.apache.org/jira/browse/CB-5758
> Project: Apache Cordova
> Issue Type: New Feature
> Components: Plugin InAppBrowser
> Reporter: Marcel Kinard
> Priority: Minor
>
> See CB-3576 for history. This is a request that came from there.
> At least on the Android platform, the main webview (CordovaWebView) will silently accept self-signed certs when debuggable="true" in AndroidManifest.xml. (Hopefully other platforms have a similar behavior in pre-production.) The goal of this new feature is to get InAppBrowser to have the same behavior as the main webview in this respect, which is does not have today. Then both the main webview and InAppBrowser will behave consistently when they encounter https connections that have a self-signed cert.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org