You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/11/28 07:26:15 UTC
[PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
panbingkun opened a new pull request, #44049:
URL: https://github.com/apache/spark/pull/44049
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44049: [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs
URL: https://github.com/apache/spark/pull/44049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #44049:
URL: https://github.com/apache/spark/pull/44049#discussion_r1407577428
##########
python/docs/source/getting_started/quickstart_df.ipynb:
##########
@@ -218,27 +218,23 @@
"metadata": {},
"outputs": [
{
- "data": {
- "text/html": [
- "<table border='1'>\n",
- "<tr><th>a</th><th>b</th><th>c</th><th>d</th><th>e</th></tr>\n",
- "<tr><td>1</td><td>2.0</td><td>string1</td><td>2000-01-01</td><td>2000-01-01 12:00:00</td></tr>\n",
- "<tr><td>2</td><td>3.0</td><td>string2</td><td>2000-02-01</td><td>2000-01-02 12:00:00</td></tr>\n",
- "<tr><td>3</td><td>4.0</td><td>string3</td><td>2000-03-01</td><td>2000-01-03 12:00:00</td></tr>\n",
- "</table>\n"
- ],
- "text/plain": [
- "DataFrame[a: bigint, b: double, c: string, d: date, e: timestamp]"
- ]
- },
- "execution_count": 8,
- "metadata": {},
- "output_type": "execute_result"
+ "name": "stdout",
+ "output_type": "stream",
+ "text": [
Review Comment:
Dark theme:
<img width="802" alt="image" src="https://github.com/apache/spark/assets/15246973/88151590-ea01-4bbc-8678-5bca2a20dc74">
Light theme:
<img width="811" alt="image" src="https://github.com/apache/spark/assets/15246973/3505f951-05ba-4620-ab65-779acfed4828">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #44049:
URL: https://github.com/apache/spark/pull/44049#issuecomment-1831260186
Nice fix! +1 for https://github.com/apache/spark/pull/44049#discussion_r1408578398, otherwise it looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44049:
URL: https://github.com/apache/spark/pull/44049#discussion_r1408578398
##########
python/docs/source/getting_started/quickstart_df.ipynb:
##########
@@ -424,76 +424,22 @@
"metadata": {},
"outputs": [
{
- "data": {
- "text/html": [
- "<div>\n",
- "<style scoped>\n",
- " .dataframe tbody tr th:only-of-type {\n",
- " vertical-align: middle;\n",
- " }\n",
- "\n",
- " .dataframe tbody tr th {\n",
- " vertical-align: top;\n",
- " }\n",
- "\n",
- " .dataframe thead th {\n",
- " text-align: right;\n",
- " }\n",
- "</style>\n",
- "<table border=\"1\" class=\"dataframe\">\n",
- " <thead>\n",
- " <tr style=\"text-align: right;\">\n",
- " <th></th>\n",
- " <th>a</th>\n",
- " <th>b</th>\n",
- " <th>c</th>\n",
- " <th>d</th>\n",
- " <th>e</th>\n",
- " </tr>\n",
- " </thead>\n",
- " <tbody>\n",
- " <tr>\n",
- " <th>0</th>\n",
- " <td>1</td>\n",
- " <td>2.0</td>\n",
- " <td>string1</td>\n",
- " <td>2000-01-01</td>\n",
- " <td>2000-01-01 12:00:00</td>\n",
- " </tr>\n",
- " <tr>\n",
- " <th>1</th>\n",
- " <td>2</td>\n",
- " <td>3.0</td>\n",
- " <td>string2</td>\n",
- " <td>2000-02-01</td>\n",
- " <td>2000-01-02 12:00:00</td>\n",
- " </tr>\n",
- " <tr>\n",
- " <th>2</th>\n",
- " <td>3</td>\n",
- " <td>4.0</td>\n",
- " <td>string3</td>\n",
- " <td>2000-03-01</td>\n",
- " <td>2000-01-03 12:00:00</td>\n",
- " </tr>\n",
- " </tbody>\n",
- "</table>\n",
- "</div>"
- ],
- "text/plain": [
- " a b c d e\n",
- "0 1 2.0 string1 2000-01-01 2000-01-01 12:00:00\n",
- "1 2 3.0 string2 2000-02-01 2000-01-02 12:00:00\n",
- "2 3 4.0 string3 2000-03-01 2000-01-03 12:00:00"
- ]
- },
- "execution_count": 15,
- "metadata": {},
- "output_type": "execute_result"
+ "name": "stdout",
+ "output_type": "stream",
+ "text": [
+ "+----+-----+-----+---------+------------+---------------------+\n",
+ "| | a | b | c | d | e |\n",
+ "|----+-----+-----+---------+------------+---------------------|\n",
+ "| 0 | 1 | 2 | string1 | 2000-01-01 | 2000-01-01 12:00:00 |\n",
+ "| 1 | 2 | 3 | string2 | 2000-02-01 | 2000-01-02 12:00:00 |\n",
+ "| 2 | 4 | 5 | string3 | 2000-03-01 | 2000-01-03 12:00:00 |\n",
+ "+----+-----+-----+---------+------------+---------------------+\n"
+ ]
}
],
"source": [
- "df.toPandas()"
+ "from tabulate import tabulate\n",
+ "print(tabulate(df.toPandas(), headers = 'keys', tablefmt = 'psql'))"
Review Comment:
Hm, the output format looks fine but the whole point of using `spark.sql.repl.eagerEval.enabled` is to show a pretty table format without applying any other operations in the notebook.
Can you maybe just manually fix the output `text/html` to be compatible with both the sphinx dark theme and jupyter notebook?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #44049:
URL: https://github.com/apache/spark/pull/44049#discussion_r1407577428
##########
python/docs/source/getting_started/quickstart_df.ipynb:
##########
@@ -218,27 +218,23 @@
"metadata": {},
"outputs": [
{
- "data": {
- "text/html": [
- "<table border='1'>\n",
- "<tr><th>a</th><th>b</th><th>c</th><th>d</th><th>e</th></tr>\n",
- "<tr><td>1</td><td>2.0</td><td>string1</td><td>2000-01-01</td><td>2000-01-01 12:00:00</td></tr>\n",
- "<tr><td>2</td><td>3.0</td><td>string2</td><td>2000-02-01</td><td>2000-01-02 12:00:00</td></tr>\n",
- "<tr><td>3</td><td>4.0</td><td>string3</td><td>2000-03-01</td><td>2000-01-03 12:00:00</td></tr>\n",
- "</table>\n"
- ],
- "text/plain": [
- "DataFrame[a: bigint, b: double, c: string, d: date, e: timestamp]"
- ]
- },
- "execution_count": 8,
- "metadata": {},
- "output_type": "execute_result"
+ "name": "stdout",
+ "output_type": "stream",
+ "text": [
Review Comment:
@HyukjinKwon Is the following presentation style appropriate for this special case?
- Dark theme:
<img width="802" alt="image" src="https://github.com/apache/spark/assets/15246973/88151590-ea01-4bbc-8678-5bca2a20dc74">
- Light theme:
<img width="811" alt="image" src="https://github.com/apache/spark/assets/15246973/3505f951-05ba-4620-ab65-779acfed4828">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #44049:
URL: https://github.com/apache/spark/pull/44049#discussion_r1408660391
##########
python/docs/source/getting_started/quickstart_df.ipynb:
##########
@@ -424,76 +424,22 @@
"metadata": {},
"outputs": [
{
- "data": {
- "text/html": [
- "<div>\n",
- "<style scoped>\n",
- " .dataframe tbody tr th:only-of-type {\n",
- " vertical-align: middle;\n",
- " }\n",
- "\n",
- " .dataframe tbody tr th {\n",
- " vertical-align: top;\n",
- " }\n",
- "\n",
- " .dataframe thead th {\n",
- " text-align: right;\n",
- " }\n",
- "</style>\n",
- "<table border=\"1\" class=\"dataframe\">\n",
- " <thead>\n",
- " <tr style=\"text-align: right;\">\n",
- " <th></th>\n",
- " <th>a</th>\n",
- " <th>b</th>\n",
- " <th>c</th>\n",
- " <th>d</th>\n",
- " <th>e</th>\n",
- " </tr>\n",
- " </thead>\n",
- " <tbody>\n",
- " <tr>\n",
- " <th>0</th>\n",
- " <td>1</td>\n",
- " <td>2.0</td>\n",
- " <td>string1</td>\n",
- " <td>2000-01-01</td>\n",
- " <td>2000-01-01 12:00:00</td>\n",
- " </tr>\n",
- " <tr>\n",
- " <th>1</th>\n",
- " <td>2</td>\n",
- " <td>3.0</td>\n",
- " <td>string2</td>\n",
- " <td>2000-02-01</td>\n",
- " <td>2000-01-02 12:00:00</td>\n",
- " </tr>\n",
- " <tr>\n",
- " <th>2</th>\n",
- " <td>3</td>\n",
- " <td>4.0</td>\n",
- " <td>string3</td>\n",
- " <td>2000-03-01</td>\n",
- " <td>2000-01-03 12:00:00</td>\n",
- " </tr>\n",
- " </tbody>\n",
- "</table>\n",
- "</div>"
- ],
- "text/plain": [
- " a b c d e\n",
- "0 1 2.0 string1 2000-01-01 2000-01-01 12:00:00\n",
- "1 2 3.0 string2 2000-02-01 2000-01-02 12:00:00\n",
- "2 3 4.0 string3 2000-03-01 2000-01-03 12:00:00"
- ]
- },
- "execution_count": 15,
- "metadata": {},
- "output_type": "execute_result"
+ "name": "stdout",
+ "output_type": "stream",
+ "text": [
+ "+----+-----+-----+---------+------------+---------------------+\n",
+ "| | a | b | c | d | e |\n",
+ "|----+-----+-----+---------+------------+---------------------|\n",
+ "| 0 | 1 | 2 | string1 | 2000-01-01 | 2000-01-01 12:00:00 |\n",
+ "| 1 | 2 | 3 | string2 | 2000-02-01 | 2000-01-02 12:00:00 |\n",
+ "| 2 | 4 | 5 | string3 | 2000-03-01 | 2000-01-03 12:00:00 |\n",
+ "+----+-----+-----+---------+------------+---------------------+\n"
+ ]
}
],
"source": [
- "df.toPandas()"
+ "from tabulate import tabulate\n",
+ "print(tabulate(df.toPandas(), headers = 'keys', tablefmt = 'psql'))"
Review Comment:
Oh, I understand what you mean.
For this document, I have modified the style to maintain using `spark.sql.repl.eagerEval.enabled` purpose to show a pretty table format without applying any other operations in the notebook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #44049:
URL: https://github.com/apache/spark/pull/44049#discussion_r1410431257
##########
python/docs/source/getting_started/quickstart_df.ipynb:
##########
@@ -424,76 +424,22 @@
"metadata": {},
"outputs": [
{
- "data": {
- "text/html": [
- "<div>\n",
- "<style scoped>\n",
- " .dataframe tbody tr th:only-of-type {\n",
- " vertical-align: middle;\n",
- " }\n",
- "\n",
- " .dataframe tbody tr th {\n",
- " vertical-align: top;\n",
- " }\n",
- "\n",
- " .dataframe thead th {\n",
- " text-align: right;\n",
- " }\n",
- "</style>\n",
- "<table border=\"1\" class=\"dataframe\">\n",
- " <thead>\n",
- " <tr style=\"text-align: right;\">\n",
- " <th></th>\n",
- " <th>a</th>\n",
- " <th>b</th>\n",
- " <th>c</th>\n",
- " <th>d</th>\n",
- " <th>e</th>\n",
- " </tr>\n",
- " </thead>\n",
- " <tbody>\n",
- " <tr>\n",
- " <th>0</th>\n",
- " <td>1</td>\n",
- " <td>2.0</td>\n",
- " <td>string1</td>\n",
- " <td>2000-01-01</td>\n",
- " <td>2000-01-01 12:00:00</td>\n",
- " </tr>\n",
- " <tr>\n",
- " <th>1</th>\n",
- " <td>2</td>\n",
- " <td>3.0</td>\n",
- " <td>string2</td>\n",
- " <td>2000-02-01</td>\n",
- " <td>2000-01-02 12:00:00</td>\n",
- " </tr>\n",
- " <tr>\n",
- " <th>2</th>\n",
- " <td>3</td>\n",
- " <td>4.0</td>\n",
- " <td>string3</td>\n",
- " <td>2000-03-01</td>\n",
- " <td>2000-01-03 12:00:00</td>\n",
- " </tr>\n",
- " </tbody>\n",
- "</table>\n",
- "</div>"
- ],
- "text/plain": [
- " a b c d e\n",
- "0 1 2.0 string1 2000-01-01 2000-01-01 12:00:00\n",
- "1 2 3.0 string2 2000-02-01 2000-01-02 12:00:00\n",
- "2 3 4.0 string3 2000-03-01 2000-01-03 12:00:00"
- ]
- },
- "execution_count": 15,
- "metadata": {},
- "output_type": "execute_result"
+ "name": "stdout",
+ "output_type": "stream",
+ "text": [
+ "+----+-----+-----+---------+------------+---------------------+\n",
+ "| | a | b | c | d | e |\n",
+ "|----+-----+-----+---------+------------+---------------------|\n",
+ "| 0 | 1 | 2 | string1 | 2000-01-01 | 2000-01-01 12:00:00 |\n",
+ "| 1 | 2 | 3 | string2 | 2000-02-01 | 2000-01-02 12:00:00 |\n",
+ "| 2 | 4 | 5 | string3 | 2000-03-01 | 2000-01-03 12:00:00 |\n",
+ "+----+-----+-----+---------+------------+---------------------+\n"
+ ]
}
],
"source": [
- "df.toPandas()"
+ "from tabulate import tabulate\n",
+ "print(tabulate(df.toPandas(), headers = 'keys', tablefmt = 'psql'))"
Review Comment:
The table format is also correct in `jupyter notebook`
<img width="836" alt="image" src="https://github.com/apache/spark/assets/15246973/602a1b6c-6146-4d69-abab-fc99e2ab5ed8">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #44049:
URL: https://github.com/apache/spark/pull/44049#discussion_r1407337308
##########
python/docs/source/getting_started/quickstart_connect.ipynb:
##########
@@ -28,7 +28,7 @@
"metadata": {},
"outputs": [],
"source": [
- "!$HOME/sbin/start-connect-server.sh --packages org.apache.spark:spark-connect_2.12:$SPARK_VERSION"
+ "!$HOME/sbin/start-connect-server.sh --packages org.apache.spark:spark-connect_2.13:$SPARK_VERSION"
Review Comment:
By the way, I made some changes because currently our scala version is `2.13`, `2.12` is no longer supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #44049:
URL: https://github.com/apache/spark/pull/44049#discussion_r1408656787
##########
python/docs/source/getting_started/quickstart_df.ipynb:
##########
@@ -424,76 +424,22 @@
"metadata": {},
"outputs": [
{
- "data": {
- "text/html": [
- "<div>\n",
- "<style scoped>\n",
- " .dataframe tbody tr th:only-of-type {\n",
- " vertical-align: middle;\n",
- " }\n",
- "\n",
- " .dataframe tbody tr th {\n",
- " vertical-align: top;\n",
- " }\n",
- "\n",
- " .dataframe thead th {\n",
- " text-align: right;\n",
- " }\n",
- "</style>\n",
- "<table border=\"1\" class=\"dataframe\">\n",
- " <thead>\n",
- " <tr style=\"text-align: right;\">\n",
- " <th></th>\n",
- " <th>a</th>\n",
- " <th>b</th>\n",
- " <th>c</th>\n",
- " <th>d</th>\n",
- " <th>e</th>\n",
- " </tr>\n",
- " </thead>\n",
- " <tbody>\n",
- " <tr>\n",
- " <th>0</th>\n",
- " <td>1</td>\n",
- " <td>2.0</td>\n",
- " <td>string1</td>\n",
- " <td>2000-01-01</td>\n",
- " <td>2000-01-01 12:00:00</td>\n",
- " </tr>\n",
- " <tr>\n",
- " <th>1</th>\n",
- " <td>2</td>\n",
- " <td>3.0</td>\n",
- " <td>string2</td>\n",
- " <td>2000-02-01</td>\n",
- " <td>2000-01-02 12:00:00</td>\n",
- " </tr>\n",
- " <tr>\n",
- " <th>2</th>\n",
- " <td>3</td>\n",
- " <td>4.0</td>\n",
- " <td>string3</td>\n",
- " <td>2000-03-01</td>\n",
- " <td>2000-01-03 12:00:00</td>\n",
- " </tr>\n",
- " </tbody>\n",
- "</table>\n",
- "</div>"
- ],
- "text/plain": [
- " a b c d e\n",
- "0 1 2.0 string1 2000-01-01 2000-01-01 12:00:00\n",
- "1 2 3.0 string2 2000-02-01 2000-01-02 12:00:00\n",
- "2 3 4.0 string3 2000-03-01 2000-01-03 12:00:00"
- ]
- },
- "execution_count": 15,
- "metadata": {},
- "output_type": "execute_result"
+ "name": "stdout",
+ "output_type": "stream",
+ "text": [
+ "+----+-----+-----+---------+------------+---------------------+\n",
+ "| | a | b | c | d | e |\n",
+ "|----+-----+-----+---------+------------+---------------------|\n",
+ "| 0 | 1 | 2 | string1 | 2000-01-01 | 2000-01-01 12:00:00 |\n",
+ "| 1 | 2 | 3 | string2 | 2000-02-01 | 2000-01-02 12:00:00 |\n",
+ "| 2 | 4 | 5 | string3 | 2000-03-01 | 2000-01-03 12:00:00 |\n",
+ "+----+-----+-----+---------+------------+---------------------+\n"
+ ]
}
],
"source": [
- "df.toPandas()"
+ "from tabulate import tabulate\n",
+ "print(tabulate(df.toPandas(), headers = 'keys', tablefmt = 'psql'))"
Review Comment:
- Dark theme:
<img width="749" alt="image" src="https://github.com/apache/spark/assets/15246973/95ee1402-8038-4438-808d-e0d02c0fb85a">
- Light theme:
<img width="738" alt="image" src="https://github.com/apache/spark/assets/15246973/0e3448f3-d455-4136-9a94-ec957463ce21">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44049:
URL: https://github.com/apache/spark/pull/44049#discussion_r1410080565
##########
python/docs/source/getting_started/quickstart_ps.ipynb:
##########
@@ -99,89 +99,21 @@
"metadata": {},
"outputs": [
{
- "data": {
- "text/html": [
Review Comment:
Actually can you also manually fix the HTML here instead of using `print(psdf)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44049:
URL: https://github.com/apache/spark/pull/44049#issuecomment-1835150615
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #44049:
URL: https://github.com/apache/spark/pull/44049#discussion_r1407340006
##########
python/docs/source/getting_started/quickstart_df.ipynb:
##########
@@ -218,27 +218,23 @@
"metadata": {},
"outputs": [
{
- "data": {
- "text/html": [
- "<table border='1'>\n",
- "<tr><th>a</th><th>b</th><th>c</th><th>d</th><th>e</th></tr>\n",
- "<tr><td>1</td><td>2.0</td><td>string1</td><td>2000-01-01</td><td>2000-01-01 12:00:00</td></tr>\n",
- "<tr><td>2</td><td>3.0</td><td>string2</td><td>2000-02-01</td><td>2000-01-02 12:00:00</td></tr>\n",
- "<tr><td>3</td><td>4.0</td><td>string3</td><td>2000-03-01</td><td>2000-01-03 12:00:00</td></tr>\n",
- "</table>\n"
- ],
- "text/plain": [
- "DataFrame[a: bigint, b: double, c: string, d: date, e: timestamp]"
- ]
- },
- "execution_count": 8,
- "metadata": {},
- "output_type": "execute_result"
+ "name": "stdout",
+ "output_type": "stream",
+ "text": [
Review Comment:
Let's present the output results in `text` format instead of `text/html` format to avoid formatting errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44049:
URL: https://github.com/apache/spark/pull/44049#discussion_r1407341045
##########
python/docs/source/getting_started/quickstart_df.ipynb:
##########
@@ -218,27 +218,23 @@
"metadata": {},
"outputs": [
{
- "data": {
- "text/html": [
- "<table border='1'>\n",
- "<tr><th>a</th><th>b</th><th>c</th><th>d</th><th>e</th></tr>\n",
- "<tr><td>1</td><td>2.0</td><td>string1</td><td>2000-01-01</td><td>2000-01-01 12:00:00</td></tr>\n",
- "<tr><td>2</td><td>3.0</td><td>string2</td><td>2000-02-01</td><td>2000-01-02 12:00:00</td></tr>\n",
- "<tr><td>3</td><td>4.0</td><td>string3</td><td>2000-03-01</td><td>2000-01-03 12:00:00</td></tr>\n",
- "</table>\n"
- ],
- "text/plain": [
- "DataFrame[a: bigint, b: double, c: string, d: date, e: timestamp]"
- ]
- },
- "execution_count": 8,
- "metadata": {},
- "output_type": "execute_result"
+ "name": "stdout",
+ "output_type": "stream",
+ "text": [
Review Comment:
Hm, this example should show the output nicely as `spark.sql.repl.eagerEval.enabled` is enabled. Wonder if we can fix the docs instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #44049:
URL: https://github.com/apache/spark/pull/44049#discussion_r1408661534
##########
python/docs/source/getting_started/quickstart_df.ipynb:
##########
@@ -424,76 +424,22 @@
"metadata": {},
"outputs": [
{
- "data": {
- "text/html": [
- "<div>\n",
- "<style scoped>\n",
- " .dataframe tbody tr th:only-of-type {\n",
- " vertical-align: middle;\n",
- " }\n",
- "\n",
- " .dataframe tbody tr th {\n",
- " vertical-align: top;\n",
- " }\n",
- "\n",
- " .dataframe thead th {\n",
- " text-align: right;\n",
- " }\n",
- "</style>\n",
- "<table border=\"1\" class=\"dataframe\">\n",
- " <thead>\n",
- " <tr style=\"text-align: right;\">\n",
- " <th></th>\n",
- " <th>a</th>\n",
- " <th>b</th>\n",
- " <th>c</th>\n",
- " <th>d</th>\n",
- " <th>e</th>\n",
- " </tr>\n",
- " </thead>\n",
- " <tbody>\n",
- " <tr>\n",
- " <th>0</th>\n",
- " <td>1</td>\n",
- " <td>2.0</td>\n",
- " <td>string1</td>\n",
- " <td>2000-01-01</td>\n",
- " <td>2000-01-01 12:00:00</td>\n",
- " </tr>\n",
- " <tr>\n",
- " <th>1</th>\n",
- " <td>2</td>\n",
- " <td>3.0</td>\n",
- " <td>string2</td>\n",
- " <td>2000-02-01</td>\n",
- " <td>2000-01-02 12:00:00</td>\n",
- " </tr>\n",
- " <tr>\n",
- " <th>2</th>\n",
- " <td>3</td>\n",
- " <td>4.0</td>\n",
- " <td>string3</td>\n",
- " <td>2000-03-01</td>\n",
- " <td>2000-01-03 12:00:00</td>\n",
- " </tr>\n",
- " </tbody>\n",
- "</table>\n",
- "</div>"
- ],
- "text/plain": [
- " a b c d e\n",
- "0 1 2.0 string1 2000-01-01 2000-01-01 12:00:00\n",
- "1 2 3.0 string2 2000-02-01 2000-01-02 12:00:00\n",
- "2 3 4.0 string3 2000-03-01 2000-01-03 12:00:00"
- ]
- },
- "execution_count": 15,
- "metadata": {},
- "output_type": "execute_result"
+ "name": "stdout",
+ "output_type": "stream",
+ "text": [
+ "+----+-----+-----+---------+------------+---------------------+\n",
+ "| | a | b | c | d | e |\n",
+ "|----+-----+-----+---------+------------+---------------------|\n",
+ "| 0 | 1 | 2 | string1 | 2000-01-01 | 2000-01-01 12:00:00 |\n",
+ "| 1 | 2 | 3 | string2 | 2000-02-01 | 2000-01-02 12:00:00 |\n",
+ "| 2 | 4 | 5 | string3 | 2000-03-01 | 2000-01-03 12:00:00 |\n",
+ "+----+-----+-----+---------+------------+---------------------+\n"
+ ]
}
],
"source": [
- "df.toPandas()"
+ "from tabulate import tabulate\n",
+ "print(tabulate(df.toPandas(), headers = 'keys', tablefmt = 'psql'))"
Review Comment:
For `quickstart_ps.`, are we going to do something similar?
Because this example does not use `spark.sql.repl.eagerEval.enabled`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #44049:
URL: https://github.com/apache/spark/pull/44049#discussion_r1410126793
##########
python/docs/source/getting_started/quickstart_ps.ipynb:
##########
@@ -99,89 +99,21 @@
"metadata": {},
"outputs": [
{
- "data": {
- "text/html": [
Review Comment:
Okay, I'll give it a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #44049:
URL: https://github.com/apache/spark/pull/44049#discussion_r1410425443
##########
python/docs/source/getting_started/quickstart_ps.ipynb:
##########
@@ -1840,27 +1840,31 @@
" text-align: right;\n",
" }\n",
"</style>\n",
- "<table border=\"1\" class=\"dataframe\">\n",
+ "<table border=\"1\" class=\"dataframe\" style=\"table-layout: auto;margin-right: auto;margin-left: 0;\">\n",
Review Comment:
The example result in this place is incorrect, we need to correct it
https://spark.apache.org/docs/latest/api/python/getting_started/quickstart_ps.html#Grouping
Before:
<img width="772" alt="image" src="https://github.com/apache/spark/assets/15246973/a594c3b6-ed97-4c53-8f02-bc31143b7bfc">
After:
<img width="739" alt="image" src="https://github.com/apache/spark/assets/15246973/3d1dc198-2b8e-4a31-80f6-177b7d2d92ed">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #44049:
URL: https://github.com/apache/spark/pull/44049#issuecomment-1829262703
cc @itholic @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #44049:
URL: https://github.com/apache/spark/pull/44049#discussion_r1407577428
##########
python/docs/source/getting_started/quickstart_df.ipynb:
##########
@@ -218,27 +218,23 @@
"metadata": {},
"outputs": [
{
- "data": {
- "text/html": [
- "<table border='1'>\n",
- "<tr><th>a</th><th>b</th><th>c</th><th>d</th><th>e</th></tr>\n",
- "<tr><td>1</td><td>2.0</td><td>string1</td><td>2000-01-01</td><td>2000-01-01 12:00:00</td></tr>\n",
- "<tr><td>2</td><td>3.0</td><td>string2</td><td>2000-02-01</td><td>2000-01-02 12:00:00</td></tr>\n",
- "<tr><td>3</td><td>4.0</td><td>string3</td><td>2000-03-01</td><td>2000-01-03 12:00:00</td></tr>\n",
- "</table>\n"
- ],
- "text/plain": [
- "DataFrame[a: bigint, b: double, c: string, d: date, e: timestamp]"
- ]
- },
- "execution_count": 8,
- "metadata": {},
- "output_type": "execute_result"
+ "name": "stdout",
+ "output_type": "stream",
+ "text": [
Review Comment:
@HyukjinKwon Is the following presentation style appropriate for this special case?
Dark theme:
<img width="802" alt="image" src="https://github.com/apache/spark/assets/15246973/88151590-ea01-4bbc-8678-5bca2a20dc74">
Light theme:
<img width="811" alt="image" src="https://github.com/apache/spark/assets/15246973/3505f951-05ba-4620-ab65-779acfed4828">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #44049:
URL: https://github.com/apache/spark/pull/44049#discussion_r1408661534
##########
python/docs/source/getting_started/quickstart_df.ipynb:
##########
@@ -424,76 +424,22 @@
"metadata": {},
"outputs": [
{
- "data": {
- "text/html": [
- "<div>\n",
- "<style scoped>\n",
- " .dataframe tbody tr th:only-of-type {\n",
- " vertical-align: middle;\n",
- " }\n",
- "\n",
- " .dataframe tbody tr th {\n",
- " vertical-align: top;\n",
- " }\n",
- "\n",
- " .dataframe thead th {\n",
- " text-align: right;\n",
- " }\n",
- "</style>\n",
- "<table border=\"1\" class=\"dataframe\">\n",
- " <thead>\n",
- " <tr style=\"text-align: right;\">\n",
- " <th></th>\n",
- " <th>a</th>\n",
- " <th>b</th>\n",
- " <th>c</th>\n",
- " <th>d</th>\n",
- " <th>e</th>\n",
- " </tr>\n",
- " </thead>\n",
- " <tbody>\n",
- " <tr>\n",
- " <th>0</th>\n",
- " <td>1</td>\n",
- " <td>2.0</td>\n",
- " <td>string1</td>\n",
- " <td>2000-01-01</td>\n",
- " <td>2000-01-01 12:00:00</td>\n",
- " </tr>\n",
- " <tr>\n",
- " <th>1</th>\n",
- " <td>2</td>\n",
- " <td>3.0</td>\n",
- " <td>string2</td>\n",
- " <td>2000-02-01</td>\n",
- " <td>2000-01-02 12:00:00</td>\n",
- " </tr>\n",
- " <tr>\n",
- " <th>2</th>\n",
- " <td>3</td>\n",
- " <td>4.0</td>\n",
- " <td>string3</td>\n",
- " <td>2000-03-01</td>\n",
- " <td>2000-01-03 12:00:00</td>\n",
- " </tr>\n",
- " </tbody>\n",
- "</table>\n",
- "</div>"
- ],
- "text/plain": [
- " a b c d e\n",
- "0 1 2.0 string1 2000-01-01 2000-01-01 12:00:00\n",
- "1 2 3.0 string2 2000-02-01 2000-01-02 12:00:00\n",
- "2 3 4.0 string3 2000-03-01 2000-01-03 12:00:00"
- ]
- },
- "execution_count": 15,
- "metadata": {},
- "output_type": "execute_result"
+ "name": "stdout",
+ "output_type": "stream",
+ "text": [
+ "+----+-----+-----+---------+------------+---------------------+\n",
+ "| | a | b | c | d | e |\n",
+ "|----+-----+-----+---------+------------+---------------------|\n",
+ "| 0 | 1 | 2 | string1 | 2000-01-01 | 2000-01-01 12:00:00 |\n",
+ "| 1 | 2 | 3 | string2 | 2000-02-01 | 2000-01-02 12:00:00 |\n",
+ "| 2 | 4 | 5 | string3 | 2000-03-01 | 2000-01-03 12:00:00 |\n",
+ "+----+-----+-----+---------+------------+---------------------+\n"
+ ]
}
],
"source": [
- "df.toPandas()"
+ "from tabulate import tabulate\n",
+ "print(tabulate(df.toPandas(), headers = 'keys', tablefmt = 'psql'))"
Review Comment:
For `python/docs/source/getting_started/quickstart_df.ipynb`, are we going to do something similar?
Because this example does not use `spark.sql.repl.eagerEval.enabled`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46135][PYTHON][DOCS] Fix table format error in ipynb docs [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44049:
URL: https://github.com/apache/spark/pull/44049#discussion_r1410080668
##########
python/docs/source/getting_started/quickstart_ps.ipynb:
##########
@@ -99,89 +99,21 @@
"metadata": {},
"outputs": [
{
- "data": {
- "text/html": [
Review Comment:
If that's possible, it would really be great :-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org