[GitHub] [airflow] aa1371 edited a comment on pull request #16829: Queue support for DaskExecutor using Dask Worker Resources

[GitBox <gi...@apache.org>]

aa1371 edited a comment on pull request #16829:
URL: https://github.com/apache/airflow/pull/16829#issuecomment-903178653


   Understood, and yea I see the issue. Looks like the default queue_name in the conf is "default" as opposed to undefined (potentially an artifact of celery). How do you think we should handle this with respect to DaskExecutor? Seems like as of right now a default needs to be defined or else `BaseOperator.__init__` will fail on getting the default queue.
   
   Several ways I can see handling this:
   
   1) Make `queue='default'` a special case in DaskExecutor, which just acts as if no queue  name was passed in
   2) Require users of the DaskExecutor to specify an empty default_queue value in the config (if they don't want to use queues)
   3) Update the base config/BaseOperator, to provide an undefined queue to start with
   
   I'm thinking option 1 is probably the most straightforward way to go. Thoughts @potiuk?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org