You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/31 15:39:36 UTC

[GitHub] [tvm] areusch commented on a change in pull request #7774: [microTVM] Fix RVM onnx dependency and Zephyr document update

areusch commented on a change in pull request #7774:
URL: https://github.com/apache/tvm/pull/7774#discussion_r605005336



##########
File path: apps/microtvm/pyproject.toml
##########
@@ -93,7 +93,7 @@ cffi = {version = "^1.14", optional = true}
 mxnet = {version = "^1.6.0", optional = true}
 
 # ONNX frontend
-onnx = {version = "1.6.0", optional = true}
+onnx = {version = "1.6.0", optional = false}

Review comment:
       I wonder if we can instead change `apps/microtvm/reference-vm/zephyr/setup.sh` to do `pip install -E importer-onnx`? I'd like to eventually unify this file with the one produced by https://discuss.tvm.apache.org/t/rfc-python-dependencies-in-tvm-ci-containers/9011




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org