You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/09/14 12:27:10 UTC
[GitHub] [httpcomponents-client] teng-jie opened a new pull request #255: PoolingAsyncClientConnectionManager protocol version judge
teng-jie opened a new pull request #255:
URL: https://github.com/apache/httpcomponents-client/pull/255
i have a problem here.
it doesn't support PingCommand When I use HTTP 1.1 protocol. because AbstractHttp1StreamDuplexer.class doesn't support PingCommand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c merged pull request #255: PoolingAsyncClientConnectionManager incorrectly emits Ping commands to HTTP/1.1 endpoints
Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #255:
URL: https://github.com/apache/httpcomponents-client/pull/255
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #255: PoolingAsyncClientConnectionManager protocol version judge
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #255:
URL: https://github.com/apache/httpcomponents-client/pull/255#issuecomment-692558908
@teng-jie You are absolutely right. Thank you for contributing the fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] teng-jie commented on pull request #255: PoolingAsyncClientConnectionManager protocol version judge
Posted by GitBox <gi...@apache.org>.
teng-jie commented on pull request #255:
URL: https://github.com/apache/httpcomponents-client/pull/255#issuecomment-692416462
hi~ @ok2c，I am very glad for you to reply my question.
you say that sends a ping message only if the connection is known to support HTTP/2 or greater.
but the source code “if (HttpVersion.HTTP_2_0.greaterEquals(protocolVersion))“, when the protocolVersion = HTTP/1.1, it always return true，so will cause sends a ping message。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #255: PoolingAsyncClientConnectionManager protocol version judge
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #255:
URL: https://github.com/apache/httpcomponents-client/pull/255#issuecomment-692100904
@teng-jie I am not sure I understand the problem you are having and the reason why you want to make this change. `PoolingAsyncClientConnectionManager` sends a ping message only if the connection is known to support HTTP/2 or greater.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org