You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/10 07:50:20 UTC

[GitHub] [incubator-nuttx] cclauss commented on a change in pull request #3502: Lint Python code with flake8 and isort

cclauss commented on a change in pull request #3502:
URL: https://github.com/apache/incubator-nuttx/pull/3502#discussion_r611012669



##########
File path: .github/workflows/lint.yml
##########
@@ -10,9 +10,20 @@ jobs:
       - uses: actions/checkout@v2
         with:
           fetch-depth: 0
-      - name: YAML Lint
+      - run: mkdir -p super-linter.report
+      - name: Lint Python
         uses: github/super-linter@v3
         env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           VALIDATE_ALL_CODEBASE: false
-          VALIDATE_YAML: true
           VALIDATE_PYTHON_BLACK: true
+          VALIDATE_PYTHON_FLAKE8: true
+          PYTHON_FLAKE8_CONFIG_FILE: setup.cfg
+          VALIDATE_PYTHON_ISORT: true
+          PYTHON_ISORT_CONFIG_FILE: setup.cfg
+      - name: Lint YAML

Review comment:
       Merged.  I did as suggested but...
   
   My sense was that contributors would want to know-at-a-glance errors were raised in C/C++, Python, shell, or YAML.  Lumping all languages into a single task forces contributors to scan thru all logs in search of errors instead of only the logs for the language that failed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org