You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by yo...@apache.org on 2012/08/06 22:26:59 UTC
svn commit: r1369984 - in /lucene/dev/trunk/solr:
core/src/test/org/apache/solr/ core/src/test/org/apache/solr/cloud/
test-framework/src/java/org/apache/solr/
Author: yonik
Date: Mon Aug 6 20:26:59 2012
New Revision: 1369984
URL: http://svn.apache.org/viewvc?rev=1369984&view=rev
Log:
tests: fix test of unordered namedlist, skip explain comparisons
Modified:
lucene/dev/trunk/solr/core/src/test/org/apache/solr/TestDistributedSearch.java
lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java
lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/FullSolrCloudTest.java
lucene/dev/trunk/solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java
Modified: lucene/dev/trunk/solr/core/src/test/org/apache/solr/TestDistributedSearch.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/TestDistributedSearch.java?rev=1369984&r1=1369983&r2=1369984&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/test/org/apache/solr/TestDistributedSearch.java (original)
+++ lucene/dev/trunk/solr/core/src/test/org/apache/solr/TestDistributedSearch.java Mon Aug 6 20:26:59 2012
@@ -310,7 +310,8 @@ public class TestDistributedSearch exten
unIgnoreException("isShard is only acceptable");
// test debugging
- handle.put("explain", UNORDERED);
+ // handle.put("explain", UNORDERED);
+ handle.put("explain", SKIPVAL); // internal docids differ, idf differs w/o global idf
handle.put("debug", UNORDERED);
handle.put("time", SKIPVAL);
query("q","now their fox sat had put","fl","*,score",CommonParams.DEBUG_QUERY, "true");
Modified: lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java?rev=1369984&r1=1369983&r2=1369984&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java (original)
+++ lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java Mon Aug 6 20:26:59 2012
@@ -281,7 +281,7 @@ public class BasicDistributedZkTest exte
}
// test debugging
- handle.put("explain", UNORDERED);
+ handle.put("explain", SKIPVAL);
handle.put("debug", UNORDERED);
handle.put("time", SKIPVAL);
query("q","now their fox sat had put","fl","*,score",CommonParams.DEBUG_QUERY, "true");
Modified: lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/FullSolrCloudTest.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/FullSolrCloudTest.java?rev=1369984&r1=1369983&r2=1369984&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/FullSolrCloudTest.java (original)
+++ lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/FullSolrCloudTest.java Mon Aug 6 20:26:59 2012
@@ -845,7 +845,7 @@ public class FullSolrCloudTest extends A
}
private void testDebugQueries() throws Exception {
- handle.put("explain", UNORDERED);
+ handle.put("explain", SKIPVAL);
handle.put("debug", UNORDERED);
handle.put("time", SKIPVAL);
query("q", "now their fox sat had put", "fl", "*,score",
Modified: lucene/dev/trunk/solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java?rev=1369984&r1=1369983&r2=1369984&view=diff
==============================================================================
--- lucene/dev/trunk/solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java (original)
+++ lucene/dev/trunk/solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java Mon Aug 6 20:26:59 2012
@@ -450,11 +450,25 @@ public abstract class BaseDistributedSea
// System.out.println("resp b:" + b);
boolean ordered = (flags & UNORDERED) == 0;
+ if (!ordered) {
+ Map mapA = new HashMap(a.size());
+ for (int i=0; i<a.size(); i++) {
+ Object prev = mapA.put(a.getName(i), a.getVal(i));
+ }
+
+ Map mapB = new HashMap(b.size());
+ for (int i=0; i<b.size(); i++) {
+ Object prev = mapB.put(b.getName(i), b.getVal(i));
+ }
+
+ return compare(mapA, mapB, flags, handle);
+ }
+
int posa = 0, posb = 0;
int aSkipped = 0, bSkipped = 0;
for (; ;) {
- if (posa >= a.size() || posb >= b.size()) {
+ if (posa >= a.size() && posb >= b.size()) {
break;
}
@@ -468,29 +482,27 @@ public abstract class BaseDistributedSea
posa++;
flagsa = flags(handle, namea);
if ((flagsa & SKIP) != 0) {
+ namea = null; vala = null;
aSkipped++;
continue;
}
break;
}
- if (!ordered) posb = 0; // reset if not ordered
-
while (posb < b.size()) {
nameb = b.getName(posb);
valb = b.getVal(posb);
posb++;
flagsb = flags(handle, nameb);
if ((flagsb & SKIP) != 0) {
+ nameb = null; valb = null;
bSkipped++;
continue;
}
if (eq(namea, nameb)) {
break;
}
- if (ordered) {
- return "." + namea + "!=" + nameb + " (unordered or missing)";
- }
+ return "." + namea + "!=" + nameb + " (unordered or missing)";
// if unordered, continue until we find the right field.
}
@@ -503,7 +515,7 @@ public abstract class BaseDistributedSea
if (a.size() - aSkipped != b.size() - bSkipped) {
- return ".size()==" + a.size() + "," + b.size() + "skipped=" + aSkipped + "," + bSkipped;
+ return ".size()==" + a.size() + "," + b.size() + " skipped=" + aSkipped + "," + bSkipped;
}
return null;