You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/13 06:26:53 UTC

[GitHub] [pulsar] Nicklee007 opened a new pull request, #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Nicklee007 opened a new pull request, #16563:
URL: https://github.com/apache/pulsar/pull/16563

   ### Motivation
   As  the [PIP 7: Pulsar Failure domain and Anti affinity namespaces](https://github.com/apache/pulsar/wiki/PIP-7:-Pulsar-Failure-domain-and-Anti-affinity-namespaces#how-to-create-domain-and-register-brokers) design, the anti affinity namespaces should be distributed to  evenly across all domain and all the brokers.
   But in method `getAntiAffinityNamespaceOwnedBrokers` , `brokerToAntiAffinityNamespaceCount` add a count even the namespace  equal the given bundle's namespace which will be load. The behavior will cause the namespace easy to distributed to 
    a broker which has another namespace in anti affinity group,   the behavior broke the  anti affinity balance. It's better behavior is the same namespace should be distributed to those broker which has loaded the same namespace when all broker have load at least one namespace in ti affinity group.
   
    there is some case 
   `broker-0` own `ns-0 bundle-0`;  
   `broker-1` own `ns-1 bundle-0`; 
   `broker-2 `own `ns-2 bundle-0`;
     then another ` ns-2 bundle-1` need choice a broker to load. As the old policy, `broker-0 broker-1 and broker-2` are all satisfy the least NamespaceCount; but if  `ns-2 bundle-1` load to `broker-0 or broker-1 `will broke the anti affinity balance.  `ns-2 bundle-1` need be load by broker-2 is better.
   
   Also, the the behavior will cause give up `doLoadShedding` when the all broker own one namespace in anti affinity group, but the different broker owned namespace bundle count and payload is different.
   So `brokerToAntiAffinityNamespaceCount` should exclude  the same namespace as the given.
   
   ### Modifications
   1. In LoadManagerShared.class  `getAntiAffinityNamespaceOwnedBrokers` method,  exclude  the given namespace count add.
   2.  changed `shouldAntiAffinityNamespaceUnload` check;
   3. add some unit test.
   
   ### Documentation
   - [X] `doc-not-needed` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1192470519

   @Jason918 Could you help to review this PR, Thx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1189914742

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1186173627

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1378735150

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1426571627

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1194996118

   @codelipenghui @Jason918 @eolivelli Could you help to review this PR, Thx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1287584921

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1185453084

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1186623081

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1189907630

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codecov-commenter commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1378606842

   # [Codecov](https://codecov.io/gh/apache/pulsar/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#16563](https://codecov.io/gh/apache/pulsar/pull/16563?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (118b16b) into [master](https://codecov.io/gh/apache/pulsar/commit/b05fddb1af03456438f27217dc6979be00fac19e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b05fddb) will **decrease** coverage by `8.44%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/pulsar/pull/16563/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/pulsar/pull/16563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #16563      +/-   ##
   ============================================
   - Coverage     45.64%   37.19%   -8.45%     
   + Complexity    11043     1988    -9055     
   ============================================
     Files           773      209     -564     
     Lines         74463    14452   -60011     
     Branches       8018     1577    -6441     
   ============================================
   - Hits          33986     5376   -28610     
   + Misses        36687     8492   -28195     
   + Partials       3790      584    -3206     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | unittests | `37.19% <ø> (-8.45%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/16563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...g/apache/pulsar/client/impl/ConnectionHandler.java](https://codecov.io/gh/apache/pulsar/pull/16563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL0Nvbm5lY3Rpb25IYW5kbGVyLmphdmE=) | `50.00% <0.00%> (-5.32%)` | :arrow_down: |
   | [...he/pulsar/client/impl/PartitionedProducerImpl.java](https://codecov.io/gh/apache/pulsar/pull/16563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1BhcnRpdGlvbmVkUHJvZHVjZXJJbXBsLmphdmE=) | `30.34% <0.00%> (-5.13%)` | :arrow_down: |
   | [...va/org/apache/pulsar/client/impl/ProducerImpl.java](https://codecov.io/gh/apache/pulsar/pull/16563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1Byb2R1Y2VySW1wbC5qYXZh) | `15.66% <0.00%> (-1.17%)` | :arrow_down: |
   | [.../pulsar/client/impl/ProducerStatsRecorderImpl.java](https://codecov.io/gh/apache/pulsar/pull/16563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1Byb2R1Y2VyU3RhdHNSZWNvcmRlckltcGwuamF2YQ==) | `84.04% <0.00%> (-0.62%)` | :arrow_down: |
   | [...sar/broker/loadbalance/impl/LoadManagerShared.java](https://codecov.io/gh/apache/pulsar/pull/16563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9pbXBsL0xvYWRNYW5hZ2VyU2hhcmVkLmphdmE=) | | |
   | [...ulsar/proxy/extensions/ProxyExtensionMetadata.java](https://codecov.io/gh/apache/pulsar/pull/16563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLXByb3h5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvcHJveHkvZXh0ZW5zaW9ucy9Qcm94eUV4dGVuc2lvbk1ldGFkYXRhLmphdmE=) | | |
   | [...er/loadbalance/impl/ModularLoadManagerWrapper.java](https://codecov.io/gh/apache/pulsar/pull/16563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9pbXBsL01vZHVsYXJMb2FkTWFuYWdlcldyYXBwZXIuamF2YQ==) | | |
   | [...a/org/apache/pulsar/proxy/server/ProxyService.java](https://codecov.io/gh/apache/pulsar/pull/16563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLXByb3h5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvcHJveHkvc2VydmVyL1Byb3h5U2VydmljZS5qYXZh) | | |
   | [...a/org/apache/pulsar/broker/admin/v3/Functions.java](https://codecov.io/gh/apache/pulsar/pull/16563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92My9GdW5jdGlvbnMuamF2YQ==) | | |
   | [...org/apache/pulsar/broker/web/WebExecutorStats.java](https://codecov.io/gh/apache/pulsar/pull/16563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci93ZWIvV2ViRXhlY3V0b3JTdGF0cy5qYXZh) | | |
   | ... and [559 more](https://codecov.io/gh/apache/pulsar/pull/16563?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1378587400

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1186614239

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1186630723

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1186621997

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1189868319

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1197647410

   > What's the anti affinity setting in this case?
   
   ns-0 ns-1 ns-2 are all set the same anti affinity group like 'a-group', and the three ns be anti affinity load is expected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1200651784

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1186621161

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1189885220

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1197636328

   > there is some case
   > `broker-0` own `ns-0 bundle-0`;
   > `broker-1` own `ns-1 bundle-0`;
   > `broker-2 `own `ns-2 bundle-0`;
   > then another ` ns-2 bundle-1` need choice a broker to load. As the old policy, `broker-0 broker-1 and broker-2` are all satisfy the least NamespaceCount; but if `ns-2 bundle-1` load to `broker-0 or broker-1 `will broke the anti affinity balance. `ns-2 bundle-1` need be load by broker-2 is better.
   
   What's the anti affinity setting in this case?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on pull request #16563: [improve][broker]improve the getAntiAffinityNamespaceOwnedBrokers check exclude the current namespace cause count add.

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #16563:
URL: https://github.com/apache/pulsar/pull/16563#issuecomment-1378588143

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org