You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "Andy Gumbrecht (JIRA)" <ji...@apache.org> on 2010/04/27 09:59:33 UTC
[jira] Created: (OPENEJB-1267) ActiveMQResourceAdapter improvements
ActiveMQResourceAdapter improvements
------------------------------------
Key: OPENEJB-1267
URL: https://issues.apache.org/jira/browse/OPENEJB-1267
Project: OpenEJB
Issue Type: Improvement
Components: container system
Environment: All
Reporter: Andy Gumbrecht
Priority: Minor
Fix For: 3.1.x
Attachments: ActiveMQ.patch
Hardened the current ActiveMQResourceAdapter start and stop code.
The adapter should not prevent a server from starting or stopping, and is now threaded in context.
The ActiveMQ5Factory will now override the following configuration options which may cause shutdown issues if set to true.
broker.setUseShutdownHook(false);
broker.setSystemExitOnShutdown(false);
The broker is now started, and creates a check point, before it is returned to OpenEJB. This ensures that all pools and resources that ActiveMQ initiates are up before OpenEJB gains access.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENEJB-1267) ActiveMQResourceAdapter improvements
Posted by "Andy Gumbrecht (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andy Gumbrecht updated OPENEJB-1267:
------------------------------------
Attachment: ActiveMQ.patch
The suggested patch
> ActiveMQResourceAdapter improvements
> ------------------------------------
>
> Key: OPENEJB-1267
> URL: https://issues.apache.org/jira/browse/OPENEJB-1267
> Project: OpenEJB
> Issue Type: Improvement
> Components: container system
> Environment: All
> Reporter: Andy Gumbrecht
> Priority: Minor
> Fix For: 3.1.x
>
> Attachments: ActiveMQ.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Hardened the current ActiveMQResourceAdapter start and stop code.
> The adapter should not prevent a server from starting or stopping, and is now threaded in context.
> The ActiveMQ5Factory will now override the following configuration options which may cause shutdown issues if set to true.
> broker.setUseShutdownHook(false);
> broker.setSystemExitOnShutdown(false);
> The broker is now started, and creates a check point, before it is returned to OpenEJB. This ensures that all pools and resources that ActiveMQ initiates are up before OpenEJB gains access.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENEJB-1267) ActiveMQResourceAdapter
improvements
Posted by "David Blevins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869415#action_12869415 ]
David Blevins commented on OPENEJB-1267:
----------------------------------------
For some reason the patch fails on ActiveMQFactory.java. Is it possible you can resubmit?
It looks pretty good though! Love the better exception handling!
> ActiveMQResourceAdapter improvements
> ------------------------------------
>
> Key: OPENEJB-1267
> URL: https://issues.apache.org/jira/browse/OPENEJB-1267
> Project: OpenEJB
> Issue Type: Improvement
> Components: container system
> Environment: All
> Reporter: Andy Gumbrecht
> Priority: Minor
> Fix For: 3.1.x
>
> Attachments: ActiveMQ.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Hardened the current ActiveMQResourceAdapter start and stop code.
> The adapter should not prevent a server from starting or stopping, and is now threaded in context.
> The ActiveMQ5Factory will now override the following configuration options which may cause shutdown issues if set to true.
> broker.setUseShutdownHook(false);
> broker.setSystemExitOnShutdown(false);
> The broker is now started, and creates a check point, before it is returned to OpenEJB. This ensures that all pools and resources that ActiveMQ initiates are up before OpenEJB gains access.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENEJB-1267) ActiveMQResourceAdapter improvements
Posted by "Andy Gumbrecht (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andy Gumbrecht updated OPENEJB-1267:
------------------------------------
Attachment: OPENEJB-1267.patch
This is my current ActiveMQ state - Ok, not quite, as I am using snapshot 5.4 due to a specific bug I hit in 5.3.
Several code improvements, and RA start/stop hardening.
NOTE: This adds a test dep on hsqldb to the project pom due to a requirement to test against a live (in memory) database. I am NOT a maven wiz, so there may be a better way or pom location to do this?
> ActiveMQResourceAdapter improvements
> ------------------------------------
>
> Key: OPENEJB-1267
> URL: https://issues.apache.org/jira/browse/OPENEJB-1267
> Project: OpenEJB
> Issue Type: Improvement
> Components: container system
> Environment: All
> Reporter: Andy Gumbrecht
> Priority: Minor
> Fix For: 3.1.x
>
> Attachments: ActiveMQ.patch, ActiveMQ.patch, OPENEJB-1267.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Hardened the current ActiveMQResourceAdapter start and stop code.
> The adapter should not prevent a server from starting or stopping, and is now threaded in context.
> The ActiveMQ5Factory will now override the following configuration options which may cause shutdown issues if set to true.
> broker.setUseShutdownHook(false);
> broker.setSystemExitOnShutdown(false);
> The broker is now started, and creates a check point, before it is returned to OpenEJB. This ensures that all pools and resources that ActiveMQ initiates are up before OpenEJB gains access.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENEJB-1267) ActiveMQResourceAdapter
improvements
Posted by "Andy Gumbrecht (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869644#action_12869644 ]
Andy Gumbrecht commented on OPENEJB-1267:
-----------------------------------------
Done.
I'll get onto the replies for other subjects as soon as I can - Just
bogged down with this and that pending a release.
Regards,
Andy.
> ActiveMQResourceAdapter improvements
> ------------------------------------
>
> Key: OPENEJB-1267
> URL: https://issues.apache.org/jira/browse/OPENEJB-1267
> Project: OpenEJB
> Issue Type: Improvement
> Components: container system
> Environment: All
> Reporter: Andy Gumbrecht
> Priority: Minor
> Fix For: 3.1.x
>
> Attachments: ActiveMQ.patch, ActiveMQ.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Hardened the current ActiveMQResourceAdapter start and stop code.
> The adapter should not prevent a server from starting or stopping, and is now threaded in context.
> The ActiveMQ5Factory will now override the following configuration options which may cause shutdown issues if set to true.
> broker.setUseShutdownHook(false);
> broker.setSystemExitOnShutdown(false);
> The broker is now started, and creates a check point, before it is returned to OpenEJB. This ensures that all pools and resources that ActiveMQ initiates are up before OpenEJB gains access.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENEJB-1267) ActiveMQResourceAdapter improvements
Posted by "Andy Gumbrecht (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andy Gumbrecht updated OPENEJB-1267:
------------------------------------
Attachment: ActiveMQ.patch
Updated patch.
Fixed the test - Due to the fact that for ActiveMQ5 I now start and checkpoint the broker before returning it, the test needs a valid DataSource.
I just use an in memory hsqldb - So added this dep to the pom.
I have not done so in this patch, but the hsqldb version should be updated to 1.8.0.10 from 1.8.0.7 - I'll let you decide if we need that.
Also added a startup thread timeout - Using a default of 5 seconds, but maybe this should be much higher or at least configurable?
> ActiveMQResourceAdapter improvements
> ------------------------------------
>
> Key: OPENEJB-1267
> URL: https://issues.apache.org/jira/browse/OPENEJB-1267
> Project: OpenEJB
> Issue Type: Improvement
> Components: container system
> Environment: All
> Reporter: Andy Gumbrecht
> Priority: Minor
> Fix For: 3.1.x
>
> Attachments: ActiveMQ.patch, ActiveMQ.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Hardened the current ActiveMQResourceAdapter start and stop code.
> The adapter should not prevent a server from starting or stopping, and is now threaded in context.
> The ActiveMQ5Factory will now override the following configuration options which may cause shutdown issues if set to true.
> broker.setUseShutdownHook(false);
> broker.setSystemExitOnShutdown(false);
> The broker is now started, and creates a check point, before it is returned to OpenEJB. This ensures that all pools and resources that ActiveMQ initiates are up before OpenEJB gains access.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENEJB-1267) ActiveMQResourceAdapter
improvements
Posted by "Andy Gumbrecht (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861298#action_12861298 ]
Andy Gumbrecht commented on OPENEJB-1267:
-----------------------------------------
There is a persistent queue issue in the current ActiveMQ release that is resolved in the latest snapshot.
https://issues.apache.org/activemq/browse/AMQ-2696
I would therefore like to suggest that we use either of the latest 5.3 or 5.4 snapshots in OpenEJB trunk until the next release.
https://repository.apache.org/content/repositories/snapshots/org/apache/activemq/apache-activemq/
> ActiveMQResourceAdapter improvements
> ------------------------------------
>
> Key: OPENEJB-1267
> URL: https://issues.apache.org/jira/browse/OPENEJB-1267
> Project: OpenEJB
> Issue Type: Improvement
> Components: container system
> Environment: All
> Reporter: Andy Gumbrecht
> Priority: Minor
> Fix For: 3.1.x
>
> Attachments: ActiveMQ.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Hardened the current ActiveMQResourceAdapter start and stop code.
> The adapter should not prevent a server from starting or stopping, and is now threaded in context.
> The ActiveMQ5Factory will now override the following configuration options which may cause shutdown issues if set to true.
> broker.setUseShutdownHook(false);
> broker.setSystemExitOnShutdown(false);
> The broker is now started, and creates a check point, before it is returned to OpenEJB. This ensures that all pools and resources that ActiveMQ initiates are up before OpenEJB gains access.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OPENEJB-1267) ActiveMQResourceAdapter improvements
Posted by "David Blevins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Blevins closed OPENEJB-1267.
----------------------------------
Assignee: Andy Gumbrecht
Fix Version/s: 3.2-beta-1
(was: 3.1.x)
Resolution: Fixed
All committed! Thanks, Andy!
> ActiveMQResourceAdapter improvements
> ------------------------------------
>
> Key: OPENEJB-1267
> URL: https://issues.apache.org/jira/browse/OPENEJB-1267
> Project: OpenEJB
> Issue Type: Improvement
> Components: container system
> Environment: All
> Reporter: Andy Gumbrecht
> Assignee: Andy Gumbrecht
> Priority: Minor
> Fix For: 3.2-beta-1
>
> Attachments: ActiveMQ.patch, ActiveMQ.patch, OPENEJB-1267.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Hardened the current ActiveMQResourceAdapter start and stop code.
> The adapter should not prevent a server from starting or stopping, and is now threaded in context.
> The ActiveMQ5Factory will now override the following configuration options which may cause shutdown issues if set to true.
> broker.setUseShutdownHook(false);
> broker.setSystemExitOnShutdown(false);
> The broker is now started, and creates a check point, before it is returned to OpenEJB. This ensures that all pools and resources that ActiveMQ initiates are up before OpenEJB gains access.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.