Re: [PR] fix(parquet): honor explicit V1 FLBA dictionary opt-in [arrow-rs]

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on PR #10569:
URL: https://github.com/apache/arrow-rs/pull/10569#issuecomment-5591735149

   > > i'm kinda of the mind to just enable it by default, instead of honoring the previous default behaviour. for reference, was able to use codex to generate some duckdb code which shows that they can generate such files so i'm fairly sure its only a parquet-java limitation:
   > 
   > Yes, it seems to be an ancient parquet-mr holdover. I'm pretty sure java has been able to read this for quite some time.
   > 
   > > maybe if we double check against parquet-java, to see if it can read such files, we can just simplify this PR
   > 
   > I used pyarrow to generate a file with an FLBA column dict encoded and parquet-java 1.14 reads it just fine. I'd prefer to align with parquet-cpp and just enable the combination without opt-in. But I'm fine with the current state of this PR as well.
   
   @subotac are you able to implement @etseidl 's request to avoid the opt in ? This PR also appears to have some merge conflicts that need to be resolved before we can merge it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org