You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/01 03:09:07 UTC

[GitHub] [dubbo-samples] yzz1232 opened a new pull request #205: context Add test framework

yzz1232 opened a new pull request #205:
URL: https://github.com/apache/dubbo-samples/pull/205


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-samples] chickenlj merged pull request #205: context Add test framework

Posted by GitBox <gi...@apache.org>.
chickenlj merged pull request #205:
URL: https://github.com/apache/dubbo-samples/pull/205


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-samples] kylixs commented on a change in pull request #205: context Add test framework

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #205:
URL: https://github.com/apache/dubbo-samples/pull/205#discussion_r550726759



##########
File path: dubbo-samples-context/pom.xml
##########
@@ -32,25 +32,43 @@
         <spring.version>4.3.16.RELEASE</spring.version>
         <junit.version>4.12</junit.version>
         <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
-        <maven-failsafe-plugin.version>2.21.0</maven-failsafe-plugin.version>
-        <image.name>${project.artifactId}:${dubbo.version}</image.name>
-        <java-image.name>openjdk:8</java-image.name>
-        <dubbo.port>20890</dubbo.port>
-        <zookeeper.port>2181</zookeeper.port>
         <main-class>org.apache.dubbo.samples.context.ContextProvider</main-class>

Review comment:
       main-class 标签 删除掉




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org